Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-08 09:11:01 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Libraries/LibAudio/WavWriter.h

47 lines
1.2 KiB
C
Raw Normal View History

LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
/*
Everywhere: Tweak "2020-2020" => "2020" in copyright headers
2020-12-25 12:15:16 +01:00
* Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
*/
#pragma once
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 17:49:34 +03:30
#include <AK/ByteString.h>
Audio: Fix code smells and issues found by static analysis This fixes all current code smells, bugs and issues reported by SonarCloud static analysis. Other issues are almost exclusively false positives. This makes much code clearer, and some minor benefits in performance or bug evasion may be gained.
2021-11-15 22:27:28 +01:00
#include <AK/Noncopyable.h>
LibCore: Rename `File` to `DeprecatedFile` As usual, this removes many unused includes and moves used includes further down the chain.
2023-02-08 21:08:01 +01:00
#include <AK/RefPtr.h>
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
#include <AK/StringView.h>
LibAudio: Use Encoder interface for WavWriter The only real change here is the fallibility of the finalization function, which makes WavWriter's code quite a bit nicer.
2023-06-30 20:02:49 +02:00
#include <LibAudio/Encoder.h>
Piano+LibDSP: Move Track to LibDSP This is a tangly commit and it fixes all the bugs that a plain move would have caused (i.e. we need to touch other logic which had wrong assumptions).
2022-07-13 12:44:19 +02:00
#include <LibAudio/Sample.h>
LibAudio: Handle all integer PCM sample formats "correctly" in WavWriter WavWriter needs a TON of modernization work, but for now this commit just tackles two FIXMEs by converting samples correctly into all supported integer PCM formats. The supported formats are only signed 16-bit and unsigned 8-bit for now, but can be expanded later. At least we don't produce horrible speaker-destroying noise when writing any other format.
2023-03-08 15:25:56 +01:00
#include <LibAudio/SampleFormats.h>
Piano+LibAudio: Port to `Core::File`
2023-03-27 00:37:17 +00:00
#include <LibCore/File.h>
LibCore: Rename `File` to `DeprecatedFile` As usual, this removes many unused includes and moves used includes further down the chain.
2023-02-08 21:08:01 +01:00
#include <LibCore/Forward.h>
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
namespace Audio {
LibAudio: Use Encoder interface for WavWriter The only real change here is the fallibility of the finalization function, which makes WavWriter's code quite a bit nicer.
2023-06-30 20:02:49 +02:00
class WavWriter : public Encoder {
Audio: Fix code smells and issues found by static analysis This fixes all current code smells, bugs and issues reported by SonarCloud static analysis. Other issues are almost exclusively false positives. This makes much code clearer, and some minor benefits in performance or bug evasion may be gained.
2021-11-15 22:27:28 +01:00
AK_MAKE_NONCOPYABLE(WavWriter);
AK_MAKE_NONMOVABLE(WavWriter);
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
public:
LibAudio: Handle all integer PCM sample formats "correctly" in WavWriter WavWriter needs a TON of modernization work, but for now this commit just tackles two FIXMEs by converting samples correctly into all supported integer PCM formats. The supported formats are only signed 16-bit and unsigned 8-bit for now, but can be expanded later. At least we don't produce horrible speaker-destroying noise when writing any other format.
2023-03-08 15:25:56 +01:00
static ErrorOr<NonnullOwnPtr<WavWriter>> create_from_file(StringView path, int sample_rate = 44100, u16 num_channels = 2, PcmSampleFormat sample_format = PcmSampleFormat::Int16);
WavWriter(int sample_rate = 44100, u16 num_channels = 2, PcmSampleFormat sample_format = PcmSampleFormat::Int16);
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
~WavWriter();
LibAudio: Use Encoder interface for WavWriter The only real change here is the fallibility of the finalization function, which makes WavWriter's code quite a bit nicer.
2023-06-30 20:02:49 +02:00
virtual ErrorOr<void> write_samples(ReadonlySpan<Sample> samples) override;
virtual ErrorOr<void> finalize() override;
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
Piano+LibAudio: Port to `Core::File`
2023-03-27 00:37:17 +00:00
ErrorOr<void> set_file(StringView path);
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
private:
Piano+LibAudio: Port to `Core::File`
2023-03-27 00:37:17 +00:00
ErrorOr<void> write_header();
LibAudio: Speed up WavWriter by buffering output data We were calling write syscall twice for every sample, which effectively hurt the writer's performance. With this change exporting a melody in the Piano app now takes less than a second, which previously took about 20 seconds on my machine. Additionally, I've removed an unused `WavWriter::file()` getter.
2023-11-23 22:09:13 +01:00
OwnPtr<Core::OutputBufferedFile> m_file;
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
bool m_finalized { false };
u32 m_sample_rate;
u16 m_num_channels;
LibAudio: Handle all integer PCM sample formats "correctly" in WavWriter WavWriter needs a TON of modernization work, but for now this commit just tackles two FIXMEs by converting samples correctly into all supported integer PCM formats. The supported formats are only signed 16-bit and unsigned 8-bit for now, but can be expanded later. At least we don't produce horrible speaker-destroying noise when writing any other format.
2023-03-08 15:25:56 +01:00
PcmSampleFormat m_sample_format;
LibAudio: Implement Audio::WavWriter This class mirrors WavLoader and uses the same variable names so they can be read side-by-side. In a simple use-case, you construct a WavWriter object with your file path and audio parameters, call write_samples() with your bytes and then either finalize() to finish writing the file or allow the destructor to do it automatically. finalize() is needed because the WAV header cannot be written until the size of the data section is known. You only need to call this manually if you want to write a WAV file and then immediately load it. You can also use one WavWriter instance multiple times by repeatedly calling finalize() and set_file().
2020-02-06 17:33:12 +11:00
u32 m_data_sz { 0 };
};
}
Reference in a new issue Copy permalink