Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-31 21:30:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/SVG/SVGSVGElement.h

123 lines
4.4 KiB
C
Raw Normal View History

LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
/*
* Copyright (c) 2020, Matthew Olsson <matthewcolsson@gmail.com>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
*/
#pragma once
#include <LibGfx/Bitmap.h>
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
#include <LibWeb/DOM/NonElementParentNode.h>
#include <LibWeb/Geometry/DOMMatrix.h>
#include <LibWeb/Geometry/DOMPoint.h>
LibWeb: Implement SVG `preserveAspectRatio` attribute This attribute is used to define how the viewBox should be scaled. Previously the behaviour implemented was that of "xMidYMid meet", now all of them work (expect none :P). With this the Discord login backend is now correctly scaled/positioned. This also brings our SVG code a little closer to the spec! With spec comments and all :^) (Minor non-visible update to layout tests)
2023-04-17 01:20:24 +01:00
#include <LibWeb/SVG/AttributeParser.h>
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
#include <LibWeb/SVG/SVGAnimatedLength.h>
LibWeb: Refactor SVG files into their own directory; follow spec layout
2020-07-23 09:44:42 -07:00
#include <LibWeb/SVG/SVGGraphicsElement.h>
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
#include <LibWeb/SVG/SVGLength.h>
#include <LibWeb/SVG/SVGTransform.h>
LibWeb: Add initial support for nesting SVG viewports Previously, we were handling viewBoxes/viewports in a slightly hacky way, asking graphics elements to figure out what viewBox to use during layout. This does not work in all cases, and can't allow for more complex SVGs where it is possible to have nested viewports. This commit makes the SVGFormattingContext keep track of the viewport/boxes, and it now lays out each viewport recursively, where each nested `<svg>` or `<symbol>` can establish a new viewport. This fixes some previous edge cases, and starts to allow nested viewports (there's still some issues to resolve there). Fixes #22931
2024-01-27 16:23:22 +00:00
#include <LibWeb/SVG/SVGViewport.h>
LibWeb: Parse the <svg viewBox> attribute Just parse it into an SVG::ViewBox object for now, we don't actually use it for anything yet.
2021-09-15 01:12:41 +02:00
#include <LibWeb/SVG/ViewBox.h>
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
#include <LibWeb/WebIDL/Types.h>
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb: Refactor SVG files into their own directory; follow spec layout
2020-07-23 09:44:42 -07:00
namespace Web::SVG {
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb: Add initial support for nesting SVG viewports Previously, we were handling viewBoxes/viewports in a slightly hacky way, asking graphics elements to figure out what viewBox to use during layout. This does not work in all cases, and can't allow for more complex SVGs where it is possible to have nested viewports. This commit makes the SVGFormattingContext keep track of the viewport/boxes, and it now lays out each viewport recursively, where each nested `<svg>` or `<symbol>` can establish a new viewport. This fixes some previous edge cases, and starts to allow nested viewports (there's still some issues to resolve there). Fixes #22931
2024-01-27 16:23:22 +00:00
class SVGSVGElement final : public SVGGraphicsElement
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
, public SVGViewport
// SVGSVGElement is not strictly a NonElementParentNode, but it implements the same get_element_by_id() method.
, public DOM::NonElementParentNode<SVGSVGElement> {
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 13:42:07 +02:00
WEB_PLATFORM_OBJECT(SVGSVGElement, SVGGraphicsElement);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DECLARE_ALLOCATOR(SVGSVGElement);
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 13:42:07 +02:00
public:
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-20 16:35:12 +01:00
virtual GC::Ptr<Layout::Node> create_layout_node(GC::Ref<CSS::ComputedProperties>) override;
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb: Avoid many style invalidations on DOM attribute mutation Many times, attribute mutation doesn't necessitate a full style invalidation on the element. However, the conditions are pretty elaborate, so this first version has a lot of false positives. We only need to invalidate style when any of these things apply: 1. The change may affect the match state of a selector somewhere. 2. The change may affect presentational hints applied to the element. For (1) in this first version, we have a fixed list of attribute names that may affect selectors. We also collect all names referenced by attribute selectors anywhere in the document. For (2), we add a new Element::is_presentational_hint() virtual that tells us whether a given attribute name is a presentational hint. This drastically reduces style work on many websites. As an example, https://cnn.com/ is once again browseable.
2024-12-23 17:51:10 +01:00
virtual bool is_presentational_hint(FlyString const&) const override;
LibWeb: Split StyleComputer work into two phases with separate outputs Before this change, StyleComputer would essentially take a DOM element, find all the CSS rules that apply to it, and resolve the computed value for each CSS property for that element. This worked great, but it meant we had to do all the work of selector matching and cascading every time. To enable new optimizations, this change introduces a break in the middle of this process where we've produced a "CascadedProperties". This object contains the result of the cascade, before we've begun turning cascaded values into computed values. The cascaded properties are now stored with each element, which will later allow us to do partial updates without re-running the full StyleComputer machine. This will be particularly valuable for re-implementing CSS inheritance, which is extremely heavy today. Note that CSS animations and CSS transitions operate entirely on the computed values, even though the cascade order would have you believe they happen earlier. I'm not confident we have the right architecture for this, but that's a separate issue.
2024-12-12 10:06:29 +01:00
virtual void apply_presentational_hints(GC::Ref<CSS::CascadedProperties>) const override;
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
LibWeb: Ignore svg elements outside of <svg> when building layout tree An svg layout element without a `SVGSVGElement` ancestor caused a failed assertion before, because the svg context does not exist when `paint()` is called
2021-08-05 10:26:09 +02:00
virtual bool requires_svg_container() const override { return false; }
virtual bool is_svg_container() const override { return true; }
LibWeb: Add initial support for nesting SVG viewports Previously, we were handling viewBoxes/viewports in a slightly hacky way, asking graphics elements to figure out what viewBox to use during layout. This does not work in all cases, and can't allow for more complex SVGs where it is possible to have nested viewports. This commit makes the SVGFormattingContext keep track of the viewport/boxes, and it now lays out each viewport recursively, where each nested `<svg>` or `<symbol>` can establish a new viewport. This fixes some previous edge cases, and starts to allow nested viewports (there's still some issues to resolve there). Fixes #22931
2024-01-27 16:23:22 +00:00
virtual Optional<ViewBox> view_box() const override;
virtual Optional<PreserveAspectRatio> preserve_aspect_ratio() const override { return m_preserve_aspect_ratio; }
LibWeb: Parse the <svg viewBox> attribute Just parse it into an SVG::ViewBox object for now, we don't actually use it for anything yet.
2021-09-15 01:12:41 +02:00
LibWeb: Use width & height to create fallback viewBox for SVG-as-image When embedding an SVG in an img element, if the external SVG's root element has both width and height attributes, but no viewBox attribute, we now create a fallback viewBox with "0 0 width height". This appears to match the behavior of other browsers. Inspired by discussion on Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=614649
2023-06-20 09:39:14 +02:00
void set_fallback_view_box_for_svg_as_image(Optional<ViewBox>);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedRect> view_box_for_bindings() { return *m_view_box_for_bindings; }
LibWeb: Add SVGSVGElement.viewBox attribute This attribute has some compatbility issues... - The spec says it should be an SVGAnimatedRect which contains a DOMRect and a DOMReadOnlyRect. - Blink gives you an SVGAnimatedRect with 2x SVGRect - Gecko gives you an SVGAnimatedRect with 2x SVGRect? (nullable) I ended up with something similar to Gecko, an SVGAnimatedRect with 2x DOMRect? (nullable) With this fixed, we can now load https://polar.sh/ :^)
2024-01-24 22:54:16 +01:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> x() const;
GC::Ref<SVGAnimatedLength> y() const;
GC::Ref<SVGAnimatedLength> width() const;
GC::Ref<SVGAnimatedLength> height() const;
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
float current_scale() const;
void set_current_scale(float);
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<Geometry::DOMPointReadOnly> current_translate() const;
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<DOM::NodeList> get_intersection_list(GC::Ref<Geometry::DOMRectReadOnly> rect, GC::Ptr<SVGElement> reference_element) const;
GC::Ref<DOM::NodeList> get_enclosure_list(GC::Ref<Geometry::DOMRectReadOnly> rect, GC::Ptr<SVGElement> reference_element) const;
bool check_intersection(GC::Ref<SVGElement> element, GC::Ref<Geometry::DOMRectReadOnly> rect) const;
bool check_enclosure(GC::Ref<SVGElement> element, GC::Ref<Geometry::DOMRectReadOnly> rect) const;
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
void deselect_all() const;
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGLength> create_svg_length() const;
GC::Ref<Geometry::DOMPoint> create_svg_point() const;
GC::Ref<Geometry::DOMMatrix> create_svg_matrix() const;
GC::Ref<Geometry::DOMRect> create_svg_rect() const;
GC::Ref<SVGTransform> create_svg_transform() const;
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
// Deprecated methods that have no effect when called, but which are kept for compatibility reasons.
WebIDL::UnsignedLong suspend_redraw(WebIDL::UnsignedLong max_wait_milliseconds) const
{
(void)max_wait_milliseconds;
// When the suspendRedraw method is called, it must return 1.
return 1;
}
void unsuspend_redraw(WebIDL::UnsignedLong suspend_handle_id) const
{
(void)suspend_handle_id;
}
LibWeb: Derive SVG root's natural size from width/height attributes We were incorrectly looking at the CSS computed values for width and height to determine the natural size of <svg> root elements. This meant that elements where the attribute and computed value were different values would end up with incorrect natural size.
2024-08-22 13:32:25 +02:00
void unsuspend_redraw_all() const { }
void force_redraw() const { }
[[nodiscard]] RefPtr<CSS::CSSStyleValue> width_style_value_from_attribute() const;
[[nodiscard]] RefPtr<CSS::CSSStyleValue> height_style_value_from_attribute() const;
LibWeb: Stub (and implement) `SVGSVGElement` methods and attributes This implements trivial functions and stubs out the rest. Implemented: ``` [SameObject] readonly attribute SVGAnimatedLength x; [SameObject] readonly attribute SVGAnimatedLength y; [SameObject] readonly attribute SVGAnimatedLength width; [SameObject] readonly attribute SVGAnimatedLength height; undefined deselectAll(); SVGLength createSVGLength(); DOMPoint createSVGPoint(); DOMMatrix createSVGMatrix(); DOMRect createSVGRect(); SVGTransform createSVGTransform(); Element getElementById(DOMString elementId); unsigned long suspendRedraw(unsigned long maxWaitMilliseconds); undefined unsuspendRedraw(unsigned long suspendHandleID); undefined unsuspendRedrawAll(); undefined forceRedraw(); ``` Stubbed: ``` attribute float currentScale; [SameObject] readonly attribute DOMPointReadOnly currentTranslate; NodeList getIntersectionList( DOMRectReadOnly rect, SVGElement? referenceElement); NodeList getEnclosureList( DOMRectReadOnly rect, SVGElement? referenceElement); boolean checkIntersection(SVGElement element, DOMRectReadOnly rect); boolean checkEnclosure(SVGElement element, DOMRectReadOnly rect); ```
2024-04-01 00:51:24 +01:00
LibWeb: Teach HTMLObjectElement to negotiate natural size with SVGs We do this by generalizing the code previously used for SVGSVGBox into something that can be used for NavigableViewportContainer as well.
2024-11-26 12:30:11 +01:00
struct NaturalMetrics {
Optional<CSSPixels> width;
Optional<CSSPixels> height;
Optional<CSSPixelFraction> aspect_ratio;
};
static NaturalMetrics negotiate_natural_metrics(SVGSVGElement const&);
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
private:
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
2022-08-28 13:42:07 +02:00
SVGSVGElement(DOM::Document&, DOM::QualifiedName);
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 08:41:28 +02:00
virtual void initialize(JS::Realm&) override;
LibWeb: Add SVGSVGElement.viewBox attribute This attribute has some compatbility issues... - The spec says it should be an SVGAnimatedRect which contains a DOMRect and a DOMReadOnlyRect. - Blink gives you an SVGAnimatedRect with 2x SVGRect - Gecko gives you an SVGAnimatedRect with 2x SVGRect? (nullable) I ended up with something similar to Gecko, an SVGAnimatedRect with 2x DOMRect? (nullable) With this fixed, we can now load https://polar.sh/ :^)
2024-01-24 22:54:16 +01:00
virtual void visit_edges(Visitor&) override;
LibWeb: Move setting of Web object prototypes to initialize() This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
2023-01-10 06:28:20 -05:00
LibWeb: Add fast_is<SVG::SVGSVGElement>()
2022-03-12 16:08:40 +01:00
virtual bool is_svg_svg_element() const override { return true; }
LibWeb: Consolidate the attribute change handlers We currently have 2 virtual methods to inform DOM::Element subclasses when an attribute has changed, one of which is spec-compliant. This patch removes the non-compliant variant.
2024-11-14 08:14:16 -05:00
virtual void attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_) override;
LibWeb: Parse the <svg viewBox> attribute Just parse it into an SVG::ViewBox object for now, we don't actually use it for anything yet.
2021-09-15 01:12:41 +02:00
LibWeb: Use width & height to create fallback viewBox for SVG-as-image When embedding an SVG in an img element, if the external SVG's root element has both width and height attributes, but no viewBox attribute, we now create a fallback viewBox with "0 0 width height". This appears to match the behavior of other browsers. Inspired by discussion on Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=614649
2023-06-20 09:39:14 +02:00
void update_fallback_view_box_for_svg_as_image();
LibWeb: Parse the <svg viewBox> attribute Just parse it into an SVG::ViewBox object for now, we don't actually use it for anything yet.
2021-09-15 01:12:41 +02:00
Optional<ViewBox> m_view_box;
LibWeb: Implement SVG `preserveAspectRatio` attribute This attribute is used to define how the viewBox should be scaled. Previously the behaviour implemented was that of "xMidYMid meet", now all of them work (expect none :P). With this the Discord login backend is now correctly scaled/positioned. This also brings our SVG code a little closer to the spec! With spec comments and all :^) (Minor non-visible update to layout tests)
2023-04-17 01:20:24 +01:00
Optional<PreserveAspectRatio> m_preserve_aspect_ratio;
LibWeb: Use width & height to create fallback viewBox for SVG-as-image When embedding an SVG in an img element, if the external SVG's root element has both width and height attributes, but no viewBox attribute, we now create a fallback viewBox with "0 0 width height". This appears to match the behavior of other browsers. Inspired by discussion on Mozilla's bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=614649
2023-06-20 09:39:14 +02:00
Optional<ViewBox> m_fallback_view_box_for_svg_as_image;
LibWeb: Add SVGSVGElement.viewBox attribute This attribute has some compatbility issues... - The spec says it should be an SVGAnimatedRect which contains a DOMRect and a DOMReadOnlyRect. - Blink gives you an SVGAnimatedRect with 2x SVGRect - Gecko gives you an SVGAnimatedRect with 2x SVGRect? (nullable) I ended up with something similar to Gecko, an SVGAnimatedRect with 2x DOMRect? (nullable) With this fixed, we can now load https://polar.sh/ :^)
2024-01-24 22:54:16 +01:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ptr<SVGAnimatedRect> m_view_box_for_bindings;
LibWeb: Begin SVG element support This commit starts adding a basic SVG element. Currently, svg elements have support for the width and height properties, as well as the stroke, stroke-width, and fill properties. The only child element supported is the path element, as most other graphical elements are just shorthand for paths.
2020-07-19 23:01:53 -07:00
};
}
LibWeb: Add fast_is<SVG::SVGSVGElement>()
2022-03-12 16:08:40 +01:00
namespace Web::DOM {
template<>
inline bool Node::fast_is<SVG::SVGSVGElement>() const { return is_svg_svg_element(); }
}
Reference in a new issue Copy permalink