2021-06-19 21:45:00 +01:00
/*
* Copyright ( c ) 2020 - 2021 , Linus Groh < linusg @ serenityos . org >
2021-06-22 00:56:14 +02:00
* Copyright ( c ) 2021 , Andreas Kling < kling @ serenityos . org >
2021-06-19 21:45:00 +01:00
*
* SPDX - License - Identifier : BSD - 2 - Clause
*/
2021-07-05 16:16:48 -04:00
# include <AK/CharacterTypes.h>
2021-06-19 21:45:00 +01:00
# include <AK/Function.h>
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
# include <AK/Optional.h>
2021-06-19 20:13:53 -07:00
# include <AK/TemporaryChange.h>
2021-07-19 16:53:35 -04:00
# include <AK/Utf16View.h>
2021-06-19 20:13:53 -07:00
# include <LibJS/Interpreter.h>
# include <LibJS/Parser.h>
2021-06-19 21:45:00 +01:00
# include <LibJS/Runtime/AbstractOperations.h>
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
# include <LibJS/Runtime/Accessor.h>
2021-06-28 13:26:01 +02:00
# include <LibJS/Runtime/ArgumentsObject.h>
2021-06-28 01:44:58 +02:00
# include <LibJS/Runtime/Array.h>
2021-06-19 21:45:00 +01:00
# include <LibJS/Runtime/BoundFunction.h>
2021-09-15 20:52:21 +01:00
# include <LibJS/Runtime/Completion.h>
2021-07-01 12:24:46 +02:00
# include <LibJS/Runtime/DeclarativeEnvironment.h>
2021-09-22 12:44:56 +02:00
# include <LibJS/Runtime/ECMAScriptFunctionObject.h>
2021-06-19 21:45:00 +01:00
# include <LibJS/Runtime/ErrorTypes.h>
2021-07-01 12:24:46 +02:00
# include <LibJS/Runtime/FunctionEnvironment.h>
2021-06-27 21:48:34 +02:00
# include <LibJS/Runtime/FunctionObject.h>
2021-06-19 21:45:00 +01:00
# include <LibJS/Runtime/GlobalObject.h>
# include <LibJS/Runtime/Object.h>
2021-07-01 12:24:46 +02:00
# include <LibJS/Runtime/ObjectEnvironment.h>
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
# include <LibJS/Runtime/PropertyDescriptor.h>
2021-06-19 21:45:00 +01:00
# include <LibJS/Runtime/PropertyName.h>
2021-06-19 22:15:00 +01:00
# include <LibJS/Runtime/ProxyObject.h>
2021-07-03 00:20:52 +02:00
# include <LibJS/Runtime/Reference.h>
2021-06-19 21:45:00 +01:00
namespace JS {
// 7.2.1 RequireObjectCoercible ( argument ), https://tc39.es/ecma262/#sec-requireobjectcoercible
2021-09-15 20:52:21 +01:00
ThrowCompletionOr < Value > require_object_coercible ( GlobalObject & global_object , Value value )
2021-06-19 21:45:00 +01:00
{
auto & vm = global_object . vm ( ) ;
2021-09-15 20:52:21 +01:00
if ( value . is_nullish ( ) )
return vm . throw_completion < TypeError > ( global_object , ErrorType : : NotObjectCoercible , value . to_string_without_side_effects ( ) ) ;
2021-06-19 21:45:00 +01:00
return value ;
}
LibJS: Implement [[Call]] and [[Construct]] internal slots properly
This patch implements:
- Spec compliant [[Call]] and [[Construct]] internal slots, as virtual
FunctionObject::internal_{call,construct}(). These effectively replace
the old virtual FunctionObject::{call,construct}(), but with several
advantages:
- Clear and consistent naming, following the object internal methods
- Use of completions
- internal_construct() returns an Object, and not Value! This has been
a source of confusion for a long time, since in the spec there's
always an Object returned but the Value return type in LibJS meant
that this could not be fully trusted and something could screw you
over.
- Arguments are passed explicitly in form of a MarkedValueList,
allowing manipulation (BoundFunction). We still put them on the
execution context as a lot of code depends on it (VM::arguments()),
but not from the Call() / Construct() AOs anymore, which now allows
for bypassing them and invoking [[Call]] / [[Construct]] directly.
Nothing but Call() / Construct() themselves do that at the moment,
but future additions to ECMA262 or already existing web specs might.
- Spec compliant, standalone Call() and Construct() AOs: currently the
closest we have is VM::{call,construct}(), but those try to cater to
all the different function object subclasses at once, resulting in a
horrible mess and calling AOs with functions they should never be
called with; most prominently PrepareForOrdinaryCall and
OrdinaryCallBindThis, which are only for ECMAScriptFunctionObject.
As a result this also contains an implicit optimization: we no longer
need to create a new function environment for NativeFunctions - which,
worth mentioning, is what started this whole crusade in the first place
:^)
2021-10-08 20:37:21 +01:00
// 7.3.13 Call ( F, V [ , argumentsList ] ), https://tc39.es/ecma262/#sec-call
ThrowCompletionOr < Value > call_impl ( GlobalObject & global_object , Value function , Value this_value , Optional < MarkedValueList > arguments_list )
{
auto & vm = global_object . vm ( ) ;
// 1. If argumentsList is not present, set argumentsList to a new empty List.
if ( ! arguments_list . has_value ( ) )
arguments_list = MarkedValueList { global_object . heap ( ) } ;
// 2. If IsCallable(F) is false, throw a TypeError exception.
if ( ! function . is_function ( ) )
return vm . throw_completion < TypeError > ( global_object , ErrorType : : NotAFunction , function . to_string_without_side_effects ( ) ) ;
// 3. Return ? F.[[Call]](V, argumentsList).
return function . as_function ( ) . internal_call ( this_value , move ( * arguments_list ) ) ;
}
// 7.3.14 Construct ( F [ , argumentsList [ , newTarget ] ] ), https://tc39.es/ecma262/#sec-construct
ThrowCompletionOr < Object * > construct ( GlobalObject & global_object , FunctionObject & function , Optional < MarkedValueList > arguments_list , FunctionObject * new_target )
{
// 1. If newTarget is not present, set newTarget to F.
if ( ! new_target )
new_target = & function ;
// 2. If argumentsList is not present, set argumentsList to a new empty List.
if ( ! arguments_list . has_value ( ) )
arguments_list = MarkedValueList { global_object . heap ( ) } ;
// 3. Return ? F.[[Construct]](argumentsList, newTarget).
return function . internal_construct ( move ( * arguments_list ) , * new_target ) ;
}
2021-06-19 21:45:00 +01:00
// 7.3.18 LengthOfArrayLike ( obj ), https://tc39.es/ecma262/#sec-lengthofarraylike
2021-09-21 21:59:49 +03:00
ThrowCompletionOr < size_t > length_of_array_like ( GlobalObject & global_object , Object const & object )
2021-06-19 21:45:00 +01:00
{
auto & vm = global_object . vm ( ) ;
2021-10-02 23:52:27 +01:00
auto result = TRY ( object . get ( vm . names . length ) ) ;
2021-09-21 21:59:49 +03:00
auto length = result . to_length ( global_object ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
return length ;
2021-06-19 21:45:00 +01:00
}
// 7.3.19 CreateListFromArrayLike ( obj [ , elementTypes ] ), https://tc39.es/ecma262/#sec-createlistfromarraylike
2021-09-15 20:55:07 +01:00
ThrowCompletionOr < MarkedValueList > create_list_from_array_like ( GlobalObject & global_object , Value value , Function < ThrowCompletionOr < void > ( Value ) > check_value )
2021-06-19 21:45:00 +01:00
{
auto & vm = global_object . vm ( ) ;
auto & heap = global_object . heap ( ) ;
2021-09-15 20:55:07 +01:00
// 1. If elementTypes is not present, set elementTypes to « Undefined, Null, Boolean, String, Symbol, Number, BigInt, Object ».
// 2. If Type(obj) is not Object, throw a TypeError exception.
if ( ! value . is_object ( ) )
return vm . throw_completion < TypeError > ( global_object , ErrorType : : NotAnObject , value . to_string_without_side_effects ( ) ) ;
2021-06-19 21:45:00 +01:00
auto & array_like = value . as_object ( ) ;
2021-09-15 20:55:07 +01:00
// 3. Let len be ? LengthOfArrayLike(obj).
2021-09-21 21:59:49 +03:00
auto length = TRY ( length_of_array_like ( global_object , array_like ) ) ;
2021-09-15 20:55:07 +01:00
// 4. Let list be a new empty List.
2021-06-19 21:45:00 +01:00
auto list = MarkedValueList { heap } ;
2021-09-15 20:55:07 +01:00
// 5. Let index be 0.
// 6. Repeat, while index < len,
2021-06-19 21:45:00 +01:00
for ( size_t i = 0 ; i < length ; + + i ) {
2021-09-15 20:55:07 +01:00
// a. Let indexName be ! ToString(𝔽 (index)).
2021-10-04 22:53:04 +02:00
auto index_name = PropertyName { i } ;
2021-09-15 20:55:07 +01:00
// b. Let next be ? Get(obj, indexName).
2021-10-02 23:52:27 +01:00
auto next = TRY ( array_like . get ( index_name ) ) ;
2021-09-15 20:55:07 +01:00
// c. If Type(next) is not an element of elementTypes, throw a TypeError exception.
if ( check_value )
TRY ( check_value ( next ) ) ;
// d. Append next as the last element of list.
2021-06-19 21:45:00 +01:00
list . append ( next ) ;
}
2021-09-15 20:55:07 +01:00
// 7. Return list.
2021-09-16 01:53:24 -07:00
return ThrowCompletionOr ( move ( list ) ) ;
2021-06-19 21:45:00 +01:00
}
// 7.3.22 SpeciesConstructor ( O, defaultConstructor ), https://tc39.es/ecma262/#sec-speciesconstructor
2021-09-15 21:05:05 +01:00
ThrowCompletionOr < FunctionObject * > species_constructor ( GlobalObject & global_object , Object const & object , FunctionObject & default_constructor )
2021-06-19 21:45:00 +01:00
{
auto & vm = global_object . vm ( ) ;
2021-09-15 21:05:05 +01:00
// 1. Let C be ? Get(O, "constructor").
2021-10-02 23:52:27 +01:00
auto constructor = TRY ( object . get ( vm . names . constructor ) ) ;
2021-09-15 21:05:05 +01:00
// 2. If C is undefined, return defaultConstructor.
2021-06-19 21:45:00 +01:00
if ( constructor . is_undefined ( ) )
return & default_constructor ;
2021-09-15 21:05:05 +01:00
// 3. If Type(C) is not Object, throw a TypeError exception.
if ( ! constructor . is_object ( ) )
return vm . throw_completion < TypeError > ( global_object , ErrorType : : NotAConstructor , constructor . to_string_without_side_effects ( ) ) ;
// 4. Let S be ? Get(C, @@species).
2021-10-02 23:52:27 +01:00
auto species = TRY ( constructor . as_object ( ) . get ( * vm . well_known_symbol_species ( ) ) ) ;
2021-09-15 21:05:05 +01:00
// 5. If S is either undefined or null, return defaultConstructor.
2021-06-19 21:45:00 +01:00
if ( species . is_nullish ( ) )
return & default_constructor ;
2021-09-15 21:05:05 +01:00
// 6. If IsConstructor(S) is true, return S.
2021-06-19 21:45:00 +01:00
if ( species . is_constructor ( ) )
return & species . as_function ( ) ;
2021-09-15 21:05:05 +01:00
// 7. Throw a TypeError exception.
return vm . throw_completion < TypeError > ( global_object , ErrorType : : NotAConstructor , species . to_string_without_side_effects ( ) ) ;
2021-06-19 21:45:00 +01:00
}
2021-06-19 22:15:00 +01:00
// 7.3.24 GetFunctionRealm ( obj ), https://tc39.es/ecma262/#sec-getfunctionrealm
2021-09-15 21:09:33 +01:00
ThrowCompletionOr < Realm * > get_function_realm ( GlobalObject & global_object , FunctionObject const & function )
2021-06-19 22:15:00 +01:00
{
auto & vm = global_object . vm ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 1. Assert: ! IsCallable(obj) is true.
// 2. If obj has a [[Realm]] internal slot, then
if ( function . realm ( ) ) {
// a. Return obj.[[Realm]].
2021-09-11 22:05:43 +01:00
return function . realm ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
}
// 3. If obj is a bound function exotic object, then
2021-06-19 22:15:00 +01:00
if ( is < BoundFunction > ( function ) ) {
auto & bound_function = static_cast < BoundFunction const & > ( function ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// a. Let target be obj.[[BoundTargetFunction]].
2021-09-25 00:16:39 +02:00
auto & target = bound_function . bound_target_function ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// b. Return ? GetFunctionRealm(target).
2021-06-19 22:15:00 +01:00
return get_function_realm ( global_object , target ) ;
}
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 4. If obj is a Proxy exotic object, then
2021-06-19 22:15:00 +01:00
if ( is < ProxyObject > ( function ) ) {
auto & proxy = static_cast < ProxyObject const & > ( function ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// a. If obj.[[ProxyHandler]] is null, throw a TypeError exception.
2021-09-15 21:09:33 +01:00
if ( proxy . is_revoked ( ) )
return vm . throw_completion < TypeError > ( global_object , ErrorType : : ProxyRevoked ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// b. Let proxyTarget be obj.[[ProxyTarget]].
2021-06-19 22:15:00 +01:00
auto & proxy_target = proxy . target ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// c. Return ? GetFunctionRealm(proxyTarget).
2021-06-19 22:15:00 +01:00
VERIFY ( proxy_target . is_function ( ) ) ;
2021-06-27 21:48:34 +02:00
return get_function_realm ( global_object , static_cast < FunctionObject const & > ( proxy_target ) ) ;
2021-06-19 22:15:00 +01:00
}
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
2021-06-19 22:15:00 +01:00
// 5. Return the current Realm Record.
2021-09-11 22:05:43 +01:00
return vm . current_realm ( ) ;
2021-06-19 22:15:00 +01:00
}
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 10.1.6.2 IsCompatiblePropertyDescriptor ( Extensible, Desc, Current ), https://tc39.es/ecma262/#sec-iscompatiblepropertydescriptor
bool is_compatible_property_descriptor ( bool extensible , PropertyDescriptor const & descriptor , Optional < PropertyDescriptor > const & current )
{
// 1. Return ValidateAndApplyPropertyDescriptor(undefined, undefined, Extensible, Desc, Current).
return validate_and_apply_property_descriptor ( nullptr , { } , extensible , descriptor , current ) ;
}
2021-07-07 01:32:11 +03:00
// 10.1.6.3 ValidateAndApplyPropertyDescriptor ( O, P, extensible, Desc, current ), https://tc39.es/ecma262/#sec-validateandapplypropertydescriptor
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
bool validate_and_apply_property_descriptor ( Object * object , PropertyName const & property_name , bool extensible , PropertyDescriptor const & descriptor , Optional < PropertyDescriptor > const & current )
{
// 1. Assert: If O is not undefined, then IsPropertyKey(P) is true.
if ( object )
VERIFY ( property_name . is_valid ( ) ) ;
// 2. If current is undefined, then
if ( ! current . has_value ( ) ) {
// a. If extensible is false, return false.
if ( ! extensible )
return false ;
// b. Assert: extensible is true.
// c. If IsGenericDescriptor(Desc) is true or IsDataDescriptor(Desc) is true, then
if ( descriptor . is_generic_descriptor ( ) | | descriptor . is_data_descriptor ( ) ) {
// i. If O is not undefined, create an own data property named P of object O whose [[Value]], [[Writable]],
// [[Enumerable]], and [[Configurable]] attribute values are described by Desc.
// If the value of an attribute field of Desc is absent, the attribute of the newly created property is set
// to its default value.
if ( object ) {
auto value = descriptor . value . value_or ( js_undefined ( ) ) ;
object - > storage_set ( property_name , { value , descriptor . attributes ( ) } ) ;
}
}
// d. Else,
else {
// i. Assert: ! IsAccessorDescriptor(Desc) is true.
VERIFY ( descriptor . is_accessor_descriptor ( ) ) ;
// ii. If O is not undefined, create an own accessor property named P of object O whose [[Get]], [[Set]],
// [[Enumerable]], and [[Configurable]] attribute values are described by Desc.
// If the value of an attribute field of Desc is absent, the attribute of the newly created property is set
// to its default value.
if ( object ) {
auto accessor = Accessor : : create ( object - > vm ( ) , descriptor . get . value_or ( nullptr ) , descriptor . set . value_or ( nullptr ) ) ;
object - > storage_set ( property_name , { accessor , descriptor . attributes ( ) } ) ;
}
}
// e. Return true.
return true ;
}
// 3. If every field in Desc is absent, return true.
if ( descriptor . is_empty ( ) )
return true ;
// 4. If current.[[Configurable]] is false, then
if ( ! * current - > configurable ) {
// a. If Desc.[[Configurable]] is present and its value is true, return false.
if ( descriptor . configurable . has_value ( ) & & * descriptor . configurable )
return false ;
// b. If Desc.[[Enumerable]] is present and ! SameValue(Desc.[[Enumerable]], current.[[Enumerable]]) is false, return false.
if ( descriptor . enumerable . has_value ( ) & & * descriptor . enumerable ! = * current - > enumerable )
return false ;
}
// 5. If ! IsGenericDescriptor(Desc) is true, then
if ( descriptor . is_generic_descriptor ( ) ) {
// a. NOTE: No further validation is required.
}
// 6. Else if ! SameValue(! IsDataDescriptor(current), ! IsDataDescriptor(Desc)) is false, then
else if ( current - > is_data_descriptor ( ) ! = descriptor . is_data_descriptor ( ) ) {
// a. If current.[[Configurable]] is false, return false.
if ( ! * current - > configurable )
return false ;
// b. If IsDataDescriptor(current) is true, then
if ( current - > is_data_descriptor ( ) ) {
// If O is not undefined, convert the property named P of object O from a data property to an accessor property.
// Preserve the existing values of the converted property's [[Configurable]] and [[Enumerable]] attributes and
// set the rest of the property's attributes to their default values.
if ( object ) {
auto accessor = Accessor : : create ( object - > vm ( ) , nullptr , nullptr ) ;
object - > storage_set ( property_name , { accessor , current - > attributes ( ) } ) ;
}
}
// c. Else,
else {
// If O is not undefined, convert the property named P of object O from an accessor property to a data property.
// Preserve the existing values of the converted property's [[Configurable]] and [[Enumerable]] attributes and
// set the rest of the property's attributes to their default values.
if ( object ) {
auto value = js_undefined ( ) ;
object - > storage_set ( property_name , { value , current - > attributes ( ) } ) ;
}
}
}
// 7. Else if IsDataDescriptor(current) and IsDataDescriptor(Desc) are both true, then
else if ( current - > is_data_descriptor ( ) & & descriptor . is_data_descriptor ( ) ) {
// a. If current.[[Configurable]] is false and current.[[Writable]] is false, then
if ( ! * current - > configurable & & ! * current - > writable ) {
// i. If Desc.[[Writable]] is present and Desc.[[Writable]] is true, return false.
if ( descriptor . writable . has_value ( ) & & * descriptor . writable )
return false ;
// ii. If Desc.[[Value]] is present and SameValue(Desc.[[Value]], current.[[Value]]) is false, return false.
if ( descriptor . value . has_value ( ) & & ! same_value ( * descriptor . value , * current - > value ) )
return false ;
// iii. Return true.
return true ;
}
}
// 8. Else,
else {
// a. Assert: ! IsAccessorDescriptor(current) and ! IsAccessorDescriptor(Desc) are both true.
VERIFY ( current - > is_accessor_descriptor ( ) ) ;
VERIFY ( descriptor . is_accessor_descriptor ( ) ) ;
// b. If current.[[Configurable]] is false, then
if ( ! * current - > configurable ) {
// i. If Desc.[[Set]] is present and SameValue(Desc.[[Set]], current.[[Set]]) is false, return false.
if ( descriptor . set . has_value ( ) & & * descriptor . set ! = * current - > set )
return false ;
// ii. If Desc.[[Get]] is present and SameValue(Desc.[[Get]], current.[[Get]]) is false, return false.
if ( descriptor . get . has_value ( ) & & * descriptor . get ! = * current - > get )
return false ;
// iii. Return true.
return true ;
}
}
// 9. If O is not undefined, then
if ( object ) {
// a. For each field of Desc that is present, set the corresponding attribute of the property named P of object O to the value of the field.
Value value ;
if ( descriptor . is_accessor_descriptor ( ) | | ( current - > is_accessor_descriptor ( ) & & ! descriptor . is_data_descriptor ( ) ) ) {
auto * getter = descriptor . get . value_or ( current - > get . value_or ( nullptr ) ) ;
auto * setter = descriptor . set . value_or ( current - > set . value_or ( nullptr ) ) ;
value = Accessor : : create ( object - > vm ( ) , getter , setter ) ;
} else {
value = descriptor . value . value_or ( current - > value . value_or ( { } ) ) ;
}
PropertyAttributes attributes ;
attributes . set_writable ( descriptor . writable . value_or ( current - > writable . value_or ( false ) ) ) ;
attributes . set_enumerable ( descriptor . enumerable . value_or ( current - > enumerable . value_or ( false ) ) ) ;
attributes . set_configurable ( descriptor . configurable . value_or ( current - > configurable . value_or ( false ) ) ) ;
object - > storage_set ( property_name , { value , attributes } ) ;
}
// 10. Return true.
return true ;
}
2021-08-08 11:04:30 +01:00
// 10.1.14 GetPrototypeFromConstructor ( constructor, intrinsicDefaultProto ), https://tc39.es/ecma262/#sec-getprototypefromconstructor
2021-09-15 21:16:31 +01:00
ThrowCompletionOr < Object * > get_prototype_from_constructor ( GlobalObject & global_object , FunctionObject const & constructor , Object * ( GlobalObject : : * intrinsic_default_prototype ) ( ) )
2021-06-19 22:27:53 +01:00
{
auto & vm = global_object . vm ( ) ;
2021-09-15 21:16:31 +01:00
// 1. Assert: intrinsicDefaultProto is this specification's name of an intrinsic object. The corresponding object must be an intrinsic that is intended to be used as the [[Prototype]] value of an object.
// 2. Let proto be ? Get(constructor, "prototype").
2021-10-02 23:52:27 +01:00
auto prototype = TRY ( constructor . get ( vm . names . prototype ) ) ;
2021-09-15 21:16:31 +01:00
// 3. If Type(proto) is not Object, then
2021-06-19 22:27:53 +01:00
if ( ! prototype . is_object ( ) ) {
2021-09-15 21:16:31 +01:00
// a. Let realm be ? GetFunctionRealm(constructor).
auto * realm = TRY ( get_function_realm ( global_object , constructor ) ) ;
// b. Set proto to realm's intrinsic object named intrinsicDefaultProto.
2021-09-11 22:05:43 +01:00
prototype = ( realm - > global_object ( ) . * intrinsic_default_prototype ) ( ) ;
2021-06-19 22:27:53 +01:00
}
2021-09-15 21:16:31 +01:00
// 4. Return proto.
2021-06-19 22:27:53 +01:00
return & prototype . as_object ( ) ;
}
2021-06-22 00:56:14 +02:00
// 9.1.2.2 NewDeclarativeEnvironment ( E ), https://tc39.es/ecma262/#sec-newdeclarativeenvironment
2021-07-01 12:24:46 +02:00
DeclarativeEnvironment * new_declarative_environment ( Environment & environment )
2021-06-22 00:56:14 +02:00
{
2021-07-01 12:24:46 +02:00
auto & global_object = environment . global_object ( ) ;
return global_object . heap ( ) . allocate < DeclarativeEnvironment > ( global_object , & environment ) ;
2021-06-22 00:56:14 +02:00
}
2021-06-22 01:14:27 +02:00
// 9.1.2.3 NewObjectEnvironment ( O, W, E ), https://tc39.es/ecma262/#sec-newobjectenvironment
2021-07-01 12:24:46 +02:00
ObjectEnvironment * new_object_environment ( Object & object , bool is_with_environment , Environment * environment )
2021-06-22 01:14:27 +02:00
{
auto & global_object = object . global_object ( ) ;
2021-07-01 12:24:46 +02:00
return global_object . heap ( ) . allocate < ObjectEnvironment > ( global_object , object , is_with_environment ? ObjectEnvironment : : IsWithEnvironment : : Yes : ObjectEnvironment : : IsWithEnvironment : : No , environment ) ;
2021-06-22 01:14:27 +02:00
}
2021-10-08 21:24:51 +01:00
// 9.1.2.4 NewFunctionEnvironment ( F, newTarget ), https://tc39.es/ecma262/#sec-newfunctionenvironment
FunctionEnvironment * new_function_environment ( ECMAScriptFunctionObject & function , Object * new_target )
{
auto & global_object = function . global_object ( ) ;
// 1. Let env be a new function Environment Record containing no bindings.
auto * env = global_object . heap ( ) . allocate < FunctionEnvironment > ( global_object , function . environment ( ) ) ;
// 2. Set env.[[FunctionObject]] to F.
env - > set_function_object ( function ) ;
// 3. If F.[[ThisMode]] is lexical, set env.[[ThisBindingStatus]] to lexical.
if ( function . this_mode ( ) = = ECMAScriptFunctionObject : : ThisMode : : Lexical )
env - > set_this_binding_status ( FunctionEnvironment : : ThisBindingStatus : : Lexical ) ;
// 4. Else, set env.[[ThisBindingStatus]] to uninitialized.
else
env - > set_this_binding_status ( FunctionEnvironment : : ThisBindingStatus : : Uninitialized ) ;
// 5. Set env.[[NewTarget]] to newTarget.
env - > set_new_target ( new_target ? : js_undefined ( ) ) ;
// 6. Set env.[[OuterEnv]] to F.[[Environment]].
// NOTE: Done in step 1 via the FunctionEnvironment constructor.
// 7. Return env.
return env ;
}
2021-06-22 13:30:48 +02:00
// 9.4.3 GetThisEnvironment ( ), https://tc39.es/ecma262/#sec-getthisenvironment
2021-07-01 12:24:46 +02:00
Environment & get_this_environment ( VM & vm )
2021-06-22 13:30:48 +02:00
{
2021-06-22 15:42:44 +02:00
for ( auto * env = vm . lexical_environment ( ) ; env ; env = env - > outer_environment ( ) ) {
2021-06-22 13:30:48 +02:00
if ( env - > has_this_binding ( ) )
return * env ;
}
VERIFY_NOT_REACHED ( ) ;
}
// 13.3.7.2 GetSuperConstructor ( ), https://tc39.es/ecma262/#sec-getsuperconstructor
Object * get_super_constructor ( VM & vm )
{
2021-09-28 23:30:17 +01:00
// 1. Let envRec be GetThisEnvironment().
2021-06-22 13:30:48 +02:00
auto & env = get_this_environment ( vm ) ;
2021-09-28 23:30:17 +01:00
// 2. Assert: envRec is a function Environment Record.
// 3. Let activeFunction be envRec.[[FunctionObject]].
// 4. Assert: activeFunction is an ECMAScript function object.
2021-07-01 12:24:46 +02:00
auto & active_function = verify_cast < FunctionEnvironment > ( env ) . function_object ( ) ;
2021-09-28 23:30:17 +01:00
// 5. Let superConstructor be ! activeFunction.[[GetPrototypeOf]]().
2021-10-03 15:57:26 +01:00
auto * super_constructor = MUST ( active_function . internal_get_prototype_of ( ) ) ;
2021-09-28 23:30:17 +01:00
// 6. Return superConstructor.
2021-06-22 13:30:48 +02:00
return super_constructor ;
}
2021-08-08 11:04:30 +01:00
// 13.3.7.3 MakeSuperPropertyReference ( actualThis, propertyKey, strict ), https://tc39.es/ecma262/#sec-makesuperpropertyreference
2021-09-21 21:52:09 +03:00
ThrowCompletionOr < Reference > make_super_property_reference ( GlobalObject & global_object , Value actual_this , StringOrSymbol const & property_key , bool strict )
2021-07-03 00:20:52 +02:00
{
auto & vm = global_object . vm ( ) ;
// 1. Let env be GetThisEnvironment().
auto & env = verify_cast < FunctionEnvironment > ( get_this_environment ( vm ) ) ;
// 2. Assert: env.HasSuperBinding() is true.
VERIFY ( env . has_super_binding ( ) ) ;
// 3. Let baseValue be ? env.GetSuperBase().
2021-10-09 16:41:18 +01:00
auto base_value = TRY ( env . get_super_base ( ) ) ;
2021-07-03 00:20:52 +02:00
// 4. Let bv be ? RequireObjectCoercible(baseValue).
2021-09-21 21:52:09 +03:00
auto bv = TRY ( require_object_coercible ( global_object , base_value ) ) ;
2021-07-03 00:20:52 +02:00
// 5. Return the Reference Record { [[Base]]: bv, [[ReferencedName]]: propertyKey, [[Strict]]: strict, [[ThisValue]]: actualThis }.
// 6. NOTE: This returns a Super Reference Record.
return Reference { bv , property_key , actual_this , strict } ;
}
2021-06-19 20:13:53 -07:00
// 19.2.1.1 PerformEval ( x, callerRealm, strictCaller, direct ), https://tc39.es/ecma262/#sec-performeval
2021-09-21 22:16:08 +03:00
ThrowCompletionOr < Value > perform_eval ( Value x , GlobalObject & caller_realm , CallerMode strict_caller , EvalMode direct )
2021-06-19 20:13:53 -07:00
{
VERIFY ( direct = = EvalMode : : Direct | | strict_caller = = CallerMode : : NonStrict ) ;
if ( ! x . is_string ( ) )
return x ;
auto & vm = caller_realm . vm ( ) ;
2021-09-22 12:44:56 +02:00
auto & eval_realm = vm . running_execution_context ( ) . realm ;
2021-06-19 20:13:53 -07:00
auto & code_string = x . as_string ( ) ;
Parser parser { Lexer { code_string . string ( ) } } ;
auto program = parser . parse_program ( strict_caller = = CallerMode : : Strict ) ;
if ( parser . has_errors ( ) ) {
auto & error = parser . errors ( ) [ 0 ] ;
2021-09-21 22:16:08 +03:00
return vm . throw_completion < SyntaxError > ( caller_realm , error . to_string ( ) ) ;
2021-06-19 20:13:53 -07:00
}
2021-09-22 12:44:56 +02:00
auto strict_eval = strict_caller = = CallerMode : : Strict ;
if ( program - > is_strict_mode ( ) )
strict_eval = true ;
auto & running_context = vm . running_execution_context ( ) ;
Environment * lexical_environment ;
Environment * variable_environment ;
2021-09-21 22:16:08 +03:00
if ( direct = = EvalMode : : Direct ) {
2021-09-22 12:44:56 +02:00
lexical_environment = new_declarative_environment ( * running_context . lexical_environment ) ;
variable_environment = running_context . variable_environment ;
} else {
lexical_environment = new_declarative_environment ( eval_realm - > global_environment ( ) ) ;
variable_environment = & eval_realm - > global_environment ( ) ;
}
if ( strict_eval )
variable_environment = lexical_environment ;
2021-10-07 11:36:44 +02:00
if ( direct = = EvalMode : : Direct & & ! strict_eval ) {
// NOTE: Non-strict direct eval() forces us to deoptimize variable accesses.
// Mark the variable environment chain as screwed since we will not be able
// to rely on cached environment coordinates from this point on.
variable_environment - > set_permanently_screwed_by_eval ( ) ;
}
2021-09-22 12:44:56 +02:00
// 18. If runningContext is not already suspended, suspend runningContext.
// FIXME: We don't have this concept yet.
ExecutionContext eval_context ( vm . heap ( ) ) ;
eval_context . realm = eval_realm ;
eval_context . variable_environment = variable_environment ;
eval_context . lexical_environment = lexical_environment ;
vm . push_execution_context ( eval_context , eval_realm - > global_object ( ) ) ;
ScopeGuard pop_guard = [ & ] {
vm . pop_execution_context ( ) ;
} ;
TRY ( eval_declaration_instantiation ( vm , eval_realm - > global_object ( ) , program , variable_environment , lexical_environment , strict_eval ) ) ;
auto & interpreter = vm . interpreter ( ) ;
TemporaryChange scope_change_strict ( vm . running_execution_context ( ) . is_strict_mode , strict_eval ) ;
// Note: We specifically use evaluate_statements here since we don't want to use global_declaration_instantiation from Program::execute.
auto eval_result = program - > evaluate_statements ( interpreter , caller_realm ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
else
return eval_result . value_or ( js_undefined ( ) ) ;
}
// 19.2.1.3 EvalDeclarationInstantiation ( body, varEnv, lexEnv, privateEnv, strict ), https://tc39.es/ecma262/#sec-evaldeclarationinstantiation
ThrowCompletionOr < void > eval_declaration_instantiation ( VM & vm , GlobalObject & global_object , Program const & program , Environment * variable_environment , Environment * lexical_environment , bool strict )
{
// FIXME: I'm not sure if the global object is correct here. And this is quite a crucial spot!
GlobalEnvironment * global_var_environment = variable_environment - > is_global_environment ( ) ? static_cast < GlobalEnvironment * > ( variable_environment ) : nullptr ;
if ( ! strict ) {
if ( global_var_environment ) {
program . for_each_var_declared_name ( [ & ] ( auto const & name ) {
if ( global_var_environment - > has_lexical_declaration ( name ) ) {
vm . throw_exception < SyntaxError > ( global_object , ErrorType : : FixmeAddAnErrorStringWithMessage , " Var already declared lexically " ) ;
return IterationDecision : : Break ;
}
return IterationDecision : : Continue ;
} ) ;
}
auto * this_environment = lexical_environment ;
while ( this_environment ! = variable_environment ) {
if ( ! is < ObjectEnvironment > ( * this_environment ) ) {
program . for_each_var_declared_name ( [ & ] ( auto const & name ) {
2021-10-09 17:07:32 +01:00
if ( MUST ( this_environment - > has_binding ( name ) ) ) {
2021-09-22 12:44:56 +02:00
vm . throw_exception < SyntaxError > ( global_object , ErrorType : : FixmeAddAnErrorStringWithMessage , " Var already declared lexically " ) ;
return IterationDecision : : Break ;
}
// FIXME: NOTE: Annex B.3.4 defines alternate semantics for the above step.
// In particular it only throw the syntax error if it is not an environment from a catchclause.
return IterationDecision : : Continue ;
} ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
}
this_environment = this_environment - > outer_environment ( ) ;
VERIFY ( this_environment ) ;
}
}
HashTable < FlyString > declared_function_names ;
Vector < FunctionDeclaration const & > functions_to_initialize ;
program . for_each_var_function_declaration_in_reverse_order ( [ & ] ( FunctionDeclaration const & function ) {
if ( declared_function_names . set ( function . name ( ) ) ! = AK : : HashSetResult : : InsertedNewEntry )
return IterationDecision : : Continue ;
if ( global_var_environment ) {
auto function_definable = global_var_environment - > can_declare_global_function ( function . name ( ) ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
if ( ! function_definable ) {
vm . throw_exception < TypeError > ( global_object , ErrorType : : FixmeAddAnErrorStringWithMessage , " Cannot define global function " ) ;
return IterationDecision : : Break ;
}
}
functions_to_initialize . append ( function ) ;
return IterationDecision : : Continue ;
} ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
if ( ! strict ) {
// The spec here uses 'declaredVarNames' but that has not been declared yet.
HashTable < FlyString > hoisted_functions ;
program . for_each_function_hoistable_with_annexB_extension ( [ & ] ( FunctionDeclaration & function_declaration ) {
auto & function_name = function_declaration . name ( ) ;
auto * this_environment = lexical_environment ;
while ( this_environment ! = variable_environment ) {
2021-10-09 17:07:32 +01:00
if ( ! is < ObjectEnvironment > ( * this_environment ) & & MUST ( this_environment - > has_binding ( function_name ) ) )
2021-09-22 12:44:56 +02:00
return IterationDecision : : Continue ;
this_environment = this_environment - > outer_environment ( ) ;
VERIFY ( this_environment ) ;
}
if ( global_var_environment ) {
if ( global_var_environment - > has_lexical_declaration ( function_name ) )
return IterationDecision : : Continue ;
auto var_definable = global_var_environment - > can_declare_global_var ( function_name ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
if ( ! var_definable )
return IterationDecision : : Continue ;
}
if ( ! declared_function_names . contains ( function_name ) & & ! hoisted_functions . contains ( function_name ) ) {
if ( global_var_environment ) {
global_var_environment - > create_global_var_binding ( function_name , true ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
} else {
2021-10-09 17:07:32 +01:00
if ( ! MUST ( variable_environment - > has_binding ( function_name ) ) ) {
2021-10-09 18:53:25 +01:00
MUST ( variable_environment - > create_mutable_binding ( global_object , function_name , true ) ) ;
2021-10-09 19:16:24 +01:00
MUST ( variable_environment - > initialize_binding ( global_object , function_name , js_undefined ( ) ) ) ;
2021-09-22 12:44:56 +02:00
}
}
hoisted_functions . set ( function_name ) ;
}
function_declaration . set_should_do_additional_annexB_steps ( ) ;
return IterationDecision : : Continue ;
} ) ;
2021-09-21 22:16:08 +03:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
}
2021-06-19 20:13:53 -07:00
2021-09-22 12:44:56 +02:00
HashTable < FlyString > declared_var_names ;
program . for_each_var_scoped_variable_declaration ( [ & ] ( VariableDeclaration const & declaration ) {
declaration . for_each_bound_name ( [ & ] ( auto const & name ) {
if ( ! declared_function_names . contains ( name ) ) {
if ( global_var_environment ) {
auto variable_definable = global_var_environment - > can_declare_global_var ( name ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
if ( ! variable_definable ) {
vm . throw_exception < TypeError > ( global_object , ErrorType : : FixmeAddAnErrorStringWithMessage , " Cannot define global var " ) ;
return IterationDecision : : Break ;
}
}
declared_var_names . set ( name ) ;
}
return IterationDecision : : Continue ;
} ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
return IterationDecision : : Continue ;
} ) ;
2021-09-21 22:16:08 +03:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
2021-09-22 12:44:56 +02:00
// 14. NOTE: No abnormal terminations occur after this algorithm step unless varEnv is a global Environment Record and the global object is a Proxy exotic object.
program . for_each_lexically_scoped_declaration ( [ & ] ( Declaration const & declaration ) {
declaration . for_each_bound_name ( [ & ] ( auto const & name ) {
if ( declaration . is_constant_declaration ( ) )
2021-10-09 19:00:06 +01:00
( void ) lexical_environment - > create_immutable_binding ( global_object , name , true ) ;
2021-09-22 12:44:56 +02:00
else
2021-10-09 18:53:25 +01:00
( void ) lexical_environment - > create_mutable_binding ( global_object , name , false ) ;
2021-09-22 12:44:56 +02:00
if ( vm . exception ( ) )
return IterationDecision : : Break ;
return IterationDecision : : Continue ;
} ) ;
if ( vm . exception ( ) )
return IterationDecision : : Break ;
return IterationDecision : : Continue ;
} ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
for ( auto & declaration : functions_to_initialize ) {
LibJS: Add an optimization to avoid needless arguments object creation
This gives FunctionNode a "might need arguments object" boolean flag and
sets it based on the simplest possible heuristic for this: if we
encounter an identifier called "arguments" or "eval" up to the next
(nested) function declaration or expression, we won't need an arguments
object. Otherwise, we *might* need one - the final decision is made in
the FunctionDeclarationInstantiation AO.
Now, this is obviously not perfect. Even if you avoid eval, something
like `foo.arguments` will still trigger a false positive - but it's a
start and already massively cuts down on needlessly allocated objects,
especially in real-world code that is often minified, and so a full
"arguments" identifier will be an actual arguments object more often
than not.
To illustrate the actual impact of this change, here's the number of
allocated arguments objects during a full test-js run:
Before:
- Unmapped arguments objects: 78765
- Mapped arguments objects: 2455
After:
- Unmapped arguments objects: 18
- Mapped arguments objects: 37
This results in a ~5% speedup of test-js on my Linux host machine, and
about 3.5% on i686 Serenity in QEMU (warm runs, average of 5).
The following microbenchmark (calling an empty function 1M times) runs
25% faster on Linux and 45% on Serenity:
function foo() {}
for (var i = 0; i < 1_000_000; ++i)
foo();
test262 reports no changes in either direction, apart from a speedup :^)
2021-10-05 08:44:58 +01:00
auto * function = ECMAScriptFunctionObject : : create ( global_object , declaration . name ( ) , declaration . body ( ) , declaration . parameters ( ) , declaration . function_length ( ) , lexical_environment , declaration . kind ( ) , declaration . is_strict_mode ( ) , declaration . might_need_arguments_object ( ) ) ;
2021-09-22 12:44:56 +02:00
if ( global_var_environment ) {
global_var_environment - > create_global_function_binding ( declaration . name ( ) , function , true ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
} else {
2021-10-09 17:07:32 +01:00
auto binding_exists = MUST ( variable_environment - > has_binding ( declaration . name ( ) ) ) ;
2021-09-22 12:44:56 +02:00
if ( ! binding_exists ) {
2021-10-09 18:53:25 +01:00
TRY ( variable_environment - > create_mutable_binding ( global_object , declaration . name ( ) , true ) ) ;
2021-10-09 19:16:24 +01:00
TRY ( variable_environment - > initialize_binding ( global_object , declaration . name ( ) , function ) ) ;
2021-09-22 12:44:56 +02:00
} else {
variable_environment - > set_mutable_binding ( global_object , declaration . name ( ) , function , false ) ;
2021-10-09 19:16:24 +01:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
2021-09-22 12:44:56 +02:00
}
}
}
for ( auto & var_name : declared_var_names ) {
if ( global_var_environment ) {
global_var_environment - > create_global_var_binding ( var_name , true ) ;
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
} else {
2021-10-09 17:07:32 +01:00
auto binding_exists = MUST ( variable_environment - > has_binding ( var_name ) ) ;
2021-09-22 12:44:56 +02:00
if ( ! binding_exists ) {
2021-10-09 18:53:25 +01:00
TRY ( variable_environment - > create_mutable_binding ( global_object , var_name , true ) ) ;
2021-10-09 19:16:24 +01:00
TRY ( variable_environment - > initialize_binding ( global_object , var_name , js_undefined ( ) ) ) ;
2021-09-22 12:44:56 +02:00
}
}
}
return { } ;
2021-06-19 20:13:53 -07:00
}
2021-06-28 01:44:58 +02:00
// 10.4.4.6 CreateUnmappedArgumentsObject ( argumentsList ), https://tc39.es/ecma262/#sec-createunmappedargumentsobject
2021-09-11 13:53:36 +02:00
Object * create_unmapped_arguments_object ( GlobalObject & global_object , Span < Value > arguments )
2021-06-28 01:44:58 +02:00
{
auto & vm = global_object . vm ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 1. Let len be the number of elements in argumentsList.
auto length = arguments . size ( ) ;
// 2. Let obj be ! OrdinaryObjectCreate(%Object.prototype%, « [[ParameterMap]] »).
// 3. Set obj.[[ParameterMap]] to undefined.
auto * object = Object : : create ( global_object , global_object . object_prototype ( ) ) ;
2021-07-05 18:31:56 +01:00
object - > set_has_parameter_map ( ) ;
2021-06-28 13:26:01 +02:00
2021-06-28 01:44:58 +02:00
// 4. Perform DefinePropertyOrThrow(obj, "length", PropertyDescriptor { [[Value]]: 𝔽 (len), [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }).
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( vm . names . length , { . value = Value ( length ) , . writable = true , . enumerable = false , . configurable = true } ) ) ;
2021-06-28 01:44:58 +02:00
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 5. Let index be 0.
// 6. Repeat, while index < len,
for ( size_t index = 0 ; index < length ; + + index ) {
// a. Let val be argumentsList[index].
auto value = arguments [ index ] ;
2021-06-28 01:44:58 +02:00
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// b. Perform ! CreateDataPropertyOrThrow(obj, ! ToString(𝔽 (index)), val).
2021-10-03 01:18:46 +01:00
MUST ( object - > create_data_property_or_throw ( index , value ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// c. Set index to index + 1.
}
// 7. Perform ! DefinePropertyOrThrow(obj, @@iterator, PropertyDescriptor { [[Value]]: %Array.prototype.values%, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }).
2021-07-25 19:37:42 +01:00
auto * array_prototype_values = global_object . array_prototype_values_function ( ) ;
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( * vm . well_known_symbol_iterator ( ) , { . value = array_prototype_values , . writable = true , . enumerable = false , . configurable = true } ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 8. Perform ! DefinePropertyOrThrow(obj, "callee", PropertyDescriptor { [[Get]]: %ThrowTypeError%, [[Set]]: %ThrowTypeError%, [[Enumerable]]: false, [[Configurable]]: false }).
auto * throw_type_error = global_object . throw_type_error_function ( ) ;
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( vm . names . callee , { . get = throw_type_error , . set = throw_type_error , . enumerable = false , . configurable = false } ) ) ;
2021-06-28 13:26:01 +02:00
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 9. Return obj.
2021-06-28 13:26:01 +02:00
return object ;
}
// 10.4.4.7 CreateMappedArgumentsObject ( func, formals, argumentsList, env ), https://tc39.es/ecma262/#sec-createmappedargumentsobject
2021-09-11 13:53:36 +02:00
Object * create_mapped_arguments_object ( GlobalObject & global_object , FunctionObject & function , Vector < FunctionNode : : Parameter > const & formals , Span < Value > arguments , Environment & environment )
2021-06-28 13:26:01 +02:00
{
auto & vm = global_object . vm ( ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 1. Assert: formals does not contain a rest parameter, any binding patterns, or any initializers. It may contain duplicate identifiers.
// 2. Let len be the number of elements in argumentsList.
2021-06-28 21:19:25 +02:00
VERIFY ( arguments . size ( ) < = NumericLimits < i32 > : : max ( ) ) ;
i32 length = static_cast < i32 > ( arguments . size ( ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 3. Let obj be ! MakeBasicObject(« [[Prototype]], [[Extensible]], [[ParameterMap]] »).
// 4. Set obj.[[GetOwnProperty]] as specified in 10.4.4.1.
// 5. Set obj.[[DefineOwnProperty]] as specified in 10.4.4.2.
// 6. Set obj.[[Get]] as specified in 10.4.4.3.
// 7. Set obj.[[Set]] as specified in 10.4.4.4.
// 8. Set obj.[[Delete]] as specified in 10.4.4.5.
// 9. Set obj.[[Prototype]] to %Object.prototype%.
2021-06-28 21:19:25 +02:00
auto * object = vm . heap ( ) . allocate < ArgumentsObject > ( global_object , global_object , environment ) ;
2021-09-21 22:02:40 +03:00
VERIFY ( ! vm . exception ( ) ) ;
2021-06-28 13:26:01 +02:00
// 14. Let index be 0.
// 15. Repeat, while index < len,
2021-06-28 21:19:25 +02:00
for ( i32 index = 0 ; index < length ; + + index ) {
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// a. Let val be argumentsList[index].
auto value = arguments [ index ] ;
// b. Perform ! CreateDataPropertyOrThrow(obj, ! ToString(𝔽 (index)), val).
2021-10-03 01:18:46 +01:00
MUST ( object - > create_data_property_or_throw ( index , value ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// c. Set index to index + 1.
}
2021-06-28 01:44:58 +02:00
2021-06-28 13:26:01 +02:00
// 16. Perform ! DefinePropertyOrThrow(obj, "length", PropertyDescriptor { [[Value]]: 𝔽 (len), [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }).
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( vm . names . length , { . value = Value ( length ) , . writable = true , . enumerable = false , . configurable = true } ) ) ;
2021-06-28 13:26:01 +02:00
2021-06-28 21:19:25 +02:00
// 17. Let mappedNames be a new empty List.
HashTable < FlyString > mapped_names ;
// 18. Set index to numberOfParameters - 1.
// 19. Repeat, while index ≥ 0,
VERIFY ( formals . size ( ) < = NumericLimits < i32 > : : max ( ) ) ;
for ( i32 index = static_cast < i32 > ( formals . size ( ) ) - 1 ; index > = 0 ; - - index ) {
// a. Let name be parameterNames[index].
auto const & name = formals [ index ] . binding . get < FlyString > ( ) ;
// b. If name is not an element of mappedNames, then
if ( mapped_names . contains ( name ) )
continue ;
// i. Add name as an element of the list mappedNames.
mapped_names . set ( name ) ;
// ii. If index < len, then
if ( index < length ) {
// 1. Let g be MakeArgGetter(name, env).
// 2. Let p be MakeArgSetter(name, env).
// 3. Perform map.[[DefineOwnProperty]](! ToString(𝔽 (index)), PropertyDescriptor { [[Set]]: p, [[Get]]: g, [[Enumerable]]: false, [[Configurable]]: true }).
object - > parameter_map ( ) . define_native_accessor (
2021-10-04 22:53:44 +02:00
PropertyName { index } ,
2021-09-22 12:44:56 +02:00
[ & environment , name ] ( VM & , GlobalObject & global_object_getter ) - > Value {
return environment . get_binding_value ( global_object_getter , name , false ) ;
2021-06-28 21:19:25 +02:00
} ,
2021-09-22 12:44:56 +02:00
[ & environment , name ] ( VM & vm , GlobalObject & global_object_setter ) {
environment . set_mutable_binding ( global_object_setter , name , vm . argument ( 0 ) , false ) ;
2021-06-28 21:19:25 +02:00
return js_undefined ( ) ;
} ,
Attribute : : Configurable ) ;
}
}
2021-06-28 13:26:01 +02:00
// 20. Perform ! DefinePropertyOrThrow(obj, @@iterator, PropertyDescriptor { [[Value]]: %Array.prototype.values%, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }).
2021-07-25 19:37:42 +01:00
auto * array_prototype_values = global_object . array_prototype_values_function ( ) ;
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( * vm . well_known_symbol_iterator ( ) , { . value = array_prototype_values , . writable = true , . enumerable = false , . configurable = true } ) ) ;
2021-06-28 13:26:01 +02:00
// 21. Perform ! DefinePropertyOrThrow(obj, "callee", PropertyDescriptor { [[Value]]: func, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }).
2021-10-03 01:35:36 +01:00
MUST ( object - > define_property_or_throw ( vm . names . callee , { . value = & function , . writable = true , . enumerable = false , . configurable = true } ) ) ;
2021-06-28 01:44:58 +02:00
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 22. Return obj.
2021-06-28 01:44:58 +02:00
return object ;
}
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 7.1.21 CanonicalNumericIndexString ( argument ), https://tc39.es/ecma262/#sec-canonicalnumericindexstring
2021-07-05 01:55:45 +02:00
Value canonical_numeric_index_string ( GlobalObject & global_object , PropertyName const & property_name )
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
{
2021-07-05 01:55:45 +02:00
// NOTE: If the property name is a number type (An implementation-defined optimized
// property key type), it can be treated as a string property that has already been
// converted successfully into a canonical numeric index.
VERIFY ( property_name . is_string ( ) | | property_name . is_number ( ) ) ;
if ( property_name . is_number ( ) )
return Value ( property_name . as_number ( ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 1. Assert: Type(argument) is String.
2021-07-05 01:55:45 +02:00
auto argument = Value ( js_string ( global_object . vm ( ) , property_name . as_string ( ) ) ) ;
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 18:14:16 +01:00
// 2. If argument is "-0", return -0𝔽 .
if ( argument . as_string ( ) . string ( ) = = " -0 " )
return Value ( - 0.0 ) ;
// 3. Let n be ! ToNumber(argument).
auto n = argument . to_number ( global_object ) ;
// 4. If SameValue(! ToString(n), argument) is false, return undefined.
if ( ! same_value ( n . to_primitive_string ( global_object ) , argument ) )
return js_undefined ( ) ;
// 5. Return n.
return n ;
}
2021-07-05 16:16:48 -04:00
// 22.1.3.17.1 GetSubstitution ( matched, str, position, captures, namedCaptures, replacement ), https://tc39.es/ecma262/#sec-getsubstitution
2021-09-21 22:05:21 +03:00
ThrowCompletionOr < String > get_substitution ( GlobalObject & global_object , Utf16View const & matched , Utf16View const & str , size_t position , Span < Value > captures , Value named_captures , Value replacement )
2021-07-05 16:16:48 -04:00
{
auto & vm = global_object . vm ( ) ;
2021-07-22 10:38:10 -04:00
auto replace_string = replacement . to_utf16_string ( global_object ) ;
2021-09-21 22:05:21 +03:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
2021-08-09 09:06:45 -04:00
auto replace_view = replace_string . view ( ) ;
2021-07-19 16:53:35 -04:00
2021-07-05 16:16:48 -04:00
StringBuilder result ;
2021-07-22 10:38:10 -04:00
for ( size_t i = 0 ; i < replace_view . length_in_code_units ( ) ; + + i ) {
u16 curr = replace_view . code_unit_at ( i ) ;
2021-07-05 16:16:48 -04:00
2021-07-22 10:38:10 -04:00
if ( ( curr ! = ' $ ' ) | | ( i + 1 > = replace_view . length_in_code_units ( ) ) ) {
2021-07-05 16:16:48 -04:00
result . append ( curr ) ;
continue ;
}
2021-07-22 10:38:10 -04:00
u16 next = replace_view . code_unit_at ( i + 1 ) ;
2021-07-05 16:16:48 -04:00
if ( next = = ' $ ' ) {
2021-07-19 16:53:35 -04:00
result . append ( ' $ ' ) ;
2021-07-05 16:16:48 -04:00
+ + i ;
} else if ( next = = ' & ' ) {
2021-08-09 12:38:38 -04:00
result . append ( matched ) ;
2021-07-05 16:16:48 -04:00
+ + i ;
} else if ( next = = ' ` ' ) {
2021-07-22 10:38:10 -04:00
auto substring = str . substring_view ( 0 , position ) ;
2021-08-09 12:38:38 -04:00
result . append ( substring ) ;
2021-07-05 16:16:48 -04:00
+ + i ;
} else if ( next = = ' \' ' ) {
2021-07-22 10:38:10 -04:00
auto tail_pos = position + matched . length_in_code_units ( ) ;
if ( tail_pos < str . length_in_code_units ( ) ) {
auto substring = str . substring_view ( tail_pos ) ;
2021-08-09 12:38:38 -04:00
result . append ( substring ) ;
2021-07-19 16:53:35 -04:00
}
2021-07-05 16:16:48 -04:00
+ + i ;
} else if ( is_ascii_digit ( next ) ) {
2021-07-22 10:38:10 -04:00
bool is_two_digits = ( i + 2 < replace_view . length_in_code_units ( ) ) & & is_ascii_digit ( replace_view . code_unit_at ( i + 2 ) ) ;
2021-07-05 16:16:48 -04:00
2021-07-22 10:38:10 -04:00
auto capture_postition_string = replace_view . substring_view ( i + 1 , is_two_digits ? 2 : 1 ) . to_utf8 ( ) ;
2021-07-05 16:16:48 -04:00
auto capture_position = capture_postition_string . to_uint ( ) ;
if ( capture_position . has_value ( ) & & ( * capture_position > 0 ) & & ( * capture_position < = captures . size ( ) ) ) {
auto & value = captures [ * capture_position - 1 ] ;
if ( ! value . is_undefined ( ) ) {
auto value_string = value . to_string ( global_object ) ;
2021-09-21 22:05:21 +03:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
2021-07-05 16:16:48 -04:00
result . append ( value_string ) ;
}
i + = is_two_digits ? 2 : 1 ;
} else {
result . append ( curr ) ;
}
} else if ( next = = ' < ' ) {
auto start_position = i + 2 ;
2021-07-19 16:53:35 -04:00
Optional < size_t > end_position ;
2021-07-22 10:38:10 -04:00
for ( size_t j = start_position ; j < replace_view . length_in_code_units ( ) ; + + j ) {
if ( replace_view . code_unit_at ( j ) = = ' > ' ) {
2021-07-19 16:53:35 -04:00
end_position = j ;
break ;
}
}
2021-07-05 16:16:48 -04:00
if ( named_captures . is_undefined ( ) | | ! end_position . has_value ( ) ) {
result . append ( curr ) ;
} else {
2021-07-22 10:38:10 -04:00
auto group_name_view = replace_view . substring_view ( start_position , * end_position - start_position ) ;
2021-07-19 16:53:35 -04:00
auto group_name = group_name_view . to_utf8 ( Utf16View : : AllowInvalidCodeUnits : : Yes ) ;
2021-07-05 16:16:48 -04:00
2021-10-02 23:52:27 +01:00
auto capture = TRY ( named_captures . as_object ( ) . get ( group_name ) ) ;
2021-07-05 16:16:48 -04:00
if ( ! capture . is_undefined ( ) ) {
auto capture_string = capture . to_string ( global_object ) ;
2021-09-21 22:05:21 +03:00
if ( auto * exception = vm . exception ( ) )
return throw_completion ( exception - > value ( ) ) ;
2021-07-05 16:16:48 -04:00
result . append ( capture_string ) ;
}
i = * end_position ;
}
} else {
result . append ( curr ) ;
}
}
return result . build ( ) ;
}
2021-06-19 21:45:00 +01:00
}