Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Tests/LibHTTP/TestHTTPUtils.cpp

64 lines
1.5 KiB
C++
Raw Normal View History

LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
/*
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
* Copyright (c) 2024-2025, Tim Flynn <trflynn89@ladybird.org>
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibTest/TestCase.h>
#include <AK/GenericLexer.h>
#include <AK/String.h>
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
#include <LibHTTP/HTTP.h>
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
TEST_CASE(collect_an_http_quoted_string)
{
{
auto test = "\"\""_string;
GenericLexer lexer { test };
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"\""_string);
}
{
auto test = "\"abc\""_string;
GenericLexer lexer { test };
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"abc\""_string);
}
{
auto test = "foo \"abc\""_string;
GenericLexer lexer { test };
lexer.ignore(4);
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"abc\""_string);
}
{
auto test = "foo=\"abc\""_string;
GenericLexer lexer { test };
lexer.ignore(4);
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"abc\""_string);
}
{
auto test = "foo=\"abc\" bar"_string;
GenericLexer lexer { test };
lexer.ignore(4);
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"abc\""_string);
}
{
auto test = "\"abc\" bar"_string;
GenericLexer lexer { test };
LibHTTP+LibWeb+RequestServer: Move Fetch's HTTP header infra to LibHTTP The end goal here is for LibHTTP to be the home of our RFC 9111 (HTTP caching) implementation. We currently have one implementation in LibWeb for our in-memory cache and another in RequestServer for our disk cache. The implementations both largely revolve around interacting with HTTP headers. But in LibWeb, we are using Fetch's header infra, and in RS we are using are home-grown header infra from LibHTTP. So to give these a common denominator, this patch replaces the LibHTTP implementation with Fetch's infra. Our existing LibHTTP implementation was not particularly compliant with any spec, so this at least gives us a standards-based common implementation. This migration also required moving a handful of other Fetch AOs over to LibHTTP. (It turns out these AOs were all from the Fetch/Infra/HTTP folder, so perhaps it makes sense for LibHTTP to be the implementation of that entire set of facilities.)
2025-11-26 14:13:23 -05:00
auto result = HTTP::collect_an_http_quoted_string(lexer);
LibWeb: Return the correct substring when parsing an HTTP quoted string We were off-by-one when returning the result of parsing a quoted string in Web::Fetch::Infrastructure::collect_an_http_quoted_string. Instead of backtracking the lexer and consuming the backtracked string, do a simple substring operation.
2024-03-26 12:13:11 -04:00
EXPECT_EQ(result, "\"abc\""_string);
}
}
Reference in a new issue Copy permalink