Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-04 07:10:57 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Libraries/LibWeb/Layout/FlexFormattingContext.h

201 lines
8.1 KiB
C
Raw Normal View History

LibWeb: Add a very naive Layout::FlexFormattingContext :^) This is very dumb and only lays out its child boxes on a horizontal line with their shrink-to-fit widths. You have to start somewhere! :^)
2021-01-18 17:33:46 +01:00
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Add a very naive Layout::FlexFormattingContext :^) This is very dumb and only lays out its child boxes on a horizontal line with their shrink-to-fit widths. You have to start somewhere! :^)
2021-01-18 17:33:46 +01:00
*/
#pragma once
LibWeb: Add missing headers
2021-10-10 15:56:29 +02:00
#include <LibWeb/Layout/Box.h>
LibWeb: Add a very naive Layout::FlexFormattingContext :^) This is very dumb and only lays out its child boxes on a horizontal line with their shrink-to-fit widths. You have to start somewhere! :^)
2021-01-18 17:33:46 +01:00
#include <LibWeb/Layout/FormattingContext.h>
namespace Web::Layout {
class FlexFormattingContext final : public FormattingContext {
public:
LibWeb: Rename FormattingState to LayoutState This seems a bit more descriptive (and also a bit shorter).
2022-07-16 23:30:32 +02:00
FlexFormattingContext(LayoutState&, Box const& flex_container, FormattingContext* parent);
LibWeb: Add a very naive Layout::FlexFormattingContext :^) This is very dumb and only lays out its child boxes on a horizontal line with their shrink-to-fit widths. You have to start somewhere! :^)
2021-01-18 17:33:46 +01:00
~FlexFormattingContext();
LibWeb: Implement "out-of-flow" property of Layout Box In some situations, a layout box should not participate in the standard layout process, for example when set to `position: absolute`.
2021-09-15 12:19:42 +01:00
virtual bool inhibits_floating() const override { return true; }
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
virtual void run(Box const&, LayoutMode, AvailableSpace const&) override;
LibWeb: Add FormattingContext::automatic_content_height() This function should return the automatic height of the formatting context's root box. Until now, we've been relying on some magical handshakes between parent and child context, when negotiating the height of child context root boxes. This is a step towards something more reasonable.
2022-09-24 13:39:43 +02:00
virtual float automatic_content_height() const override;
LibWeb: Split out FFC's "generate anonymous flex items" to a function Let's begin splitting the FlexFormattingContext layout algorithm into separate functions to make it more manageable.
2021-10-13 19:57:26 +02:00
LibWeb: Add FFC::flex_container() and use throughout Since FFC is only ever run() on the flex container, we can assume (but verify) that the run box is the flex container and use an accessor throughout. The end result: less parameter passing.
2021-10-13 22:52:50 +02:00
Box const& flex_container() const { return context_box(); }
LibWeb: Let FFC parent context "handle" sizing of child FFC container When we have nested flexbox layouts within one another, and the child context wants to call up to the parent context and ask for help with dimensioning the child flex container, we now simply do nothing. As far as I can tell, this works out just fine, since the child flex container will already be dimensioned by the flex layout algorithm.
2022-10-04 18:57:09 +02:00
virtual bool can_determine_size_of_child() const override;
virtual void determine_width_of_child(Box const&, AvailableSpace const&) override;
virtual void determine_height_of_child(Box const&, AvailableSpace const&) override;
LibWeb: Split out FFC's "generate anonymous flex items" to a function Let's begin splitting the FlexFormattingContext layout algorithm into separate functions to make it more manageable.
2021-10-13 19:57:26 +02:00
private:
LibWeb: Add a debug helper to dump current state of an FFC
2022-03-13 00:03:59 +01:00
void dump_items() const;
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
struct DirectionAgnosticMargins {
float main_before { 0 };
float main_after { 0 };
float cross_before { 0 };
float cross_after { 0 };
LibWeb: Don't include flex line margins in inner flex item cross sizes In cases where flex item cross size is based on the flex line cross size, the spec specifically says to transfer the *outer* cross size of the line. We were ignoring the "outer" part. This patch fixes that by subtracting the cross margins from the size.
2022-07-07 11:44:35 +02:00
bool main_before_is_auto { false };
bool main_after_is_auto { false };
bool cross_before_is_auto { false };
bool cross_after_is_auto { false };
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
};
struct FlexItem {
Box& box;
LibWeb: Remember the used flex basis for each flex item This will be consulted later on in the flex layout algorithm.
2022-07-17 19:40:02 +02:00
CSS::FlexBasisData used_flex_basis {};
LibWeb: Actually check if percentage used flex basis is definite Previously, we considered all LengthPercentage values for used flex basis to be definite. This is not accurate, as percentages should only be considered definite if the reference value they resolve against is a definite size. Fix this by checking the flex container's main definite size flag.
2022-07-19 13:34:21 +02:00
bool used_flex_basis_is_definite { false };
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
float flex_base_size { 0 };
float hypothetical_main_size { 0 };
float hypothetical_cross_size { 0 };
LibWeb: Take borders and padding into account when doing Flex layout Before this the flex layout didn't take into account the applied borders or padding while laying out the items. The child's top and left borders would get painted over the parent's borders, also due to it not taking borders into account, children with borders would overlap each other. Due to it not taking padding into account, the children would get drawn outside the parent element.
2022-03-27 16:14:18 +02:00
float hypothetical_cross_size_with_margins() { return hypothetical_cross_size + margins.cross_before + margins.cross_after + borders.cross_after + borders.cross_before + padding.cross_after + padding.cross_before; }
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
float target_main_size { 0 };
bool frozen { false };
Optional<float> flex_factor {};
float scaled_flex_shrink_factor { 0 };
LibWeb: Update flex container intrinsic size algorithm to draft spec The CSSWG draft Flexbox spec is a bit clearer on some details, so let's update our implementation to match the latest version.
2022-07-13 13:26:02 +02:00
float desired_flex_fraction { 0 };
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
float main_size { 0 };
float cross_size { 0 };
float main_offset { 0 };
float cross_offset { 0 };
DirectionAgnosticMargins margins {};
LibWeb: Take borders and padding into account when doing Flex layout Before this the flex layout didn't take into account the applied borders or padding while laying out the items. The child's top and left borders would get painted over the parent's borders, also due to it not taking borders into account, children with borders would overlap each other. Due to it not taking padding into account, the children would get drawn outside the parent element.
2022-03-27 16:14:18 +02:00
DirectionAgnosticMargins borders {};
DirectionAgnosticMargins padding {};
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
bool is_min_violation { false };
bool is_max_violation { false };
LibWeb: Add helpers for adding margin box to flex item's content size
2022-07-25 15:02:23 +02:00
float add_main_margin_box_sizes(float content_size) const
{
return content_size + margins.main_before + margins.main_after + borders.main_before + borders.main_after + padding.main_before + padding.main_after;
}
float add_cross_margin_box_sizes(float content_size) const
{
return content_size + margins.cross_before + margins.cross_after + borders.cross_before + borders.cross_after + padding.cross_before + padding.cross_after;
}
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
};
struct FlexLine {
Vector<FlexItem*> items;
float cross_size { 0 };
LibWeb: Keep the "remaining free space" across flexbox algo steps Instead of recomputing the "remaining free space" per flex line, remember it after calculating it during the "resolve flexible lengths" step so we can reuse it later.
2022-07-06 19:15:31 +02:00
float remaining_free_space { 0 };
LibWeb: Make two passes in FFC where to support percentage min/max sizes Percentage sizes of flex items are relative to the flex container, but even when the flex container is automatically sized, we still have to support them. To make this work, we first do a pass where percentage sizes are ignored (treated as "auto", basically) in order to get a "reference" value. Then we do a second pass where percentages can be resolved against this reference value.
2022-07-22 22:02:02 +02:00
float chosen_flex_fraction { 0 };
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
};
LibWeb: Turn FlexFormattingContext helper lambdas into member functions Continuing on the quest towards making FlexFormattingContext readable.
2021-10-13 21:24:00 +02:00
bool has_definite_main_size(Box const&) const;
bool has_definite_cross_size(Box const&) const;
float specified_main_size(Box const&) const;
float specified_cross_size(Box const&) const;
LibWeb: Don't re-resolve "auto" flex item sizes after definitizing them This is rather subtle and points to our architecture around definite sizes not being exactly right, but... At some points during flexbox layout, the spec tells us that the sizes of certain flex items are considered definite from this point on. We implement this by marking each item's associated UsedValues as "has-definite-width/height". However, this breaks code that tries to resolve computed "auto" sizes by taking the corresponding size from the containing block. The end result was that the 1st sizing pass in flexbox would find the right size for an "auto" sized item, but the 2nd pass would override the correct size with the containing block's content size in that axis instead. To work around the issue, FFC now remembers when it "definitizes" an item, and future attempts to resolve an "auto" computed size for that value will bypass the computed-auto-is-resolved-against-containing-block step of the algorithm. It's not perfect, and we'll need to think more about how to really represent these intermediate states relating to box sizes being definite..
2022-09-14 11:43:57 +02:00
float resolved_definite_main_size(FlexItem const&) const;
float resolved_definite_cross_size(FlexItem const&) const;
LibWeb: Turn FlexFormattingContext helper lambdas into member functions Continuing on the quest towards making FlexFormattingContext readable.
2021-10-13 21:24:00 +02:00
bool has_main_min_size(Box const&) const;
bool has_cross_min_size(Box const&) const;
float specified_main_max_size(Box const&) const;
float specified_cross_max_size(Box const&) const;
bool is_cross_auto(Box const&) const;
float specified_main_min_size(Box const&) const;
float specified_cross_min_size(Box const&) const;
bool has_main_max_size(Box const&) const;
bool has_cross_max_size(Box const&) const;
LibWeb: Implement (some of) "automatic minimum size" for flex items
2022-06-21 21:06:19 +02:00
float automatic_minimum_size(FlexItem const&) const;
float content_based_minimum_size(FlexItem const&) const;
Optional<float> specified_size_suggestion(FlexItem const&) const;
LibWeb: Implement "transferred size suggestion" for flex items
2022-06-22 18:05:28 +02:00
Optional<float> transferred_size_suggestion(FlexItem const&) const;
LibWeb: Implement (some of) "automatic minimum size" for flex items
2022-06-21 21:06:19 +02:00
float content_size_suggestion(FlexItem const&) const;
LibWeb: Use CSS::Size for computed size and max-size values This patch changes the *computed* representation of the following CSS properties to use CSS::Size: - width, min-width, max-width - height, min-height, max-height A few things had to change in order for things to keep working, but I tried to keep the diff to a minimum. The main trouble was that `min-width` and `max-width` can't actually be `auto`, but they *can* be `none`. We previously treated `auto` as a valid value (and it behaved mostly like `none`).
2022-09-25 15:48:23 +02:00
CSS::Size const& computed_main_size(Box const&) const;
CSS::Size const& computed_main_min_size(Box const&) const;
CSS::Size const& computed_main_max_size(Box const&) const;
CSS::Size const& computed_cross_size(Box const&) const;
CSS::Size const& computed_cross_min_size(Box const&) const;
CSS::Size const& computed_cross_max_size(Box const&) const;
float get_pixel_width(Box const& box, Optional<CSS::Size> const& length_percentage) const;
float get_pixel_height(Box const& box, Optional<CSS::Size> const& length_percentage) const;
LibWeb: Move get_pixel_{width,height} helpers into FFC class
2022-07-21 00:26:46 +02:00
LibWeb: Mark flex item cross sizes as definite when spec asks us to The CSS-FLEXBOX-1 spec gives us two situations in which flex item cross sizes should be considered definite. Both of them happen *during* flex layout, which is super finicky but it is what it is.
2022-07-20 19:06:47 +02:00
bool flex_item_is_stretched(FlexItem const&) const;
LibWeb: Start making our layout system "transactional" This patch adds a map of Layout::Node to FormattingState::NodeState. Instead of updating layout nodes incrementally as layout progresses through the formatting contexts, all updates are now written to the corresponding NodeState instead. At the end of layout, FormattingState::commit() is called, which transfers all the values from the NodeState objects to the Node. This will soon allow us to perform completely non-destructive layouts which don't affect the tree. Note that there are many imperfections here, and still many places where we assign to the NodeState, but later read directly from the Node instead. I'm just committing at this stage to make subsequent diffs easier to understand.
2022-02-20 15:51:24 +01:00
void set_main_size(Box const&, float size);
void set_cross_size(Box const&, float size);
void set_offset(Box const&, float main_offset, float cross_offset);
LibWeb: Actually distribute free space to flex items with auto margins We were not applying the distributed space to the used offset of flex items, as we were only assigning the margins to the layout state of the box, not the internal FlexItem::margins.
2022-06-21 21:18:00 +02:00
void set_main_axis_first_margin(FlexItem&, float margin);
void set_main_axis_second_margin(FlexItem&, float margin);
LibWeb: Turn FlexFormattingContext helper lambdas into member functions Continuing on the quest towards making FlexFormattingContext readable.
2021-10-13 21:24:00 +02:00
LibWeb: Fix flex line alignment in single-line flex containers For single-line flex containers, center the only flex line along the cross axis. Alignment of multi-line flex containers are left as a FIXME. This patch also moves out the assignment of final metrics to the FormattingState from align_all_flex_lines() to a separate function.
2022-02-27 23:58:54 +01:00
void copy_dimensions_from_flex_items_to_boxes();
LibWeb: Move unrelated things out of FFC step 1 Setting some initial width and height on the flex container is totally unrelated to the "generate anonymous flex items" step.
2022-02-27 09:50:09 +01:00
LibWeb: Add FFC::flex_container() and use throughout Since FFC is only ever run() on the flex container, we can assume (but verify) that the run box is the flex container and use an accessor throughout. The end result: less parameter passing.
2021-10-13 22:52:50 +02:00
void generate_anonymous_flex_items();
LibWeb: Split out FFC's "generate anonymous flex items" to a function Let's begin splitting the FlexFormattingContext layout algorithm into separate functions to make it more manageable.
2021-10-13 19:57:26 +02:00
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
void determine_available_space_for_items(AvailableSpace const&);
LibWeb: Move FFC layout algorithm step 2 into a separate function Determining the available main and cross space is now done by a separate function. The signature is a little bit hairy since this function computes some things that are used by subsequent algorithm steps. Factoring can definitely be improved further.
2021-10-13 21:41:35 +02:00
LibWeb: Handle many more cases with intrinsic/auto sizing in flex layout The flexbox specification barely even handwaves about automatically sized items, but there's actually a lot of work to do in order for them to get the correct size. This patch is messy, but does make significant progress on supporting flex items with indefinite width and/or height. There's a fair amount of nested layout going on here, but do note that we'll be hitting the intrinsic sizes cache whenever possible.
2022-03-12 14:40:13 +01:00
float calculate_indefinite_main_size(FlexItem const&);
LibWeb: Add FFC::flex_container() and use throughout Since FFC is only ever run() on the flex container, we can assume (but verify) that the run box is the flex container and use an accessor throughout. The end result: less parameter passing.
2021-10-13 22:52:50 +02:00
void determine_flex_base_size_and_hypothetical_main_size(FlexItem&);
LibWeb: Move FFC layout algorithm step 3 to a separate function
2021-10-13 21:49:28 +02:00
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
void determine_main_size_of_flex_container();
LibWeb: Move FFC layout algorithm step 4 to a separate function
2021-10-13 22:03:39 +02:00
LibWeb: Handle many more cases with intrinsic/auto sizing in flex layout The flexbox specification barely even handwaves about automatically sized items, but there's actually a lot of work to do in order for them to get the correct size. This patch is messy, but does make significant progress on supporting flex items with indefinite width and/or height. There's a fair amount of nested layout going on here, but do note that we'll be hitting the intrinsic sizes cache whenever possible.
2022-03-12 14:40:13 +01:00
void collect_flex_items_into_flex_lines();
LibWeb: Move FFC layout algorithm step 5 to a separate function
2021-10-13 22:07:55 +02:00
LibWeb: Handle many more cases with intrinsic/auto sizing in flex layout The flexbox specification barely even handwaves about automatically sized items, but there's actually a lot of work to do in order for them to get the correct size. This patch is messy, but does make significant progress on supporting flex items with indefinite width and/or height. There's a fair amount of nested layout going on here, but do note that we'll be hitting the intrinsic sizes cache whenever possible.
2022-03-12 14:40:13 +01:00
void resolve_flexible_lengths();
LibWeb: Move FFC layout algorithm step 6 to a separate function
2021-10-13 22:11:50 +02:00
LibWeb: Resolve cross-axis flex item margins in the common case
2022-09-28 17:23:22 +02:00
void resolve_cross_axis_auto_margins();
LibWeb: Make two passes in FFC where to support percentage min/max sizes Percentage sizes of flex items are relative to the flex container, but even when the flex container is automatically sized, we still have to support them. To make this work, we first do a pass where percentage sizes are ignored (treated as "auto", basically) in order to get a "reference" value. Then we do a second pass where percentages can be resolved against this reference value.
2022-07-22 22:02:02 +02:00
void determine_hypothetical_cross_size_of_item(FlexItem&, bool resolve_percentage_min_max_sizes);
LibWeb: Move FFC layout algorithm step 7 to a separate function
2021-10-13 22:15:16 +02:00
LibWeb: Treat cross min/max sizes better in flexbox layout For percentage cross min/max sizes that resolve against indefinite available space, we now essentially ignore them instead of resolving them to 0 at the start of layout.
2022-10-07 13:58:18 +02:00
void calculate_cross_size_of_each_flex_line();
LibWeb: Move FFC layout algorithm step 8 to a separate function
2021-10-13 22:17:33 +02:00
LibWeb: Implement basic support for align-content in flex layout This property tells us how to lay out multi-line flex containers. I implemented all modes except `space-between` and `space-around`. Those are left as FIXMEs.
2022-10-14 13:50:40 +02:00
void handle_align_content_stretch();
LibWeb: Honor `align-self` over `align-items` when non-auto on flex item
2022-07-11 23:52:36 +02:00
CSS::AlignItems alignment_for_item(FlexItem const&) const;
LibWeb: Add FFC::flex_container() and use throughout Since FFC is only ever run() on the flex container, we can assume (but verify) that the run box is the flex container and use an accessor throughout. The end result: less parameter passing.
2021-10-13 22:52:50 +02:00
void determine_used_cross_size_of_each_flex_item();
LibWeb: Move FFC layout algorithm step 11 to a separate function
2021-10-13 22:19:17 +02:00
LibWeb: Handle many more cases with intrinsic/auto sizing in flex layout The flexbox specification barely even handwaves about automatically sized items, but there's actually a lot of work to do in order for them to get the correct size. This patch is messy, but does make significant progress on supporting flex items with indefinite width and/or height. There's a fair amount of nested layout going on here, but do note that we'll be hitting the intrinsic sizes cache whenever possible.
2022-03-12 14:40:13 +01:00
void distribute_any_remaining_free_space();
LibWeb: Move FFC layout algorithm step 12 to a separate function
2021-10-13 22:20:55 +02:00
LibWeb: Add FFC::flex_container() and use throughout Since FFC is only ever run() on the flex container, we can assume (but verify) that the run box is the flex container and use an accessor throughout. The end result: less parameter passing.
2021-10-13 22:52:50 +02:00
void align_all_flex_items_along_the_cross_axis();
LibWeb: Move FFC layout algorithm step 14 to a separate function
2021-10-13 22:22:30 +02:00
LibWeb: Treat cross min/max sizes better in flexbox layout For percentage cross min/max sizes that resolve against indefinite available space, we now essentially ignore them instead of resolving them to 0 at the start of layout.
2022-10-07 13:58:18 +02:00
void determine_flex_container_used_cross_size();
LibWeb: Move FFC layout algorithm step 15 to a separate function
2021-10-13 22:24:09 +02:00
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
void align_all_flex_lines();
LibWeb: Move FFC layout algorithm step 16 to a separate function
2021-10-13 22:25:39 +02:00
LibWeb: Split out FFC's "generate anonymous flex items" to a function Let's begin splitting the FlexFormattingContext layout algorithm into separate functions to make it more manageable.
2021-10-13 19:57:26 +02:00
bool is_row_layout() const { return m_flex_direction == CSS::FlexDirection::Row || m_flex_direction == CSS::FlexDirection::RowReverse; }
LibWeb: Add spec comments to FFC layout algorithm step 5
2021-10-13 23:38:04 +02:00
bool is_single_line() const { return flex_container().computed_values().flex_wrap() == CSS::FlexWrap::Nowrap; }
LibWeb: Implement flex reverse layouts This builds on the work done by implementing the flex order CSS property and implements flex reverse layouts by just reversing the order and the items within each order bucket.
2022-04-02 11:29:55 +02:00
bool is_direction_reverse() const { return m_flex_direction == CSS::FlexDirection::ColumnReverse || m_flex_direction == CSS::FlexDirection::RowReverse; }
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
void populate_specified_margins(FlexItem&, CSS::FlexDirection) const;
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
void determine_intrinsic_size_of_flex_container();
[[nodiscard]] float calculate_intrinsic_main_size_of_flex_container();
[[nodiscard]] float calculate_intrinsic_cross_size_of_flex_container();
LibWeb: Implement basic intrinsic sizing algorithms for flex containers This patch adds support for MinContent and MaxContent layout to FFC. This means that an FFC can now calculate intrinsic sizes for the flex container, to be used by the parent formatting context. There are some FIXME's as usual, but this already works on basic things.
2022-04-06 01:20:20 +02:00
LibWeb: Make two passes in FFC where to support percentage min/max sizes Percentage sizes of flex items are relative to the flex container, but even when the flex container is automatically sized, we still have to support them. To make this work, we first do a pass where percentage sizes are ignored (treated as "auto", basically) in order to get a "reference" value. Then we do a second pass where percentages can be resolved against this reference value.
2022-07-22 22:02:02 +02:00
[[nodiscard]] float calculate_cross_min_content_contribution(FlexItem const&, bool resolve_percentage_min_max_sizes) const;
[[nodiscard]] float calculate_cross_max_content_contribution(FlexItem const&, bool resolve_percentage_min_max_sizes) const;
LibWeb: Implement basic intrinsic sizing algorithms for flex containers This patch adds support for MinContent and MaxContent layout to FFC. This means that an FFC can now calculate intrinsic sizes for the flex container, to be used by the parent formatting context. There are some FIXME's as usual, but this already works on basic things.
2022-04-06 01:20:20 +02:00
[[nodiscard]] float calculate_main_min_content_contribution(FlexItem const&) const;
[[nodiscard]] float calculate_main_max_content_contribution(FlexItem const&) const;
LibWeb: Add FFC helpers for getting intrinsic size of flex items
2022-07-08 12:50:04 +02:00
[[nodiscard]] float calculate_min_content_main_size(FlexItem const&) const;
[[nodiscard]] float calculate_max_content_main_size(FlexItem const&) const;
[[nodiscard]] float calculate_min_content_cross_size(FlexItem const&) const;
[[nodiscard]] float calculate_max_content_cross_size(FlexItem const&) const;
LibWeb: Express intrinsic size layout via size constraints Previously, we had three layout modes: - Normal: - Everything uses the computed values from CSS. - MinContent: - Containing blocks act as if they have 0 width. - All line breaking opportunities are taken. - MaxContent: - Containing blocks act as if they have infinite width. - Only forced line breaks are accepted. The above was based on a set of misunderstandings of CSS sizing. A major problem with the above was that *all* containing blocks behaved differently during intrinsic size layout, not just the relevant one. With this patch there are only two layout modes: - Normal: - Everything uses the computed values from CSS. - IntrinsicSizeDetermination: - One or more boxes have size constraints applied. There are two size constraints per layout box, set here: - FormattingState::NodeState::width_constraint - FormattingState::NodeState::height_constraint They are of type SizeConstraint and can be one of None, MinContent, or MaxContent. The default is None. When performing an IntrinsicSizeDetermination layout, we now assign a size constraint to the box we're trying to determine the intrinsic size of, which is then honored by using two new helpers to query the dimensions of containing blocks: - FormattingContext::containing_block_width_for(Box) - FormattingContext::containing_block_height_for(Box) If there's a relevant constraint in effect on the Box, the size of its containing block is adjusted accordingly. This is essentially an implementation of the "available space" constraints from CSS-SIZING-3. I'm sure some things will break from this, and we'll have to deal with that separately. Spec: https://drafts.csswg.org/css-sizing-3/#available
2022-07-09 15:17:47 +02:00
[[nodiscard]] float calculate_fit_content_main_size(FlexItem const&) const;
[[nodiscard]] float calculate_fit_content_cross_size(FlexItem const&) const;
LibWeb: Position abspos children of flex container after parent layout If we wait until after the parent context has laid out the flex container, abspos children are able to use the final results of the parent sizing the flex container. This makes `height:auto` work on abspos children of a flex container.
2022-07-22 16:36:17 +02:00
virtual void parent_context_did_dimension_child_root_box() override;
LibWeb: Support flex item cross sizing based on intrinsic aspect ratio This patch implements case B from the "determine the flex base size and hypothetical main size of each item" from the flexbox algorithm. https://drafts.csswg.org/css-flexbox-1/#algo-main-item
2022-07-07 12:39:24 +02:00
CSS::FlexBasisData used_flex_basis_for_item(FlexItem const&) const;
LibWeb: Rename LayoutState::NodeState => LayoutState::UsedValues This object contains all the CSS "used values" as seen during the layout process, so calling it "used values" seems appropriate. :^)
2022-07-16 23:43:48 +02:00
LayoutState::UsedValues& m_flex_container_state;
LibWeb: Start making our layout system "transactional" This patch adds a map of Layout::Node to FormattingState::NodeState. Instead of updating layout nodes incrementally as layout progresses through the formatting contexts, all updates are now written to the corresponding NodeState instead. At the end of layout, FormattingState::commit() is called, which transfers all the values from the NodeState objects to the Node. This will soon allow us to perform completely non-destructive layouts which don't affect the tree. Note that there are many imperfections here, and still many places where we assign to the NodeState, but later read directly from the Node instead. I'm just committing at this stage to make subsequent diffs easier to understand.
2022-02-20 15:51:24 +01:00
LibWeb: Make FFC line and item vectors members instead of locals This gives all member functions access to these vectors without having to pass them as arguments.
2021-10-13 22:44:54 +02:00
Vector<FlexLine> m_flex_lines;
Vector<FlexItem> m_flex_items;
LibWeb: Split out FFC's "generate anonymous flex items" to a function Let's begin splitting the FlexFormattingContext layout algorithm into separate functions to make it more manageable.
2021-10-13 19:57:26 +02:00
CSS::FlexDirection m_flex_direction {};
LibWeb: Put available space information in an FFC member This makes it easier for each step of the flex layout algorithm to access this information.
2022-02-27 12:19:58 +01:00
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
struct AxisAgnosticAvailableSpace {
AvailableSize main;
AvailableSize cross;
LibWeb: Make intrinsic heights dependent on available width After speaking with fantasai at CSSWG about this, it turns out I had misunderstood intrinsic heights. I originally believed all intrinsic sizes had to be computed with no influence from the surrounding context. As it turns out, intrinsic heights *are* influenced by the available width, since it's needed to determine where lines break. The APIs for calculating min-content and max-content heights now take the available width as inputs. This instantly improves layout in many cases where we'd previously make things way too wide.
2022-10-03 23:37:38 +02:00
AvailableSpace space;
LibWeb: Put available space information in an FFC member This makes it easier for each step of the flex layout algorithm to access this information.
2022-02-27 12:19:58 +01:00
};
LibWeb: Reorganize layout algorithms around available space This is a big and messy change, and here's the gist: - AvaliableSpace is now 2x AvailableSize (width and height) - Layout algorithms are redesigned around the idea of available space - When doing layout across nested formatting contexts, the parent context tells the child context how much space is available for the child's root box in both axes. - "Available space" replaces "containing block width" in most places. - The width and height in a box's UsedValues are considered to be definite after they're assigned to. Marking something as having definite size is no longer a separate step, This probably introduces various regressions, but the big win here is that our layout system now works with available space, just like the specs are written. Fixing issues will be much easier going forward, since you don't need to do nearly as much conversion from "spec logic" to "LibWeb logic" as you previously did.
2022-09-27 15:29:17 +02:00
Optional<AxisAgnosticAvailableSpace> m_available_space_for_items;
Optional<AxisAgnosticAvailableSpace> m_available_space_for_flex_container;
LibWeb: Add a very naive Layout::FlexFormattingContext :^) This is very dumb and only lays out its child boxes on a horizontal line with their shrink-to-fit widths. You have to start somewhere! :^)
2021-01-18 17:33:46 +01:00
};
}
Reference in a new issue Copy permalink