Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-04 23:30:59 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Libraries/LibGUI/AboutDialog.cpp

89 lines
2.9 KiB
C++
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
Libraries: Use default constructors/destructors in LibGUI https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler."
2022-02-26 10:50:04 -07:00
* Copyright (c) 2022, the SerenityOS developers.
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
*/
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
#include <AK/StringBuilder.h>
LibGUI: Remove leading G from filenames
2020-02-06 20:33:02 +01:00
#include <LibGUI/AboutDialog.h>
#include <LibGUI/BoxLayout.h>
#include <LibGUI/Button.h>
LibGUI: Rename GUI::Image => GUI::ImageWidget "Image" was a bit too vague, "ImageWidget" is obviously a widget of some sort.
2020-07-22 15:29:51 +02:00
#include <LibGUI/ImageWidget.h>
Meta+LibC through LibHTTP: Make clang-format-10 clean Why break at LibHTTP? Because "Meta+Libraries" would be insanely large, and breaking between LibHTTP and LibJS makes the commits roughly evenly large.
2020-09-18 09:49:51 +02:00
#include <LibGUI/Label.h>
LibGUI: Remove leading G from filenames
2020-02-06 20:33:02 +01:00
#include <LibGUI/Widget.h>
LibGfx: Move other font-related files to LibGfx/Font/
2022-04-09 09:28:38 +02:00
#include <LibGfx/Font/Font.h>
#include <LibGfx/Font/FontDatabase.h>
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 15:07:41 +01:00
namespace GUI {
Userland+LibCore: Remove legacy SERENITY_VERSION from Core::Version This was being used as a default version argument in a couple of APIs, so those need to change signature and the caller always needs to provide a version.
2022-08-30 12:49:08 +02:00
AboutDialog::AboutDialog(StringView name, StringView version, Gfx::Bitmap const* icon, Window* parent_window)
LibGUI: Don't use Core::Object::add() to instantiate dialogs Now that add() returns a WidgetType&, we can't rely on the parent of a GUI::Dialog to still keep it alive after exec() returns. This happens because exec() will call remove_from_parent() on itself before returning. And so we go back to the old idiom for creating a GUI::Dialog centered above a specific window. Just call GUI::Dialog::construct(), passing the "parent" window as the last parameter.
2020-03-04 20:53:51 +01:00
: Dialog(parent_window)
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
, m_name(name)
, m_icon(icon)
AboutDialog: Accept a version string This allows applications to specify a version string to appear in the `AboutDialog`.
2021-08-29 12:00:50 +02:00
, m_version_string(version)
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
{
AboutDialog: Fix inconsistent margins
2021-07-27 20:13:13 +02:00
resize(413, 204);
AK+Everywhere: Rename String to DeprecatedString We have a new, improved string type coming up in AK (OOM aware, no null state), and while it's going to use UTF-8, the name UTF8String is a mouthful - so let's free up the String name by renaming the existing class. Making the old one have an annoying name will hopefully also help with quick adoption :^)
2022-12-04 18:02:33 +00:00
set_title(DeprecatedString::formatted("About {}", m_name));
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
set_resizable(false);
LibGUI: AboutDialog now inherits the icon of its parent window
2020-03-30 09:01:02 +02:00
if (parent_window)
set_icon(parent_window->icon());
LibGUI+Everywhere: Use fallible Window::set_main_widget() everywhere :^) Rip that bandaid off! This does the following, in one big, awkward jump: - Replace all uses of `set_main_widget<Foo>()` with the `try` version. - Remove `set_main_widget<Foo>()`. - Rename the `try` version to just be `set_main_widget` because it's now the only one. The majority of places that call `set_main_widget<Foo>()` are inside constructors, so this unfortunately gives us a big batch of new `release_value_but_fixme_should_propagate_errors()` calls.
2023-01-06 16:48:37 +00:00
auto widget = set_main_widget<Widget>().release_value_but_fixme_should_propagate_errors();
widget->set_fill_with_background_color(true);
widget->set_layout<VerticalBoxLayout>();
widget->layout()->set_spacing(0);
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
LibGUI+Everywhere: Use fallible Window::set_main_widget() everywhere :^) Rip that bandaid off! This does the following, in one big, awkward jump: - Replace all uses of `set_main_widget<Foo>()` with the `try` version. - Remove `set_main_widget<Foo>()`. - Rename the `try` version to just be `set_main_widget` because it's now the only one. The majority of places that call `set_main_widget<Foo>()` are inside constructors, so this unfortunately gives us a big batch of new `release_value_but_fixme_should_propagate_errors()` calls.
2023-01-06 16:48:37 +00:00
auto& banner_image = widget->add<GUI::ImageWidget>();
Everywhere: Add sv suffix to strings relying on StringView(char const*) Each of these strings would previously rely on StringView's char const* constructor overload, which would call __builtin_strlen on the string. Since we now have operator ""sv, we can replace these with much simpler versions. This opens the door to being able to remove StringView(char const*). No functional changes.
2022-07-11 17:32:29 +00:00
banner_image.load_from_file("/res/graphics/brand-banner.png"sv);
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
LibGUI+Everywhere: Use fallible Window::set_main_widget() everywhere :^) Rip that bandaid off! This does the following, in one big, awkward jump: - Replace all uses of `set_main_widget<Foo>()` with the `try` version. - Remove `set_main_widget<Foo>()`. - Rename the `try` version to just be `set_main_widget` because it's now the only one. The majority of places that call `set_main_widget<Foo>()` are inside constructors, so this unfortunately gives us a big batch of new `release_value_but_fixme_should_propagate_errors()` calls.
2023-01-06 16:48:37 +00:00
auto& content_container = widget->add<Widget>();
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
content_container.set_layout<HorizontalBoxLayout>();
auto& left_container = content_container.add<Widget>();
LibGUI: Rewrite layout system in terms of min and max sizes This patch removes size policies and preferred sizes, and replaces them with min-size and max-size for each widget. Box layout now works in 3 passes: 1) Set all items (widgets/spacers) to their min-size 2) Distribute remaining space evenly, respecting max-size 3) Place widgets one after the other, adding spacing in between I've also added convenience helpers for setting a fixed size (which is the same as setting min-size and max-size to the same value.) This significantly reduces the verbosity of widget layout and makes GML a bit more pleasant to write, too. :^)
2020-12-30 01:23:32 +01:00
left_container.set_fixed_width(60);
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
left_container.set_layout<VerticalBoxLayout>();
Userland+LibGUI: Add shorthand versions of the Margins constructor This allows for typing [8] instead of [8, 8, 8, 8] to specify the same margin on all edges, for example. The constructors follow CSS' style of specifying margins. The added constructors are: - Margins(int all): Sets the same margin on all edges. - Margins(int vertical, int horizontal): Sets the first argument to top and bottom margins, and the second argument to left and right margins. - Margins(int top, int vertical, int bottom): Sets the first argument to the top margin, the second argument to the left and right margins, and the third argument to the bottom margin.
2021-08-17 00:11:38 +00:00
left_container.layout()->set_margins({ 12, 0, 0 });
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
if (icon) {
auto& icon_wrapper = left_container.add<Widget>();
LibGUI: Rewrite layout system in terms of min and max sizes This patch removes size policies and preferred sizes, and replaces them with min-size and max-size for each widget. Box layout now works in 3 passes: 1) Set all items (widgets/spacers) to their min-size 2) Distribute remaining space evenly, respecting max-size 3) Place widgets one after the other, adding spacing in between I've also added convenience helpers for setting a fixed size (which is the same as setting min-size and max-size to the same value.) This significantly reduces the verbosity of widget layout and makes GML a bit more pleasant to write, too. :^)
2020-12-30 01:23:32 +01:00
icon_wrapper.set_fixed_size(32, 48);
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
icon_wrapper.set_layout<VerticalBoxLayout>();
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
LibGUI: Rename GUI::Image => GUI::ImageWidget "Image" was a bit too vague, "ImageWidget" is obviously a widget of some sort.
2020-07-22 15:29:51 +02:00
auto& icon_image = icon_wrapper.add<ImageWidget>();
AboutDialog: Replace Label with Image to show banner and app icon
2020-06-14 11:06:46 +03:00
icon_image.set_bitmap(m_icon);
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
}
auto& right_container = content_container.add<Widget>();
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
right_container.set_layout<VerticalBoxLayout>();
Userland+LibGUI: Make Margins arguments match CSS ordering Previously the argument order for Margins was (left, top, right, bottom). To make it more familiar and closer to how CSS does it, the argument order is now (top, right, bottom, left).
2021-08-17 00:10:51 +00:00
right_container.layout()->set_margins({ 12, 4, 4, 0 });
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
Everywhere: Pass AK::StringView by value
2021-11-11 00:55:02 +01:00
auto make_label = [&](StringView text, bool bold = false) {
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
auto& label = right_container.add<Label>(text);
label.set_text_alignment(Gfx::TextAlignment::CenterLeft);
LibGUI: Rewrite layout system in terms of min and max sizes This patch removes size policies and preferred sizes, and replaces them with min-size and max-size for each widget. Box layout now works in 3 passes: 1) Set all items (widgets/spacers) to their min-size 2) Distribute remaining space evenly, respecting max-size 3) Place widgets one after the other, adding spacing in between I've also added convenience helpers for setting a fixed size (which is the same as setting min-size and max-size to the same value.) This significantly reduces the verbosity of widget layout and makes GML a bit more pleasant to write, too. :^)
2020-12-30 01:23:32 +01:00
label.set_fixed_height(14);
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
if (bold)
LibGfx: Remove Gfx::FontDatabase::default_bold_font() Instead use default_font().bold_variant() in cases where we want a bold variant of the default font. :^)
2021-05-20 18:40:48 +02:00
label.set_font(Gfx::FontDatabase::default_font().bold_variant());
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
};
make_label(m_name, true);
LibGUI, About: Implement system-wide W2k-esque About dialog The new About dialog reads version information from /res/version.ini, which is generated at build time.
2020-05-24 14:26:33 +00:00
// If we are displaying a dialog for an application, insert 'SerenityOS' below the application name
if (m_name != "SerenityOS")
Everywhere: Add sv suffix to strings relying on StringView(char const*) Each of these strings would previously rely on StringView's char const* constructor overload, which would call __builtin_strlen on the string. Since we now have operator ""sv, we can replace these with much simpler versions. This opens the door to being able to remove StringView(char const*). No functional changes.
2022-07-11 17:32:29 +00:00
make_label("SerenityOS"sv);
AboutDialog: Accept a version string This allows applications to specify a version string to appear in the `AboutDialog`.
2021-08-29 12:00:50 +02:00
make_label(m_version_string);
LibGUI: Update the AboutDialog copyright year
2023-01-11 16:16:04 +00:00
make_label("Copyright \xC2\xA9 the SerenityOS developers, 2018-2023"sv);
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
right_container.layout()->add_spacer();
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
auto& button_container = right_container.add<Widget>();
AboutDialog: Fix inconsistent margins
2021-07-27 20:13:13 +02:00
button_container.set_fixed_height(22);
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
button_container.set_layout<HorizontalBoxLayout>();
button_container.layout()->add_spacer();
LibGUI: Use new DialogButton for consistency
2022-06-10 23:03:11 +02:00
auto& ok_button = button_container.add<DialogButton>("OK");
LibGUI: Include keyboard modifier state with button on_click calls This will allow you us to implement special behavior when Ctrl+clicking a button.
2020-05-12 20:30:33 +02:00
ok_button.on_click = [this](auto) {
LibGUI+Userland: Make Dialog::ExecResult an enum class
2022-05-13 13:10:27 +01:00
done(ExecResult::OK);
LibGUI: Add GAboutDialog, a simple way to show a nice about box in apps
2019-09-02 19:45:55 +02:00
};
}
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 15:07:41 +01:00
}
Reference in a new issue Copy permalink