Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-21 16:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/SVG/SVGRadialGradientElement.cpp

255 lines
11 KiB
C++
Raw Normal View History

LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
/*
* Copyright (c) 2023, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
LibWeb: Don't include HTML/Window.h from DOM/Element.h This required moving HTML::ScrollOptions to its own header file.
2023-05-08 07:39:05 +02:00
#include <LibWeb/Bindings/Intrinsics.h>
LibWeb: Remove Bindings/Forward.h from LibWeb/Forward.h This was resulting in a whole lot of rebuilding whenever a new IDL interface was added. Instead, just directly include the prototype in every C++ file which needs it. While we only really need a forward declaration in each cpp file; including the full prototype header (which itself only includes LibJS/Object.h, which is already transitively brought in by PlatformObject) - it seems like a small price to pay compared to what feels like a full rebuild of LibWeb whenever a new IDL file is added. Given all of these includes are only needed for the ::initialize method, there is probably a smart way of avoiding this problem altogether. I've considered both using some macro trickery or generating these functions somehow instead.
2024-04-27 12:09:58 +12:00
#include <LibWeb/Bindings/SVGRadialGradientElementPrototype.h>
LibWeb+LibGfx: Replace usage of Gfx::PaintStyle in fill{stoke}_commands ...with a struct defined in LibWeb. This is a step towards uncoupling LibWeb from LibGfx, so we can try third-party libraries for painting.
2024-06-13 15:22:46 +03:00
#include <LibWeb/Painting/PaintStyle.h>
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
#include <LibWeb/SVG/AttributeNames.h>
#include <LibWeb/SVG/SVGRadialGradientElement.h>
namespace Web::SVG {
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DEFINE_ALLOCATOR(SVGRadialGradientElement);
LibWeb: Put most LibWeb GC objects in type-specific heap blocks With this change, we now have ~1200 CellAllocators across both LibJS and LibWeb in a normal WebContent instance. This gives us a minimum heap size of 4.7 MiB in the scenario where we only have one cell allocated per type. Of course, in practice there will be many more of each type, so the effective overhead is quite a bit smaller than that in practice. I left a few types unconverted to this mechanism because I got tired of doing this. :^)
2023-11-19 19:47:52 +01:00
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
SVGRadialGradientElement::SVGRadialGradientElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: SVGGradientElement(document, qualified_name)
{
}
LibJS: Make Cell::initialize() return void Stop worrying about tiny OOMs. Work towards #20405
2023-08-07 08:41:28 +02:00
void SVGRadialGradientElement::initialize(JS::Realm& realm)
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Avoid FlyString lookups when setting IDL interface prototypes This commit introduces a WEB_SET_PROTOTYPE_FOR_INTERFACE macro that caches the interface name in a local static FlyString. This means that we only pay for FlyString-from-literal lookup once per browser lifetime instead of every time the interface is instantiated.
2024-03-16 13:13:08 +01:00
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGRadialGradientElement);
LibWeb: Only set prototype once for object with IDL interface Before this change, we were going through the chain of base classes for each IDL interface object and having them set the prototype to their prototype. Instead of doing that, reorder things so that we set the right prototype immediately in Foo::initialize(), and then don't bother in all the base class overrides. This knocks off a ~1% profile item on Speedometer 3.
2025-04-20 16:22:57 +02:00
Base::initialize(realm);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibWeb: Consolidate the attribute change handlers We currently have 2 virtual methods to inform DOM::Element subclasses when an attribute has changed, one of which is spec-compliant. This patch removes the non-compliant variant.
2024-11-14 08:14:16 -05:00
void SVGRadialGradientElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Consolidate the attribute change handlers We currently have 2 virtual methods to inform DOM::Element subclasses when an attribute has changed, one of which is spec-compliant. This patch removes the non-compliant variant.
2024-11-14 08:14:16 -05:00
Base::attribute_changed(name, old_value, value, namespace_);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
// FIXME: These are <length> or <coordinate> in the spec, but all examples seem to allow percentages
// and unitless values.
if (name == SVG::AttributeNames::cx) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_cx = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
} else if (name == SVG::AttributeNames::cy) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_cy = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
} else if (name == SVG::AttributeNames::fx) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_fx = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
} else if (name == SVG::AttributeNames::fy) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_fy = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
} else if (name == SVG::AttributeNames::fr) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_fr = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
} else if (name == SVG::AttributeNames::r) {
LibWeb: Port Element::attribute_changed from DeprecatedString to String Which as you would expect has a bunch of fallout, but also results in a whole lot of awkward conversions falling away.
2023-11-19 18:10:36 +13:00
m_r = AttributeParser::parse_number_percentage(value.value_or(String {}));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
m_paint_style = nullptr;
}
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementFXAttribute
NumberPercentage SVGRadialGradientElement::start_circle_x() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return start_circle_x_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::start_circle_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
if (m_fx.has_value())
return *m_fx;
// If the element references an element that specifies a value for 'fx', then the value of 'fx' is
// inherited from the referenced element.
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->start_circle_x_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
// If attribute ‘fx’ is not specified, ‘fx’ will coincide with the presentational value of ‘cx’ for
// the element whether the value for 'cx' was inherited or not.
return end_circle_x();
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementFYAttribute
NumberPercentage SVGRadialGradientElement::start_circle_y() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return start_circle_y_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::start_circle_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
if (m_fy.has_value())
return *m_fy;
// If the element references an element that specifies a value for 'fy', then the value of 'fy' is
// inherited from the referenced element.
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->start_circle_y_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
// If attribute ‘fy’ is not specified, ‘fy’ will coincide with the presentational value of ‘cy’ for
// the element whether the value for 'cy' was inherited or not.
return end_circle_y();
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementFRAttribute
NumberPercentage SVGRadialGradientElement::start_circle_radius() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return start_circle_radius_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::start_circle_radius_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
// Note: A negative value is an error.
if (m_fr.has_value() && m_fr->value() >= 0)
return *m_fr;
// if the element references an element that specifies a value for 'fr', then the value of
// 'fr' is inherited from the referenced element.
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->start_circle_radius_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
// If the attribute is not specified, the effect is as if a value of '0%' were specified.
return NumberPercentage::create_percentage(0);
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementCXAttribute
NumberPercentage SVGRadialGradientElement::end_circle_x() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return end_circle_x_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::end_circle_x_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
if (m_cx.has_value())
return *m_cx;
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->end_circle_x_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
return NumberPercentage::create_percentage(50);
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementCYAttribute
NumberPercentage SVGRadialGradientElement::end_circle_y() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return end_circle_y_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::end_circle_y_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
if (m_cy.has_value())
return *m_cy;
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->end_circle_y_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
return NumberPercentage::create_percentage(50);
}
// https://svgwg.org/svg2-draft/pservers.html#RadialGradientElementRAttribute
NumberPercentage SVGRadialGradientElement::end_circle_radius() const
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
{
HashTable<SVGGradientElement const*> seen_gradients;
return end_circle_radius_impl(seen_gradients);
}
NumberPercentage SVGRadialGradientElement::end_circle_radius_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
// Note: A negative value is an error.
if (m_r.has_value() && m_r->value() >= 0)
return *m_r;
LibWeb: Handle reference cycles in SVG gradient linking Since SVG gradients can reference each other, we have to keep track of visited gradients when traversing the link chain, or we will recurse infinitely when there's a reference cycle.
2024-03-10 12:18:09 +01:00
if (auto gradient = linked_radial_gradient(seen_gradients))
return gradient->end_circle_radius_impl(seen_gradients);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
return NumberPercentage::create_percentage(50);
}
LibWeb+LibGfx: Replace usage of Gfx::PaintStyle in fill{stoke}_commands ...with a struct defined in LibWeb. This is a step towards uncoupling LibWeb from LibGfx, so we can try third-party libraries for painting.
2024-06-13 15:22:46 +03:00
Optional<Painting::PaintStyle> SVGRadialGradientElement::to_gfx_paint_style(SVGPaintContext const& paint_context) const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
auto units = gradient_units();
Gfx::FloatPoint start_center;
float start_radius = 0.0f;
Gfx::FloatPoint end_center;
float end_radius = 0.0f;
if (units == GradientUnits::ObjectBoundingBox) {
// If gradientUnits="objectBoundingBox", the user coordinate system for attributes ‘cx’, ‘cy’, ‘r’, ‘fx’, ‘fy’, and ‘fr’
// is established using the bounding box of the element to which the gradient is applied (see Object bounding box units)
// and then applying the transform specified by attribute ‘gradientTransform’. Percentages represent values relative
// to the bounding box for the object.
LibWeb: Fix end position for objectBoundingBox SVG <radialGradient>s The translation to the bounding box location is handled by the gradient transform, also doing it here breaks things. This fixes the MDN <radialGradient> example.
2023-06-17 19:25:54 +01:00
start_center = Gfx::FloatPoint { start_circle_x().value(), start_circle_y().value() };
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
start_radius = start_circle_radius().value();
LibWeb: Fix end position for objectBoundingBox SVG <radialGradient>s The translation to the bounding box location is handled by the gradient transform, also doing it here breaks things. This fixes the MDN <radialGradient> example.
2023-06-17 19:25:54 +01:00
end_center = Gfx::FloatPoint { end_circle_x().value(), end_circle_y().value() };
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
end_radius = end_circle_radius().value();
} else {
// GradientUnits::UserSpaceOnUse
// If gradientUnits="userSpaceOnUse", ‘cx’, ‘cy’, ‘r’, ‘fx’, ‘fy’, and ‘fr’ represent values in the coordinate system
// that results from taking the current user coordinate system in place at the time when the gradient element is
// referenced (i.e., the user coordinate system for the element referencing the gradient element via a fill or stroke property)
// and then applying the transform specified by attribute ‘gradientTransform’.
// Percentages represent values relative to the current SVG viewport.
// Note: The start/end centers will be in relative units here.
// They will be resolved at paint time using the gradient paint transform.
start_center = Gfx::FloatPoint {
start_circle_x().resolve_relative_to(paint_context.viewport.width()),
start_circle_y().resolve_relative_to(paint_context.viewport.height()),
};
// FIXME: Where in the spec does it say what axis the radius is relative to?
start_radius = start_circle_radius().resolve_relative_to(paint_context.viewport.width());
end_center = Gfx::FloatPoint {
end_circle_x().resolve_relative_to(paint_context.viewport.width()),
end_circle_y().resolve_relative_to(paint_context.viewport.height()),
};
end_radius = end_circle_radius().resolve_relative_to(paint_context.viewport.width());
}
if (!m_paint_style) {
LibWeb+LibGfx: Replace usage of Gfx::PaintStyle in fill{stoke}_commands ...with a struct defined in LibWeb. This is a step towards uncoupling LibWeb from LibGfx, so we can try third-party libraries for painting.
2024-06-13 15:22:46 +03:00
m_paint_style = Painting::SVGRadialGradientPaintStyle::create(start_center, start_radius, end_center, end_radius);
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
// FIXME: Update stops in DOM changes:
add_color_stops(*m_paint_style);
} else {
m_paint_style->set_start_center(start_center);
m_paint_style->set_start_radius(start_radius);
m_paint_style->set_end_center(end_center);
m_paint_style->set_end_radius(end_radius);
}
m_paint_style->set_gradient_transform(gradient_paint_transform(paint_context));
LibWeb+LibGfx: Replace usage of Gfx::PaintStyle in fill{stoke}_commands ...with a struct defined in LibWeb. This is a step towards uncoupling LibWeb from LibGfx, so we can try third-party libraries for painting.
2024-06-13 15:22:46 +03:00
m_paint_style->set_spread_method(to_painting_spread_method(spread_method()));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
return *m_paint_style;
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::cx() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::cy() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::fx() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::fy() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::fr() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC::Ref<SVGAnimatedLength> SVGRadialGradientElement::r() const
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
{
LibWeb: Return a dummy value from various SVG getters Instead of crashing with a TODO() on half of the test cases generated by Domato, let's just return a zeroed-out SVGAnimatedLength or SVGAnimatedNumber from getters that return them. We'll eventually have to implement these correctly, but crashing is not productive since it blocks us from finding other issues.
2024-03-11 15:34:24 +01:00
// FIXME: Implement this properly.
return SVGAnimatedLength::create(realm(), SVGLength::create(realm(), 0, 0), SVGLength::create(realm(), 0, 0));
LibWeb: Add an initial implementation of SVG `<radialGradient>` This follows on from the SVG linear gradients. It supports the same features (xlink:href, gradientUnits, gradientTransform). With this commit I have now implemented all web gradients :^) (Though we are still missing a few parameters for SVG gradients, e.g. spreadMethod).
2023-05-02 23:11:58 +01:00
}
}
Reference in a new issue Copy permalink