Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Libraries/LibWeb/HTML/AnimatedBitmapDecodedImageData.cpp

73 lines
2.3 KiB
C++
Raw Normal View History

LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
/*
Meta: Update my e-mail address everywhere
2024-10-04 13:19:50 +02:00
* Copyright (c) 2023, Andreas Kling <andreas@ladybird.org>
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
#include <LibGC/Heap.h>
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
#include <LibGfx/Bitmap.h>
Everywhere: Avoid large rebuilds when editing (Immutable)Bitmap headers This reduces the number of recompiled files as follow: - Bitmap.h: 1309 -> 101 - ImmutableBitmap.h: 1218 -> 75
2025-11-23 13:07:35 +01:00
#include <LibGfx/ImmutableBitmap.h>
LibWeb: Make HTML::DecodedImageData to be GC-allocated This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
2023-12-12 20:07:19 +01:00
#include <LibJS/Runtime/Realm.h>
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
#include <LibWeb/HTML/AnimatedBitmapDecodedImageData.h>
LibWeb: Add API to allow DecodedImageData to paint itself directly Instead of painting DecodedImageData by first asking it for a bitmap and then painting that, this commit adds two new APIs: - frame_rect(frame_index): Gets the size of the animation frame at the given index. - paint(context, ...): Paints the DecodedImageData into a DisplayListRecordingContext. The main powerful thing here is that this allows SVGDecodedImageData to render itself using the GPU when available.
2025-11-04 21:20:00 +01:00
#include <LibWeb/Painting/DisplayListRecorder.h>
#include <LibWeb/Painting/DisplayListRecordingContext.h>
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
namespace Web::HTML {
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
GC_DEFINE_ALLOCATOR(AnimatedBitmapDecodedImageData);
LibWeb: Make HTML::DecodedImageData to be GC-allocated This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
2023-12-12 20:07:19 +01:00
LibGC+Everywhere: Factor out a LibGC from LibJS Resulting in a massive rename across almost everywhere! Alongside the namespace change, we now have the following names: * JS::NonnullGCPtr -> GC::Ref * JS::GCPtr -> GC::Ptr * JS::HeapFunction -> GC::Function * JS::CellImpl -> GC::Cell * JS::Handle -> GC::Root
2024-11-15 04:01:23 +13:00
ErrorOr<GC::Ref<AnimatedBitmapDecodedImageData>> AnimatedBitmapDecodedImageData::create(JS::Realm& realm, Vector<Frame>&& frames, size_t loop_count, bool animated)
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
{
LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T> The main motivation behind this is to remove JS specifics of the Realm from the implementation of the Heap. As a side effect of this change, this is a bit nicer to read than the previous approach, and in my opinion, also makes it a little more clear that this method is specific to a JavaScript Realm.
2024-11-14 05:50:17 +13:00
return realm.create<AnimatedBitmapDecodedImageData>(move(frames), loop_count, animated);
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
}
AnimatedBitmapDecodedImageData::AnimatedBitmapDecodedImageData(Vector<Frame>&& frames, size_t loop_count, bool animated)
: m_frames(move(frames))
, m_loop_count(loop_count)
, m_animated(animated)
{
}
AnimatedBitmapDecodedImageData::~AnimatedBitmapDecodedImageData() = default;
LibGfx+LibWeb: Add ImmutableBitmap for images bitmap caching in painter Before this change, we used Gfx::Bitmap to represent both decoded images that are not going to be mutated and bitmaps corresponding to canvases that could be mutated. This change introduces a wrapper for bitmaps that are not going to be mutated, so the painter could do caching: texture caching in the case of GPU painter and potentially scaled bitmap caching in the case of CPU painter.
2023-11-24 14:45:45 +01:00
RefPtr<Gfx::ImmutableBitmap> AnimatedBitmapDecodedImageData::bitmap(size_t frame_index, Gfx::IntSize) const
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
{
if (frame_index >= m_frames.size())
return nullptr;
return m_frames[frame_index].bitmap;
}
int AnimatedBitmapDecodedImageData::frame_duration(size_t frame_index) const
{
if (frame_index >= m_frames.size())
return 0;
return m_frames[frame_index].duration;
}
LibWeb: Make ImageBox ask ImageProvider for intrinsic size and ratio This paves the way for ImageProvider to have something vector-based underneath. :^)
2023-05-20 16:27:31 +02:00
Optional<CSSPixels> AnimatedBitmapDecodedImageData::intrinsic_width() const
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
{
return m_frames.first().bitmap->width();
}
LibWeb: Make ImageBox ask ImageProvider for intrinsic size and ratio This paves the way for ImageProvider to have something vector-based underneath. :^)
2023-05-20 16:27:31 +02:00
Optional<CSSPixels> AnimatedBitmapDecodedImageData::intrinsic_height() const
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
{
return m_frames.first().bitmap->height();
}
LibWeb: Use `CSSPixelFraction` to represent aspect ratios This allows us to retain perfect precision for aspect ratios derived from either the intrinsic sizes of replaced elements, or the `aspect-ratio` CSS property.
2023-09-03 17:33:58 -05:00
Optional<CSSPixelFraction> AnimatedBitmapDecodedImageData::intrinsic_aspect_ratio() const
LibWeb: Make ImageBox ask ImageProvider for intrinsic size and ratio This paves the way for ImageProvider to have something vector-based underneath. :^)
2023-05-20 16:27:31 +02:00
{
LibWeb: Use `CSSPixelFraction` to represent aspect ratios This allows us to retain perfect precision for aspect ratios derived from either the intrinsic sizes of replaced elements, or the `aspect-ratio` CSS property.
2023-09-03 17:33:58 -05:00
return CSSPixels(m_frames.first().bitmap->width()) / CSSPixels(m_frames.first().bitmap->height());
LibWeb: Make ImageBox ask ImageProvider for intrinsic size and ratio This paves the way for ImageProvider to have something vector-based underneath. :^)
2023-05-20 16:27:31 +02:00
}
LibWeb: Add API to allow DecodedImageData to paint itself directly Instead of painting DecodedImageData by first asking it for a bitmap and then painting that, this commit adds two new APIs: - frame_rect(frame_index): Gets the size of the animation frame at the given index. - paint(context, ...): Paints the DecodedImageData into a DisplayListRecordingContext. The main powerful thing here is that this allows SVGDecodedImageData to render itself using the GPU when available.
2025-11-04 21:20:00 +01:00
Optional<Gfx::IntRect> AnimatedBitmapDecodedImageData::frame_rect(size_t frame_index) const
{
return m_frames[frame_index].bitmap->rect();
}
void AnimatedBitmapDecodedImageData::paint(DisplayListRecordingContext& context, size_t frame_index, Gfx::IntRect dst_rect, Gfx::IntRect clip_rect, Gfx::ScalingMode scaling_mode) const
{
context.display_list_recorder().draw_scaled_immutable_bitmap(dst_rect, clip_rect, *m_frames[frame_index].bitmap, scaling_mode);
}
LibWeb: Make DecodedImageData an abstract class The existing implementation moves down into a new subclass called AnimatedBitmapDecodedImageData. The purpose of this change is to create an extension point where we can plug in an SVG renderer. :^)
2023-05-20 16:11:36 +02:00
}
Reference in a new issue Copy permalink