Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-11-04 07:10:57 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Libraries/LibWeb/HTML/Timer.h

40 lines
888 B
C
Raw Normal View History

LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
*/
#pragma once
#include <AK/Forward.h>
LibWeb: Implement setTimeout/setInterval with ESO according to the spec Our setInterval implementation currently crashes on DuckDuckGo when it's invoked with a string argument. In this path, we were creating a native function to evaluate and execute that string. That evaluation was always returning a Completion, but NativeFunction expects ThrowCompletionOr. The conversion from Completion to ThrowCompletionOr would fail a VERIFY because that conversion is only valid if the Completion is an error; but we would trigger this conversion even on success. This change re-implements setTimeout & setInterval in direct accordance with the spec. So we avoid making that NativeFunction altogether, and DDG can progress past its invocation to the timer. With this change, we also have other features we did not previously support, such as passing any number of arguments to the timers. This does not implement handling of nesting levels yet.
2022-03-04 10:41:12 -05:00
#include <AK/Function.h>
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
#include <AK/WeakPtr.h>
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
#include <LibCore/Forward.h>
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
#include <LibJS/Heap/Cell.h>
#include <LibJS/Heap/GCPtr.h>
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
#include <LibWeb/Forward.h>
LibWeb: Move Timer from DOM directory & namespace to HTML Timers are part of the HTML spec. :^) https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timers
2022-03-07 23:54:56 +01:00
namespace Web::HTML {
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
class Timer final : public JS::Cell {
JS_CELL(Timer, JS::Cell);
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
public:
LibWeb: Change HTML::Timer to store its owning window as a JS::Object Rather than being limited to a Window object, it will also need to be ownable by a WorkerGlobalScope.
2023-03-14 06:55:34 -04:00
static JS::NonnullGCPtr<Timer> create(JS::Object&, i32 milliseconds, Function<void()> callback, i32 id);
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
virtual ~Timer() override;
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
LibWeb: Implement setTimeout/setInterval with ESO according to the spec Our setInterval implementation currently crashes on DuckDuckGo when it's invoked with a string argument. In this path, we were creating a native function to evaluate and execute that string. That evaluation was always returning a Completion, but NativeFunction expects ThrowCompletionOr. The conversion from Completion to ThrowCompletionOr would fail a VERIFY because that conversion is only valid if the Completion is an error; but we would trigger this conversion even on success. This change re-implements setTimeout & setInterval in direct accordance with the spec. So we avoid making that NativeFunction altogether, and DDG can progress past its invocation to the timer. With this change, we also have other features we did not previously support, such as passing any number of arguments to the timers. This does not implement handling of nesting levels yet.
2022-03-04 10:41:12 -05:00
void start();
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
private:
LibWeb: Change HTML::Timer to store its owning window as a JS::Object Rather than being limited to a Window object, it will also need to be ownable by a WorkerGlobalScope.
2023-03-14 06:55:34 -04:00
Timer(JS::Object& window, i32 milliseconds, Function<void()> callback, i32 id);
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
virtual void visit_edges(Cell::Visitor&) override;
LibWeb+WebContent: Add abstraction layer for event loop and timers Instead of using Core::EventLoop and Core::Timer directly, LibWeb now goes through a Web::Platform abstraction layer instead. This will allow us to plug in Qt's event loop (and QTimer) over in Ladybird, to avoid having to deal with multiple event loops.
2022-09-07 20:30:31 +02:00
RefPtr<Platform::Timer> m_timer;
LibWeb: Change HTML::Timer to store its owning window as a JS::Object Rather than being limited to a Window object, it will also need to be ownable by a WorkerGlobalScope.
2023-03-14 06:55:34 -04:00
JS::NonnullGCPtr<JS::Object> m_window_or_worker_global_scope;
LibWeb: Make HTML::Timer GC-allocated These are the timers used internally by setTimeout() and setInterval().
2022-09-01 12:21:47 +02:00
Function<void()> m_callback;
LibWeb: Implement setTimeout/setInterval with ESO according to the spec Our setInterval implementation currently crashes on DuckDuckGo when it's invoked with a string argument. In this path, we were creating a native function to evaluate and execute that string. That evaluation was always returning a Completion, but NativeFunction expects ThrowCompletionOr. The conversion from Completion to ThrowCompletionOr would fail a VERIFY because that conversion is only valid if the Completion is an error; but we would trigger this conversion even on success. This change re-implements setTimeout & setInterval in direct accordance with the spec. So we avoid making that NativeFunction altogether, and DDG can progress past its invocation to the timer. With this change, we also have other features we did not previously support, such as passing any number of arguments to the timers. This does not implement handling of nesting levels yet.
2022-03-04 10:41:12 -05:00
i32 m_id { 0 };
LibWeb: Make DOM timers cancellable and stop leaking them This patch adds a Web::Timer object that represents a single timer registration made with window.setTimeout() or window.setInterval(). All live timers are owned by the DOM Window object. The timers can be stopped via clearTimeout() or clearInterval(). Note that those API's are actually interchangeable, but we have to support both.
2020-06-27 18:30:29 +02:00
};
}
Reference in a new issue Copy permalink