ladybird/Libraries/LibJS/Tests/operators/delete-local-variable.js

test("basic functionality", () => {
    let a = 5;
    var b = 6;
    c = 7;
    expect(delete a).toBeFalse();
    expect(a).toBe(5);

    expect(delete b).toBeFalse();
    expect(b).toBe(6);

    expect(delete c).toBeTrue();

    expect(() => {
        c;
    }).toThrowWithMessage(ReferenceError, "'c' is not defined");
});
LibJS: Support deleting local variables with operator delete To make this cleaner i also moved the logic into Reference::delete_. 2021-06-08 04:00:53 +03:00			`test("basic functionality", () => {`
			`let a = 5;`
LibJS: Make scoping follow the spec Before this we used an ad-hoc combination of references and 'variables' stored in a hashmap. This worked in most cases but is not spec like. Additionally hoisting, dynamically naming functions and scope analysis was not done properly. This patch fixes all of that by: - Implement BindingInitialization for destructuring assignment. - Implementing a new ScopePusher which tracks the lexical and var scoped declarations. This hoists functions to the top level if no lexical declaration name overlaps. Furthermore we do checking of redeclarations in the ScopePusher now requiring less checks all over the place. - Add methods for parsing the directives and statement lists instead of having that code duplicated in multiple places. This allows declarations to pushed to the appropriate scope more easily. - Remove the non spec way of storing 'variables' in DeclarativeEnvironment and make Reference follow the spec instead of checking both the bindings and 'variables'. - Remove all scoping related things from the Interpreter. And instead use environments as specified by the spec. This also includes fixing that NativeFunctions did not produce a valid FunctionEnvironment which could cause issues with callbacks and eval. All FunctionObjects now have a valid NewFunctionEnvironment implementation. - Remove execute_statements from Interpreter and instead use ASTNode::execute everywhere this simplifies AST.cpp as you no longer need to worry about which method to call. - Make ScopeNodes setup their own environment. This uses four different methods specified by the spec {Block, Function, Eval, Global}DeclarationInstantiation with the annexB extensions. - Implement and use NamedEvaluation where specified. Additionally there are fixes to things exposed by these changes to eval, {for, for-in, for-of} loops and assignment. Finally it also fixes some tests in test-js which where passing before but not now that we have correct behavior :^). 2021-09-22 12:44:56 +02:00			`var b = 6;`
			`c = 7;`
			`expect(delete a).toBeFalse();`
			`expect(a).toBe(5);`

			`expect(delete b).toBeFalse();`
			`expect(b).toBe(6);`

			`expect(delete c).toBeTrue();`
LibJS: Support deleting local variables with operator delete To make this cleaner i also moved the logic into Reference::delete_. 2021-06-08 04:00:53 +03:00
			`expect(() => {`
LibJS: Make scoping follow the spec Before this we used an ad-hoc combination of references and 'variables' stored in a hashmap. This worked in most cases but is not spec like. Additionally hoisting, dynamically naming functions and scope analysis was not done properly. This patch fixes all of that by: - Implement BindingInitialization for destructuring assignment. - Implementing a new ScopePusher which tracks the lexical and var scoped declarations. This hoists functions to the top level if no lexical declaration name overlaps. Furthermore we do checking of redeclarations in the ScopePusher now requiring less checks all over the place. - Add methods for parsing the directives and statement lists instead of having that code duplicated in multiple places. This allows declarations to pushed to the appropriate scope more easily. - Remove the non spec way of storing 'variables' in DeclarativeEnvironment and make Reference follow the spec instead of checking both the bindings and 'variables'. - Remove all scoping related things from the Interpreter. And instead use environments as specified by the spec. This also includes fixing that NativeFunctions did not produce a valid FunctionEnvironment which could cause issues with callbacks and eval. All FunctionObjects now have a valid NewFunctionEnvironment implementation. - Remove execute_statements from Interpreter and instead use ASTNode::execute everywhere this simplifies AST.cpp as you no longer need to worry about which method to call. - Make ScopeNodes setup their own environment. This uses four different methods specified by the spec {Block, Function, Eval, Global}DeclarationInstantiation with the annexB extensions. - Implement and use NamedEvaluation where specified. Additionally there are fixes to things exposed by these changes to eval, {for, for-in, for-of} loops and assignment. Finally it also fixes some tests in test-js which where passing before but not now that we have correct behavior :^). 2021-09-22 12:44:56 +02:00			`c;`
			`}).toThrowWithMessage(ReferenceError, "'c' is not defined");`
LibJS: Support deleting local variables with operator delete To make this cleaner i also moved the logic into Reference::delete_. 2021-06-08 04:00:53 +03:00			`});`