Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Meta/lint-ci.sh

62 lines
1.6 KiB
Bash
Raw Normal View History

Meta: Get building on NixOS (#5005)
2021-01-23 05:44:05 +13:00
#!/usr/bin/env bash
Meta: Add script that runs all lints
2020-11-03 20:11:48 +01:00
set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1
Meta: Print failed pre-commit steps in bold This makes them easier to find, especially for colorblind people.
2024-11-16 14:48:55 +01:00
BOLD_RED='\033[0;1;31m'
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 10:13:24 -07:00
GREEN='\033[0;32m'
NC='\033[0m' # No Color
FAILURES=0
set +e
Meta: Add script that runs all lints
2020-11-03 20:11:48 +01:00
for cmd in \
Meta: Always check completeness of ALL_THE_DEBUG_MACROS
2020-11-28 18:16:38 +01:00
Meta/check-debug-flags.sh \
Meta: Make CI enforce doctype in test cases This currently does not enforce it on Layout tests, even though it seems most necessary there. This is to speed up the review on this PR due to an excessive amount of layout tests that would need rebaselining if DOCTYPEs were added to them.
2025-03-18 19:35:10 +01:00
Meta/check-html-doctype.py \
Meta: Add script for checking WebIDL files This adds a new script for linting WebIDL files, and adds it to the set of scripts Meta/lint-ci.sh runs. Initially, this script does just one thing: normalizes IDL definition lines so they start with four spaces.
2024-09-10 16:10:05 +09:00
Meta/check-idl-files.py \
Meta: Rewrite the check-newlines-at-eof script in python The bash version takes around 15 seconds to run; that is way too slow. This python3 version should take less than one second to run. :^) Also, the script will now also check .py files and .txt CMake files.
2021-01-03 19:31:44 +01:00
Meta/check-newlines-at-eof.py \
Meta: Add a PNG size check to CI and pre-commit checks This uses optipng to check how much size can be reduced on PNG files. If that's more than 2 KiB for at least one file, the check fails. As with other checks, it doesn't run if optipng is not installed.
2022-06-18 13:17:52 +02:00
Meta/check-png-sizes.sh \
Meta: Reimplement license checker in python On my machine, this script took about 3.4 seconds, and was responsible for essentially all of the time taken by the precommit hook. The script is a faithful 1:1 reimplementation, even the regexes are identical. And yet, it takes about 0.02 seconds, making the pre-commit hook lightning fast again. Apparently python is just faster in this case. Fun fact: - Just reading all ~4000 files took bash about 1.2 seconds - Checking the license took another 1.8 seconds in total - Checking for math.h took another 0.4 seconds in total - Checking for '#pragma once' took another 0.4 seconds in total The timing is highly load-dependent, so they don't exactly add up to 3.4 seconds. However, it's good enough to determine that bash is no longer fit for the purpose of this script.
2021-10-26 23:49:28 +02:00
Meta/check-style.py \
Meta: Add script that runs all lints
2020-11-03 20:11:48 +01:00
Meta/lint-executable-resources.sh \
Meta: Add gn linter This just calls ``gn format`` on any .gn or .gni files, but it matches the pattern of the other linters.
2023-07-09 17:13:07 -06:00
Meta/lint-gn.sh \
Meta: Add flake8 to lint python files
2021-01-03 19:08:26 -07:00
Meta/lint-prettier.sh \
Meta: Remove unused and outdated lint-missing-resources.sh lint This was apparently never used by anyone except me, and currently fails silently. The script originally allowed easy inspection of potentially missing resources, but that seems no longer useful. Even after restoring the script to a working state, I found nothing with it. A somewhat usable version might be available at https://github.com/BenWiederhake/serenity/tree/historic/lint-missing-resources.sh However, there seems to be no interest in the script, so it is better to remove it.
2022-09-12 23:11:54 +02:00
Meta/lint-python.sh \
Meta/lint-shell-scripts.sh; do
Meta+Utilities: Make pre-commit checks significantly less verbose When markdown-check is built, it outputs hundreds of lines of "ignoring this and that link because reasons". This is extremely not helpful when trying to figure out exactly which check failed on your commit. Also remove the timing numbers from lint-ci.sh These are just noise and also don't help to figure out which pre-commit check failed. Ideally the output on fail should be "[OK]: Check A" for all the passing checks and "[FAIL] Check N" with the required context for the failed check.
2023-07-25 11:52:06 -06:00
if "${cmd}" "$@"; then
Meta: Update lint-{clang-format,shell-scripts}.sh to take a list of files This should speed up pre-commit a bit as only files that are staged will be processed, and clang-format and shellcheck are only invoked once, not for every file. When no arguments are given (e.g. on CI), it still uses 'git ls-files'.
2020-12-27 15:34:06 +01:00
echo -e "[${GREEN}OK${NC}]: ${cmd}"
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 10:13:24 -07:00
else
Meta: Print failed pre-commit steps in bold This makes them easier to find, especially for colorblind people.
2024-11-16 14:48:55 +01:00
echo -e "[${BOLD_RED}FAIL${NC}]: ${cmd}"
Meta: Update lint-{clang-format,shell-scripts}.sh to take a list of files This should speed up pre-commit a bit as only files that are staged will be processed, and clang-format and shellcheck are only invoked once, not for every file. When no arguments are given (e.g. on CI), it still uses 'git ls-files'.
2020-12-27 15:34:06 +01:00
((FAILURES+=1))
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 10:13:24 -07:00
fi
Meta: Add script that runs all lints
2020-11-03 20:11:48 +01:00
done
Meta+Lagom: Enable CMAKE_BUILD_WITH_INSTALL_RPATH On macOS, CMake incorrectly tries to add and/or remove rpaths from files that it has already processed when it performs installation. Setting the rpaths during the build process ensures that they are only set once, and as a bonus, makes installation slightly more performant. Fixes #10055.
2023-03-18 19:23:35 +04:00
if [ -x ./Build/lagom/bin/IPCMagicLinter ]; then
Meta+Utilities: Make pre-commit checks significantly less verbose When markdown-check is built, it outputs hundreds of lines of "ignoring this and that link because reasons". This is extremely not helpful when trying to figure out exactly which check failed on your commit. Also remove the timing numbers from lint-ci.sh These are just noise and also don't help to figure out which pre-commit check failed. Ideally the output on fail should be "[OK]: Check A" for all the passing checks and "[FAIL] Check N" with the required context for the failed check.
2023-07-25 11:52:06 -06:00
if { git ls-files '*.ipc' | xargs ./Build/lagom/bin/IPCMagicLinter; }; then
Meta: Run IPC magic number linter during CI and pre-commit
2021-11-01 17:20:54 +01:00
echo -e "[${GREEN}OK${NC}]: IPCMagicLinter (in Meta/lint-ci.sh)"
else
Meta: Print failed pre-commit steps in bold This makes them easier to find, especially for colorblind people.
2024-11-16 14:48:55 +01:00
echo -e "[${BOLD_RED}FAIL${NC}]: IPCMagicLinter (in Meta/lint-ci.sh)"
Meta: Run IPC magic number linter during CI and pre-commit
2021-11-01 17:20:54 +01:00
((FAILURES+=1))
fi
else
echo -e "[${GREEN}SKIP${NC}]: IPCMagicLinter (in Meta/lint-ci.sh)"
fi
Meta: Replace lint-clang-format.sh with lint-clang-format.py Currently you need to use Git Bash or alternative bash implementations to fully run the pre-commit checks on Windows. This will now allow for formatting changes without bash.
2025-08-09 14:52:40 -07:00
if Meta/lint-clang-format.py --overwrite-inplace "$@" && git diff --exit-code -- ':*.cpp' ':*.h' ':*.mm'; then
echo -e "[${GREEN}OK${NC}]: Meta/lint-clang-format.py"
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 10:13:24 -07:00
else
Meta: Replace lint-clang-format.sh with lint-clang-format.py Currently you need to use Git Bash or alternative bash implementations to fully run the pre-commit checks on Windows. This will now allow for formatting changes without bash.
2025-08-09 14:52:40 -07:00
echo -e "[${BOLD_RED}FAIL${NC}]: Meta/lint-clang-format.py"
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 10:13:24 -07:00
((FAILURES+=1))
fi
Meta: Add swift-format linter script swift-format is available in the Xcode 16 Beta and homebrew. We will need some extra docs to tell Linux developers how to get it on their distribution. This also makes use of the fact that you can pass git diff a colon delimited pattern to include ':*pattern' or exclude ':!*pattern' matching files, which is pretty neat.
2024-08-28 22:36:14 -06:00
if Meta/lint-swift.sh "$@" && git diff --exit-code -- ':*.swift'; then
echo -e "[${GREEN}OK${NC}]: Meta/lint-swift.sh"
else
Meta: Print failed pre-commit steps in bold This makes them easier to find, especially for colorblind people.
2024-11-16 14:48:55 +01:00
echo -e "[${BOLD_RED}FAIL${NC}]: Meta/lint-swift.sh"
Meta: Add swift-format linter script swift-format is available in the Xcode 16 Beta and homebrew. We will need some extra docs to tell Linux developers how to get it on their distribution. This also makes use of the fact that you can pass git diff a colon delimited pattern to include ':*pattern' or exclude ':!*pattern' matching files, which is pretty neat.
2024-08-28 22:36:14 -06:00
((FAILURES+=1))
fi
Meta: Make lint-shell-scripts.sh happy `${FAILURES}` -> `"${FAILURES}"`
2020-12-26 11:56:32 +03:30
exit "${FAILURES}"
Reference in a new issue Copy permalink