Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Userland/Applications/Browser/InspectorWidget.cpp

68 lines
1.9 KiB
C++
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
Browser: Remove residual InProcessWebView code from DOM Inspector This is no longer useful, and has to go before I can change how the Models work.
2021-09-02 12:01:19 +01:00
* Copyright (c) 2021, Sam Atkins <atkinssj@gmail.com>
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 01:24:48 -07:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 09:38:21 +01:00
*/
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 14:55:19 +01:00
#include "InspectorWidget.h"
LibGUI: Remove leading G from filenames
2020-02-06 20:33:02 +01:00
#include <LibGUI/BoxLayout.h>
#include <LibGUI/Splitter.h>
Browser: Move InspectorWidget into the Browser namespace
2020-05-08 21:38:30 +02:00
#include <LibGUI/TabWidget.h>
LibGUI: Remove leading G from filenames
2020-02-06 20:33:02 +01:00
#include <LibGUI/TableView.h>
#include <LibGUI/TreeView.h>
LibWeb: Rename directory LibHTML => LibWeb Let's rename this to LibWeb since it aims to provide more parts of the web platform than just HTML. :^)
2020-03-07 10:32:51 +01:00
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Element.h>
#include <LibWeb/DOMTreeModel.h>
#include <LibWeb/StylePropertiesModel.h>
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 14:55:19 +01:00
Browser: Move InspectorWidget into the Browser namespace
2020-05-08 21:38:30 +02:00
namespace Browser {
Browser: Remove residual InProcessWebView code from DOM Inspector This is no longer useful, and has to go before I can change how the Models work.
2021-09-02 12:01:19 +01:00
void InspectorWidget::set_inspected_node(GUI::ModelIndex const)
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 22:30:11 +02:00
{
Browser: Remove residual InProcessWebView code from DOM Inspector This is no longer useful, and has to go before I can change how the Models work.
2021-09-02 12:01:19 +01:00
// FIXME: Handle this for OutOfProcessWebView
Browser: Add "Inspect Element" to context menu :^) This opens the DOM Inspector window, with the target element already selected. (If the window is already open, it just selects the element.) Note that this only applies to single-process mode for now. In OOP mode, the "inspect element" action is disabled.
2021-08-17 17:00:27 +01:00
}
LibGUI: Remove parent parameter to GUI::Widget constructor
2020-02-23 12:07:13 +01:00
InspectorWidget::InspectorWidget()
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 14:55:19 +01:00
{
LibGUI: Use set_layout<LayoutType>() in lots of client code
2020-03-04 09:43:54 +01:00
set_layout<GUI::VerticalBoxLayout>();
LibCore: Make Core::Object::add<ChildType> return a ChildType& Since the returned object is now owned by the callee object, we can simply vend a ChildType&. This allows us to use "." instead of "->" at the call site, which is quite nice. :^)
2020-03-04 19:07:55 +01:00
auto& splitter = add<GUI::VerticalSplitter>();
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 22:30:11 +02:00
auto& top_tab_widget = splitter.add<GUI::TabWidget>();
m_dom_tree_view = top_tab_widget.add_tab<GUI::TreeView>("DOM");
LibGUI/AbstractView: Remove `on_selection` Since the introduction of multi-select, we have had both `on_selection` and `on_selection_change`, the latter of which was only invoked when a change in selection came in through the model. This removes `AbstractView::on_selection` and replaces it usage with the more explicit `on_selection_change` everywhere.
2021-05-25 22:48:43 +02:00
m_dom_tree_view->on_selection_change = [this] {
const auto& index = m_dom_tree_view->selection().first();
LibWeb+Browser: Support DOM Inspector for OutOfProcessWebView This introduces a new DOMTreeJSONModel, which provides the Model for the InspectorWidget when the Browser is running using the OutOfProcessWebView. This Model is constructed with a JSON object received via IPC from the WebContentServer.
2021-06-07 22:21:16 +01:00
set_inspected_node(index);
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 22:30:11 +02:00
};
m_layout_tree_view = top_tab_widget.add_tab<GUI::TreeView>("Layout");
LibGUI/AbstractView: Remove `on_selection` Since the introduction of multi-select, we have had both `on_selection` and `on_selection_change`, the latter of which was only invoked when a change in selection came in through the model. This removes `AbstractView::on_selection` and replaces it usage with the more explicit `on_selection_change` everywhere.
2021-05-25 22:48:43 +02:00
m_layout_tree_view->on_selection_change = [this] {
const auto& index = m_layout_tree_view->selection().first();
LibWeb+Browser: Support DOM Inspector for OutOfProcessWebView This introduces a new DOMTreeJSONModel, which provides the Model for the InspectorWidget when the Browser is running using the OutOfProcessWebView. This Model is constructed with a JSON object received via IPC from the WebContentServer.
2021-06-07 22:21:16 +01:00
set_inspected_node(index);
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 14:55:19 +01:00
};
LibGUI: Add helper for constructing new TabWidget tabs This patch adds the following convenience helper: auto tab_widget = GUI::TabWidget::construct(); auto my_widget = tab_widget->add_tab<GUI::Widget>("My tab", ...); The above is equivalent to: auto tab_widget = GUI::TabWidget::construct(); auto my_widget = GUI::Widget::construct(...); tab_widget->add_widget("My tab", my_widget);
2020-02-23 12:23:48 +01:00
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 22:30:11 +02:00
auto& bottom_tab_widget = splitter.add<GUI::TabWidget>();
LibGUI: Add helper for constructing new TabWidget tabs This patch adds the following convenience helper: auto tab_widget = GUI::TabWidget::construct(); auto my_widget = tab_widget->add_tab<GUI::Widget>("My tab", ...); The above is equivalent to: auto tab_widget = GUI::TabWidget::construct(); auto my_widget = GUI::Widget::construct(...); tab_widget->add_widget("My tab", my_widget);
2020-02-23 12:23:48 +01:00
LibWeb+Browser: Add a barebones LayoutTreeModel to the inspector window This allows you to inspect the layout tree, along side the DOM tree. It will need more functionality to be truly useful, but it's a start.
2020-06-12 22:30:11 +02:00
m_style_table_view = bottom_tab_widget.add_tab<GUI::TableView>("Styles");
m_computed_style_table_view = bottom_tab_widget.add_tab<GUI::TableView>("Computed");
Browser+LibHTML: Add resolved element style to the DOM inspector When selecting an element in the browser's DOM inspector, we now also show the resolved CSS properties (and their values) for that element. Since the inspector was growing a bit more complex, I moved it out of the "show inspector" action callback and into its own class. In the future, we will probably want to migrate the inspector down to LibHTML to make it accessible to other clients of the library, but for now we can keep working on it inside Browser. :^)
2020-01-02 14:55:19 +01:00
}
InspectorWidget::~InspectorWidget()
{
}
LibWeb+Browser: Support DOM Inspector for OutOfProcessWebView This introduces a new DOMTreeJSONModel, which provides the Model for the InspectorWidget when the Browser is running using the OutOfProcessWebView. This Model is constructed with a JSON object received via IPC from the WebContentServer.
2021-06-07 22:21:16 +01:00
void InspectorWidget::set_dom_json(String json)
{
if (m_dom_json.has_value() && m_dom_json.value() == json)
return;
m_dom_json = json;
LibWeb: Replace unused DOMTreeModel with DOMTreeJSONModel The direct-Document-access DOMTreeModel is no longer used, since the DOM Inspector has to access the Document remotely over IPC. This commit removes it, and renames DOMTreeJSONModel to take its place, since it no longer has to differentiate itself from the non-JSON one. In case that didn't make sense: - Delete DOMTreeModel - Rename DOMTreeJSONModel -> DOMTreeModel
2021-08-24 17:04:30 +01:00
m_dom_tree_view->set_model(Web::DOMTreeModel::create(m_dom_json->view()));
LibWeb+Browser: Support DOM Inspector for OutOfProcessWebView This introduces a new DOMTreeJSONModel, which provides the Model for the InspectorWidget when the Browser is running using the OutOfProcessWebView. This Model is constructed with a JSON object received via IPC from the WebContentServer.
2021-06-07 22:21:16 +01:00
// FIXME: Support the LayoutTreeModel
// m_layout_tree_view->set_model(Web::LayoutTreeModel::create(*document));
}
Browser: Move InspectorWidget into the Browser namespace
2020-05-08 21:38:30 +02:00
}
Reference in a new issue Copy permalink