Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Fix WebGL getError

Browse source 
getError was just calling out to glGetError and never checking our
error value that we were maintaining ourselves.
This commit is contained in:
Undefine 2025-11-05 20:25:48 +01:00 • committed by Andreas Kling
parent e7aeb71d29
commit 044ac2dd28
Notes: github-actions[bot] 2025-11-06 18:04:36 +00:00
3 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/WebGL/WebGLRenderingContextBase.cpp
View file

@ -195,8 +195,23 @@ Optional<WebGLRenderingContextBase::ConvertedTexture> WebGLRenderingContextBase:
};
}
// TODO: The glGetError spec allows for queueing errors which is something we should probably do, for now
// this just keeps track of one error which is also fine by the spec
GLenum WebGLRenderingContextBase::get_error_value()
{
if (m_error == GL_NO_ERROR)
return glGetError();
auto error = m_error;
m_error = GL_NO_ERROR;
return error;
}
void WebGLRenderingContextBase::set_error(GLenum error)
{
if (m_error != GL_NO_ERROR)
return;
auto context_error = glGetError();
if (context_error != GL_NO_ERROR)
m_error = context_error;

1
Libraries/LibWeb/WebGL/WebGLRenderingContextBase.h
View file

@ -138,6 +138,7 @@ protected:
return result;
}
GLenum get_error_value();
void set_error(GLenum error);
// UNPACK_FLIP_Y_WEBGL of type boolean

2
Libraries/LibWeb/WebGL/WebGLRenderingContextImpl.cpp
View file

@ -1535,7 +1535,7 @@ JS::Value WebGLRenderingContextImpl::get_parameter(WebIDL::UnsignedLong pname)
WebIDL::UnsignedLong WebGLRenderingContextImpl::get_error()
{
m_context->make_current();
return glGetError();
return get_error_value();
}
JS::Value WebGLRenderingContextImpl::get_program_parameter(GC::Root<WebGLProgram> program, WebIDL::UnsignedLong pname)