Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Use document's viewport when resolving lengths in media queries

Browse source 
Previously we would always use the window's viewport which was incorrect
if we were within an iframe.

This is likely applicable to all uses of
`Length::ResolutionContext::for_window`.
This commit is contained in:
Callum Law 2025-10-07 00:54:19 +13:00 • committed by Sam Atkins
parent c33be71df9
commit 05c336ea4e
Notes: github-actions[bot] 2025-10-07 09:34:36 +00:00
23 changed files with 198 additions and 83 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/CSS/Length.h
View file

@ -55,7 +55,10 @@ public:
FlyString unit_name() const { return CSS::to_string(m_unit); }
struct ResolutionContext {
[[nodiscard]] static ResolutionContext for_document(DOM::Document const&);
[[nodiscard]] static ResolutionContext for_element(DOM::AbstractElement const&);
// FIXME: Anywhere we use this we probably want to use `for_document` instead since this uses the window's
// viewport rather than the documents which can differ e.g. with iframes.
[[nodiscard]] static ResolutionContext for_window(HTML::Window const&);
[[nodiscard]] static ResolutionContext for_layout_node(Layout::Node const&);