mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	LibWeb: Remove some useless URL validity checks
It is not possible for a URL here to have a value and be invalid.
This commit is contained in:
		
							parent
							
								
									dc2b0e17bf
								
							
						
					
					
						commit
						0b8bcdcbd3
					
				
				
				Notes:
				
					github-actions[bot]
				
				2025-02-19 13:03:07 +00:00 
				
			
			Author: https://github.com/shannonbooth
Commit: 0b8bcdcbd3
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3609
Reviewed-by: https://github.com/trflynn89
			
					 3 changed files with 0 additions and 9 deletions
				
			
		|  | @ -186,8 +186,6 @@ WebIDL::ExceptionOr<Optional<URL::URL>> resolve_imports_match(ByteString const& | |||
|                 return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() }; | ||||
| 
 | ||||
|             // 2. Assert: resolutionResult is a URL.
 | ||||
|             VERIFY(resolution_result->is_valid()); | ||||
| 
 | ||||
|             // 3. Return resolutionResult.
 | ||||
|             return resolution_result; | ||||
|         } | ||||
|  | @ -207,8 +205,6 @@ WebIDL::ExceptionOr<Optional<URL::URL>> resolve_imports_match(ByteString const& | |||
|                 return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() }; | ||||
| 
 | ||||
|             // 2. Assert: resolutionResult is a URL.
 | ||||
|             VERIFY(resolution_result->is_valid()); | ||||
| 
 | ||||
|             // 3. Let afterPrefix be the portion of normalizedSpecifier after the initial specifierKey prefix.
 | ||||
|             // FIXME: Clarify if this is meant by the portion after the initial specifierKey prefix.
 | ||||
|             auto after_prefix = normalized_specifier.substring(specifier_key.length()); | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Shannon Booth
						Shannon Booth