Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Have JS::Lexer take a JS::SourceCode as input

Browse source 
This moves the responsibility of setting up a SourceCode object to the
users of JS::Lexer.

This means Lexer and Parser are free to use string views into the
SourceCode internally while working.

It also means Lexer no longer has to think about anything other than
UTF-16 (or ASCII) inputs. So the unit test for parsing various invalid
UTF-8 sequences is deleted here.
This commit is contained in:
Andreas Kling 2025-11-08 21:21:52 +01:00 • committed by Andreas Kling
parent 9ca25e55d7
commit 0dacc94edd
Notes: github-actions[bot] 2025-11-09 11:15:22 +00:00
16 changed files with 59 additions and 227 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/SourceTextModule.cpp
View file

@ -132,7 +132,7 @@ void SourceTextModule::visit_edges(Cell::Visitor& visitor)
Result<GC::Ref<SourceTextModule>, Vector<ParserError>> SourceTextModule::parse(StringView source_text, Realm& realm, StringView filename, Script::HostDefined* host_defined)
{
// 1. Let body be ParseText(sourceText, Module).
auto parser = Parser(Lexer(source_text, filename), Program::Type::Module);
auto parser = Parser(Lexer(SourceCode::create(String::from_utf8(filename).release_value_but_fixme_should_propagate_errors(), Utf16String::from_utf8(source_text))), Program::Type::Module);
auto body = parser.parse_program();
// 2. If body is a List of errors, return body.