mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-12-08 06:09:58 +00:00
Everywhere: Clean up AD-HOC and FIXME comments without colons
This commit is contained in:
parent
edccb92da7
commit
100f37995f
Notes:
github-actions[bot]
2025-11-14 08:18:37 +00:00
Author: https://github.com/Psychpsyo
Commit: 100f37995f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6810
27 changed files with 36 additions and 36 deletions
|
|
@ -266,7 +266,7 @@ Utf16String FormAssociatedElement::validation_message() const
|
|||
if (!is_candidate_for_constraint_validation() || satisfies_its_constraints())
|
||||
return {};
|
||||
|
||||
// FIXME
|
||||
// FIXME:
|
||||
// 2. Return a suitably localized message that the user agent would show the user if this were the only form
|
||||
// control with a validity constraint problem. If the user agent would not actually show a textual message in
|
||||
// such a situation (e.g., it would show a graphical cue instead), then return a suitably localized message that
|
||||
|
|
|
|||
|
|
@ -40,7 +40,7 @@ void HTMLButtonElement::adjust_computed_style(CSS::ComputedProperties& style)
|
|||
// No-op
|
||||
} else if (display.is_inline_outside()) {
|
||||
// Otherwise, if the computed value of 'display' is a value such that the outer display type is 'inline', then behave as 'inline-block'.
|
||||
// AD-HOC https://github.com/whatwg/html/issues/11857
|
||||
// AD-HOC: See https://github.com/whatwg/html/issues/11857
|
||||
style.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::InlineBlock)));
|
||||
} else {
|
||||
// Otherwise, behave as 'flow-root'.
|
||||
|
|
|
|||
|
|
@ -455,8 +455,8 @@ void HTMLDialogElement::run_dialog_focusing_steps()
|
|||
// 2. Let control be null
|
||||
GC::Ptr<Element> control = nullptr;
|
||||
|
||||
// FIXME 3. If subject has the autofocus attribute, then set control to subject.
|
||||
// FIXME 4. If control is null, then set control to the focus delegate of subject.
|
||||
// FIXME: 3. If subject has the autofocus attribute, then set control to subject.
|
||||
// FIXME: 4. If control is null, then set control to the focus delegate of subject.
|
||||
|
||||
// 5. If control is null, then set control to subject.
|
||||
if (!control)
|
||||
|
|
|
|||
|
|
@ -1036,7 +1036,7 @@ void HTMLImageElement::upgrade_pending_request_to_current_request()
|
|||
|
||||
void HTMLImageElement::handle_failed_fetch()
|
||||
{
|
||||
// AD-HOC
|
||||
// AD-HOC: This should be closer to the spec
|
||||
dispatch_event(DOM::Event::create(realm(), HTML::EventNames::error));
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -126,9 +126,9 @@ WebIDL::ExceptionOr<void> MessagePort::transfer_receiving_steps(HTML::TransferDa
|
|||
// 1. Set value's has been shipped flag to true.
|
||||
m_has_been_shipped = true;
|
||||
|
||||
// FIXME 2. Move all the tasks that are to fire message events in dataHolder.[[PortMessageQueue]] to the port message queue of value,
|
||||
// if any, leaving value's port message queue in its initial disabled state, and, if value's relevant global object is a Window,
|
||||
// associating the moved tasks with value's relevant global object's associated Document.
|
||||
// 2. FIXME: Move all the tasks that are to fire message events in dataHolder.[[PortMessageQueue]] to the port message queue of value,
|
||||
// if any, leaving value's port message queue in its initial disabled state, and, if value's relevant global object is a Window,
|
||||
// associating the moved tasks with value's relevant global object's associated Document.
|
||||
|
||||
// 3. If dataHolder.[[RemotePort]] is not null, then entangle dataHolder.[[RemotePort]] and value.
|
||||
// (This will disentangle dataHolder.[[RemotePort]] from the original port that was transferred.)
|
||||
|
|
|
|||
|
|
@ -650,7 +650,7 @@ Vector<GC::Ref<SessionHistoryEntry>>& Navigable::get_session_history_entries() c
|
|||
// 1. Let traversable be navigable's traversable navigable.
|
||||
auto traversable = traversable_navigable();
|
||||
|
||||
// FIXME 2. Assert: this is running within traversable's session history traversal queue.
|
||||
// FIXME: 2. Assert: this is running within traversable's session history traversal queue.
|
||||
|
||||
// 3. If navigable is traversable, return traversable's session history entries.
|
||||
if (this == traversable)
|
||||
|
|
@ -1009,7 +1009,7 @@ static void perform_navigation_params_fetch(JS::Realm& realm, GC::Ref<Navigation
|
|||
// using opener policy and sandbox the result of navigating to that response.
|
||||
}
|
||||
|
||||
// 13. FIXME If response is not a network error, navigable is a child navigable, and the result of performing a cross-origin resource policy check
|
||||
// 13. FIXME: If response is not a network error, navigable is a child navigable, and the result of performing a cross-origin resource policy check
|
||||
// with navigable's container document's origin, navigable's container document's relevant settings object, request's destination, response,
|
||||
// and true is blocked, then set response to a network error and break.
|
||||
// NOTE: Here we're running the cross-origin resource policy check against the parent navigable rather than navigable itself
|
||||
|
|
|
|||
|
|
@ -276,7 +276,7 @@ GC::Ref<WebIDL::Promise> OffscreenCanvas::convert_to_blob(Optional<ImageEncodeOp
|
|||
|
||||
// FIXME: 1. If the value of this OffscreenCanvas object's [[Detached]] internal slot is set to true, then return a promise rejected with an "InvalidStateError" DOMException.
|
||||
|
||||
// FIXME 2. If this OffscreenCanvas object's context mode is 2d and the rendering context's output bitmap's origin-clean flag is set to false, then return a promise rejected with a "SecurityError" DOMException.
|
||||
// FIXME: 2. If this OffscreenCanvas object's context mode is 2d and the rendering context's output bitmap's origin-clean flag is set to false, then return a promise rejected with a "SecurityError" DOMException.
|
||||
|
||||
auto size = bitmap_size_for_canvas();
|
||||
|
||||
|
|
|
|||
|
|
@ -4754,7 +4754,7 @@ void HTMLParser::process_using_the_rules_for_foreign_content(HTMLToken& token)
|
|||
// Insert a foreign element for the token, with the adjusted current node's namespace and false.
|
||||
(void)insert_foreign_element(token, adjusted_current_node()->namespace_uri(), OnlyAddToElementStack::No);
|
||||
|
||||
// AD-HOC we don't want to execute script elements just by adding data to it
|
||||
// AD-HOC: we don't want to execute script elements just by adding data to it
|
||||
if (token.tag_name() == SVG::TagNames::script && current_node()->namespace_uri() == Namespace::SVG) {
|
||||
auto& script_element = as<SVG::SVGScriptElement>(*current_node());
|
||||
script_element.set_parser_inserted({});
|
||||
|
|
|
|||
|
|
@ -380,7 +380,7 @@ static void deactivate_a_document_for_cross_document_navigation(GC::Ref<DOM::Doc
|
|||
|
||||
// 5. If potentiallyTriggerViewTransition is false, then:
|
||||
if (!potentially_trigger_view_transition) {
|
||||
// FIXME 1. Let firePageSwapBeforeUnload be the following step
|
||||
// FIXME: 1. Let firePageSwapBeforeUnload be the following step
|
||||
// 1. Fire the pageswap event given displayedDocument, targetEntry, navigationType, and null.
|
||||
|
||||
// 2. Set the ongoing navigation for navigable to null.
|
||||
|
|
|
|||
|
|
@ -557,7 +557,7 @@ i32 WindowOrWorkerGlobalScopeMixin::run_timer_initialization_steps(TimerHandler
|
|||
|
||||
auto& vm = this_impl().vm();
|
||||
|
||||
// FIXME 8. Let uniqueHandle be null.
|
||||
// FIXME: 8. Let uniqueHandle be null.
|
||||
|
||||
// 9. Let task be a task that runs the following substeps:
|
||||
auto task = GC::create_function(vm.heap(), Function<void()>([this, handler = move(handler), timeout, arguments = move(arguments), repeat, id, initiating_script, previous_id, &vm, &realm]() {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue