Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Everywhere: Remove unused private fields

Browse source 
This commit removes the -Wno-unusued-private-field flag, thus
reenabling the warning. Unused field were either removed or marked
[[maybe_unused]] when unsure.
This commit is contained in:
R-Goc 2025-04-04 10:58:41 +02:00 • committed by Andreas Kling
parent e43bb1410c
commit 28d5d982ce
Notes: github-actions[bot] 2025-04-04 10:41:04 +00:00
13 changed files with 15 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibMedia/Color/ColorConverter.cpp
View file

@ -152,7 +152,7 @@ DecoderErrorOr<ColorConverter> ColorConverter::create(u8 bit_depth, CodingIndepe
bool should_skip_color_remapping = output_cicp.color_primaries() == input_cicp.color_primaries() && output_cicp.transfer_characteristics() == input_cicp.transfer_characteristics();
FloatMatrix4x4 input_conversion_matrix = color_conversion_matrix * range_scaling_matrix * integer_scaling_matrix;
return ColorConverter(bit_depth, input_cicp, should_skip_color_remapping, should_tonemap, input_conversion_matrix, to_linear_lookup_table, color_primaries_matrix_4x4, to_non_linear_lookup_table);
return ColorConverter(input_cicp, should_skip_color_remapping, should_tonemap, input_conversion_matrix, to_linear_lookup_table, color_primaries_matrix_4x4, to_non_linear_lookup_table);
}
}

6
Libraries/LibMedia/Color/ColorConverter.h
View file

@ -247,9 +247,8 @@ private:
static constexpr size_t to_linear_size = 64;
static constexpr size_t to_non_linear_size = 64;
ColorConverter(u8 bit_depth, CodingIndependentCodePoints cicp, bool should_skip_color_remapping, bool should_tonemap, FloatMatrix4x4 input_conversion_matrix, InterpolatedLookupTable<to_linear_size> to_linear_lookup, FloatMatrix4x4 color_space_conversion_matrix, InterpolatedLookupTable<to_non_linear_size> to_non_linear_lookup)
: m_bit_depth(bit_depth)
, m_cicp(cicp)
ColorConverter(CodingIndependentCodePoints cicp, bool should_skip_color_remapping, bool should_tonemap, FloatMatrix4x4 input_conversion_matrix, InterpolatedLookupTable<to_linear_size> to_linear_lookup, FloatMatrix4x4 color_space_conversion_matrix, InterpolatedLookupTable<to_non_linear_size> to_non_linear_lookup)
: m_cicp(cicp)
, m_should_skip_color_remapping(should_skip_color_remapping)
, m_should_tonemap(should_tonemap)
, m_input_conversion_matrix(input_conversion_matrix)
@ -259,7 +258,6 @@ private:
{
}
u8 m_bit_depth;
CodingIndependentCodePoints m_cicp;
bool m_should_skip_color_remapping;
bool m_should_tonemap;

1
Libraries/LibMedia/PlaybackManager.h
View file

@ -179,7 +179,6 @@ private:
VideoFrameQueue m_frame_queue;
RefPtr<Core::Timer> m_state_update_timer;
unsigned m_decoding_buffer_time_ms = 16;
RefPtr<Threading::Thread> m_decode_thread;
NonnullOwnPtr<VideoDecoder> m_decoder;