Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Set AudioTrack and VideoTrack fields according to spec

Browse source 
The two classes now inherit from a common base MediaTrackBase, to
deduplicate the attributes that are shared between the two.

The integer ID from the container is used for each track's id
attribute.

The kind attribute is set to "main" or "translation" according to:
https://dev.w3.org/html5/html-sourcing-inband-tracks/

The label attribute is set to the human-readable name of the track, if
one is present.

The language attribute is set to a BCP 47 language tag, if one can be
parsed successfully.
This commit is contained in:
Zaggy1024 2025-09-30 17:18:32 -05:00 • committed by Jelle Raaijmakers
parent 29ab9c5fd5
commit 3d0b8cc30c
Notes: github-actions[bot] 2025-10-28 00:34:44 +00:00
8 changed files with 148 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

57
Libraries/LibWeb/HTML/MediaTrackBase.h Normal file
View file

@ -0,0 +1,57 @@
/*
* Copyright (c) 2025, Gregory Bertilson <gregory@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibMedia/Track.h>
#include <LibWeb/Bindings/PlatformObject.h>
namespace Web::HTML {
class MediaTrackBase : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(MediaTrackBase, Bindings::PlatformObject);
public:
virtual ~MediaTrackBase() override;
HTMLMediaElement& media_element() const { return *m_media_element; }
Media::Track const& track_in_playback_manager() const { return m_track_in_playback_manager; }
Utf16String const& id() const { return m_id; }
Utf16String const& kind() const { return m_kind; }
void set_kind(Utf16String const& kind) { m_kind = kind; }
Utf16String const& label() const { return m_label; }
Utf16String const& language() const { return m_language; }
protected:
MediaTrackBase(JS::Realm&, GC::Ref<HTMLMediaElement>, Media::Track const&);
virtual void visit_edges(Cell::Visitor&) override;
private:
GC::Ref<HTMLMediaElement> m_media_element;
Media::Track m_track_in_playback_manager;
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-id
// https://html.spec.whatwg.org/multipage/media.html#dom-videotrack-id
Utf16String m_id;
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-kind
// https://html.spec.whatwg.org/multipage/media.html#dom-videotrack-kind
Utf16String m_kind;
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-label
// https://html.spec.whatwg.org/multipage/media.html#dom-videotrack-label
Utf16String m_label;
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-language
// https://html.spec.whatwg.org/multipage/media.html#dom-videotrack-language
Utf16String m_language;
};
}