Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Skip namespaced attributes in Element::attribute_changed()

Browse source 
Fixes the `dom/nodes/getElementsByClassName-11.xml` WPT test, which can
be imported but unfortunately not run since it's not an .html file.

Co-authored-by: YTBuzzles <bentory15@proton.me>
This commit is contained in:
Jelle Raaijmakers 2025-11-21 13:36:21 +01:00 • committed by Jelle Raaijmakers
parent 999656a7d3
commit 405e270583
Notes: github-actions[bot] 2025-11-24 08:14:33 +00:00
3 changed files with 35 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibWeb/DOM/Element.cpp
View file

@ -3832,9 +3832,13 @@ Element::Directionality Element::parent_directionality() const
// https://dom.spec.whatwg.org/#concept-element-attributes-change-ext
void Element::attribute_changed(FlyString const& local_name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
// AD-HOC: Everything below requires that there is no namespace, so return early if there is one.
if (namespace_.has_value())
return;
// https://dom.spec.whatwg.org/#ref-for-concept-element-attributes-change-ext①
// 1. If localName is slot and namespace is null, then:
if (local_name == HTML::AttributeNames::slot && !namespace_.has_value()) {
if (local_name == HTML::AttributeNames::slot) {
// 1. If value is oldValue, then return.
if (value == old_value)
return;
@ -3926,10 +3930,10 @@ void Element::attribute_changed(FlyString const& local_name, Optional<String> co
// https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes:concept-element-attributes-change-ext
// 1. If localName is not attr or namespace is not null, then return.
// 2. Set element's explicitly set attr-element to null.
#define __ENUMERATE_ARIA_ATTRIBUTE(attribute, referencing_attribute) \
else if (local_name == ARIA::AttributeNames::referencing_attribute && !namespace_.has_value()) \
{ \
set_##attribute({}); \
#define __ENUMERATE_ARIA_ATTRIBUTE(attribute, referencing_attribute) \
else if (local_name == ARIA::AttributeNames::referencing_attribute) \
{ \
set_##attribute({}); \
}
ENUMERATE_ARIA_ELEMENT_REFERENCING_ATTRIBUTES
#undef __ENUMERATE_ARIA_ATTRIBUTE
@ -3937,10 +3941,10 @@ void Element::attribute_changed(FlyString const& local_name, Optional<String> co
// https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#reflecting-content-attributes-in-idl-attributes:concept-element-attributes-change-ext-2
// 1. If localName is not attr or namespace is not null, then return.
// 2. Set element's explicitly set attr-elements to null.
#define __ENUMERATE_ARIA_ATTRIBUTE(attribute, referencing_attribute) \
else if (local_name == ARIA::AttributeNames::referencing_attribute && !namespace_.has_value()) \
{ \
set_##attribute({}); \
#define __ENUMERATE_ARIA_ATTRIBUTE(attribute, referencing_attribute) \
else if (local_name == ARIA::AttributeNames::referencing_attribute) \
{ \
set_##attribute({}); \
}
ENUMERATE_ARIA_ELEMENT_LIST_REFERENCING_ATTRIBUTES
#undef __ENUMERATE_ARIA_ATTRIBUTE

4
Tests/LibWeb/Text/expected/namespace-attribute-changed.txt Normal file
View file

@ -0,0 +1,4 @@
Matched elements: 3
Match: <x class="a"></x>
Match: <g:x class="a"></g:x>
Match: <t:x class="a" t:class="a" h:class="a" g:class="a"></t:x>

18
Tests/LibWeb/Text/input/namespace-attribute-changed.html Normal file
View file

@ -0,0 +1,18 @@
<!DOCTYPE html>
<script src="include.js"></script>
<div id="tests">
<x class="a"></x>
<g:x class="a"></g:x>
<x t:class="a" h:class="a" g:class="a"></x>
<g:x t:class="a" h:class="a" g:class="a"></g:x>
<t:x class="a" t:class="a" h:class="a" g:class="a"></t:x>
</div>
<script>
test(() => {
const collection = document.getElementsByClassName("a");
println(`Matched elements: ${collection.length}`);
for (const match of collection) {
println(`Match: ${match.outerHTML}`);
}
})
</script>