Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Stop returning the value in HTMLMediaElement::set_current_time

Browse source 
This wasn't actually affecting the result in a script assigning a
variable to the result of an expression assigning to currentTime.
This commit is contained in:
Zaggy1024 2025-10-28 22:39:10 -07:00 • committed by Tim Ledbetter
parent 14dba82202
commit 418f1575b0
Notes: github-actions[bot] 2025-10-29 06:23:53 +00:00
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -267,7 +267,7 @@ double HTMLMediaElement::current_time() const
} }
// https://html.spec.whatwg.org/multipage/media.html#dom-media-currenttime // https://html.spec.whatwg.org/multipage/media.html#dom-media-currenttime
double HTMLMediaElement::set_current_time(double current_time) void HTMLMediaElement::set_current_time(double current_time)
{ {
// On setting, if the media element's readyState is HAVE_NOTHING, then it must set the media element's default playback start // On setting, if the media element's readyState is HAVE_NOTHING, then it must set the media element's default playback start
// position to the new value; otherwise, it must set the official playback position to the new value and then seek to the new // position to the new value; otherwise, it must set the official playback position to the new value and then seek to the new
@ -283,7 +283,6 @@ double HTMLMediaElement::set_current_time(double current_time)
seek_element(current_time); seek_element(current_time);
} }
return current_time;
} }
// https://html.spec.whatwg.org/multipage/media.html#dom-media-fastseek // https://html.spec.whatwg.org/multipage/media.html#dom-media-fastseek

2
Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -95,7 +95,7 @@ public:
WebIDL::ExceptionOr<void> load(); WebIDL::ExceptionOr<void> load();
double current_time() const; double current_time() const;
double set_current_time(double); void set_current_time(double);
void fast_seek(double); void fast_seek(double);
double current_playback_position() const { return m_current_playback_position; } double current_playback_position() const { return m_current_playback_position; }