Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/CSS: Handle whitespace properly in quotes property

Browse source
This commit is contained in:
Sam Atkins 2025-10-30 14:24:55 +00:00
parent b12851427b
commit 4286a2c154
Notes: github-actions[bot] 2025-11-03 11:25:31 +00:00
2 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -4526,21 +4526,17 @@ RefPtr<StyleValue const> Parser::parse_quotes_value(TokenStream<ComponentValue>&
{
// https://www.w3.org/TR/css-content-3/#quotes-property
// auto | none | [ <string> <string> ]+
auto transaction = tokens.begin_transaction();
if (tokens.remaining_token_count() == 1) {
auto keyword = parse_keyword_value(tokens);
if (keyword && property_accepts_keyword(PropertyID::Quotes, keyword->to_keyword())) {
transaction.commit();
return keyword;
}
return nullptr;
}
if (auto auto_keyword = parse_all_as_single_keyword_value(tokens, Keyword::Auto))
return auto_keyword.release_nonnull();
if (auto none_keyword = parse_all_as_single_keyword_value(tokens, Keyword::None))
return none_keyword.release_nonnull();
auto transaction = tokens.begin_transaction();
tokens.discard_whitespace();
// Parse an even number of <string> values.
if (tokens.remaining_token_count() % 2 != 0)
return nullptr;
StyleValueVector string_values;
while (tokens.has_next_token()) {
auto maybe_string = parse_string_value(tokens);
@ -4548,8 +4544,12 @@ RefPtr<StyleValue const> Parser::parse_quotes_value(TokenStream<ComponentValue>&
return nullptr;
string_values.append(maybe_string.release_nonnull());
tokens.discard_whitespace();
}
if (string_values.size() % 2 != 0)
return nullptr;
transaction.commit();
return StyleValueList::create(move(string_values), StyleValueList::Separator::Space);
}