Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb+LibWebView+WebContent+UI: Port the document title to UTF-16

Browse source
This commit is contained in:
Timothy Flynn 2025-07-28 16:51:01 -04:00 • committed by Tim Flynn
parent 13ed6aba71
commit 50fed1d65c
Notes: github-actions[bot] 2025-08-02 17:11:26 +00:00
24 changed files with 90 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Services/WebContent/PageClient.cpp
View file

@ -224,7 +224,7 @@ void PageClient::page_did_request_cursor_change(Gfx::Cursor const& cursor)
client().async_did_request_cursor_change(m_id, cursor);
}
void PageClient::page_did_change_title(ByteString const& title)
void PageClient::page_did_change_title(Utf16String const& title)
{
client().async_did_change_title(m_id, title);
}

2
Services/WebContent/PageClient.h
View file

@ -111,7 +111,7 @@ private:
virtual Web::CSS::PreferredContrast preferred_contrast() const override { return m_preferred_contrast; }
virtual Web::CSS::PreferredMotion preferred_motion() const override { return m_preferred_motion; }
virtual void page_did_request_cursor_change(Gfx::Cursor const&) override;
virtual void page_did_change_title(ByteString const&) override;
virtual void page_did_change_title(Utf16String const&) override;
virtual void page_did_change_url(URL::URL const&) override;
virtual void page_did_request_refresh() override;
virtual void page_did_request_resize_window(Gfx::IntSize) override;

2
Services/WebContent/WebContentClient.ipc
View file

@ -34,7 +34,7 @@ endpoint WebContentClient
did_request_refresh(u64 page_id) =|
did_paint(u64 page_id, Gfx::IntRect content_rect, i32 bitmap_id) =|
did_request_cursor_change(u64 page_id, Gfx::Cursor cursor) =|
did_change_title(u64 page_id, ByteString title) =|
did_change_title(u64 page_id, Utf16String title) =|
did_change_url(u64 page_id, URL::URL url) =|
did_request_tooltip_override(u64 page_id, Gfx::IntPoint position, ByteString title) =|
did_stop_tooltip_override(u64 page_id) =|

2
Services/WebContent/WebDriverConnection.cpp
View file

@ -522,7 +522,7 @@ Messages::WebDriverClient::GetTitleResponse WebDriverConnection::get_title()
// 2. Handle any user prompts and return its value if it is an error.
handle_any_user_prompts([this]() {
// 3. Let title be the initial value of the title IDL attribute of the current top-level browsing context's active document.
auto title = current_top_level_browsing_context()->active_document()->title();
auto title = current_top_level_browsing_context()->active_document()->title().to_utf8();
// 4. Return success with data title.
async_driver_execution_complete({ move(title) });