Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 07:33:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Mark global function declarations as globals

Browse source 
This allows us to use the GetGlobal and SetGlobal bytecode instructions
for them, enabling cached accesses.

2.62x speed-up on this Fibonacci program:

    function fib(n) {
        return n < 2 ? n : fib(n - 1) + fib(n - 2);
    }
    for (let i = 0; i < 50_000; ++i)
        fib(10);
This commit is contained in:
Andreas Kling 2025-10-13 09:15:10 +02:00 • committed by Andreas Kling
parent 44d2a74eeb
commit 5a7b0a07cb
Notes: github-actions[bot] 2025-10-13 15:18:15 +00:00
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibJS/Parser.cpp
View file

@ -327,7 +327,7 @@ public:
continue; continue;
} }
if (m_type == ScopeType::Function && m_bound_names.contains(identifier_group_name)) { if (m_type == ScopeType::Function && !m_is_function_declaration && m_bound_names.contains(identifier_group_name)) {
// NOTE: Currently parser can't determine that named function expression assignment creates scope with binding for function name so function names are not considered as candidates to be optimized in global variables access // NOTE: Currently parser can't determine that named function expression assignment creates scope with binding for function name so function names are not considered as candidates to be optimized in global variables access
identifier_group.might_be_variable_in_lexical_scope_in_named_function_assignment = true; identifier_group.might_be_variable_in_lexical_scope_in_named_function_assignment = true;
} }
@ -495,6 +495,11 @@ public:
m_is_arrow_function = true; m_is_arrow_function = true;
} }
void set_is_function_declaration()
{
m_is_function_declaration = true;
}
private: private:
void throw_identifier_declared(Utf16FlyString const& name, NonnullRefPtr<Declaration const> const& declaration) void throw_identifier_declared(Utf16FlyString const& name, NonnullRefPtr<Declaration const> const& declaration)
{ {
@ -544,6 +549,8 @@ private:
bool m_uses_this_from_environment { false }; bool m_uses_this_from_environment { false };
bool m_uses_this { false }; bool m_uses_this { false };
bool m_is_arrow_function { false }; bool m_is_arrow_function { false };
bool m_is_function_declaration { false };
}; };
class OperatorPrecedenceTable { class OperatorPrecedenceTable {
@ -2991,6 +2998,8 @@ NonnullRefPtr<FunctionNodeType> Parser::parse_function_node(u16 parse_options, O
FunctionParsingInsights parsing_insights; FunctionParsingInsights parsing_insights;
auto body = [&] { auto body = [&] {
ScopePusher function_scope = ScopePusher::function_scope(*this, name); ScopePusher function_scope = ScopePusher::function_scope(*this, name);
if constexpr (IsSame<FunctionNodeType, FunctionDeclaration>)
function_scope.set_is_function_declaration();
consume(TokenType::ParenOpen); consume(TokenType::ParenOpen);
parameters = parse_formal_parameters(function_length, parse_options); parameters = parse_formal_parameters(function_length, parse_options);