Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Pass AbstractElement in ComputationContext

Browse source 
Passing the `AbstractElement` rather than the
`TreeCountingFunctionResolutionContext` allows us to only compute the
resolution context when necessary (i.e. when we actually need to resolve
a tree counting function)
This commit is contained in:
Callum Law 2025-10-22 00:06:38 +13:00 • committed by Jelle Raaijmakers
parent a4184fda1f
commit 5b9a36b172
Notes: github-actions[bot] 2025-10-21 23:02:05 +00:00
9 changed files with 28 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/HTML/Canvas/CanvasTextDrawingStyles.h
View file

@ -116,7 +116,7 @@ public:
// FIXME: Investigate whether this is the correct resolution context (i.e. whether we should instead use
// a font-size of 10px) for OffscreenCanvas
auto length_resolution_context = CSS::Length::ResolutionContext::for_window(*document->window());
Optional<CSS::TreeCountingFunctionResolutionContext> tree_counting_function_resolution_context;
Optional<DOM::AbstractElement> abstract_element;
if constexpr (SameAs<CanvasType, HTML::HTMLCanvasElement>) {
// NOTE: The canvas itself is considered the inheritance parent
@ -127,16 +127,15 @@ public:
inherited_font_size = canvas_element.computed_properties()->font_size();
inherited_font_weight = canvas_element.computed_properties()->font_weight();
DOM::AbstractElement abstract_element { canvas_element };
abstract_element = DOM::AbstractElement { canvas_element };
length_resolution_context = CSS::Length::ResolutionContext::for_element(abstract_element);
tree_counting_function_resolution_context = abstract_element.tree_counting_function_resolution_context();
length_resolution_context = CSS::Length::ResolutionContext::for_element(abstract_element.value());
}
}
CSS::ComputationContext computation_context {
.length_resolution_context = length_resolution_context,
.tree_counting_function_resolution_context = tree_counting_function_resolution_context
.abstract_element = abstract_element
};
// FIXME: Should font be recomputed on canvas element style change?