Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Use return_value register for "last completion" return values

Browse source 
This simplifies the epilogue in run_executable().
This commit is contained in:
Andreas Kling 2025-10-30 22:32:15 +01:00 • committed by Andreas Kling
parent 5706831328
commit 62781f4818
Notes: github-actions[bot] 2025-10-31 07:57:10 +00:00
1 changed files with 6 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -380,7 +380,7 @@ FLATTEN_ON_CLANG void Interpreter::run_bytecode(size_t entry_point)
handle_End: { handle_End: {
auto& instruction = *reinterpret_cast<Op::End const*>(&bytecode[program_counter]); auto& instruction = *reinterpret_cast<Op::End const*>(&bytecode[program_counter]);
accumulator() = get(instruction.value()); reg(Register::return_value()) = get(instruction.value());
return; return;
} }
@ -720,7 +720,6 @@ ThrowCompletionOr<Value> Interpreter::run_executable(ExecutionContext& context,
context.registers_and_constants_and_locals_arguments = context.registers_and_constants_and_locals_and_arguments_span(); context.registers_and_constants_and_locals_arguments = context.registers_and_constants_and_locals_and_arguments_span();
reg(Register::accumulator()) = initial_accumulator_value; reg(Register::accumulator()) = initial_accumulator_value;
reg(Register::return_value()) = js_special_empty_value();
// NOTE: We only copy the `this` value from ExecutionContext if it's not already set. // NOTE: We only copy the `this` value from ExecutionContext if it's not already set.
// If we are re-entering an async/generator context, the `this` value // If we are re-entering an async/generator context, the `this` value
@ -749,22 +748,16 @@ ThrowCompletionOr<Value> Interpreter::run_executable(ExecutionContext& context,
} }
} }
Value return_value;
if (auto return_register_value = reg(Register::return_value()); !return_register_value.is_special_empty_value())
return_value = return_register_value;
else {
return_value = reg(Register::accumulator());
if (return_value.is_special_empty_value())
return_value = js_undefined();
}
auto exception = reg(Register::exception());
vm().run_queued_promise_jobs(); vm().run_queued_promise_jobs();
vm().finish_execution_generation(); vm().finish_execution_generation();
auto exception = reg(Register::exception());
if (!exception.is_special_empty_value()) [[unlikely]] if (!exception.is_special_empty_value()) [[unlikely]]
return throw_completion(exception); return throw_completion(exception);
auto return_value = reg(Register::return_value());
if (return_value.is_special_empty_value())
return_value = js_undefined();
return return_value; return return_value;
} }