Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/HTML: Return early from find_appropriate_place_for_inserting_node

Browse source 
Step 2.(a).5 says to abort, but we were instead carrying on and would
run steps 3 and 4. Those steps would not change the result at all, but
this avoids a little unnecessary work.

I wrapped a couple of comments at 120 columns while I was at it.
This commit is contained in:
Sam Atkins 2025-11-25 10:28:22 +00:00 • committed by Jelle Raaijmakers
parent 418e22d65a
commit 6a4ab26b48
Notes: github-actions[bot] 2025-11-26 08:54:34 +00:00
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -748,29 +748,30 @@ HTMLParser::AdjustedInsertionLocation HTMLParser::find_appropriate_place_for_ins
// 3. If there is a last template and either there is no last table,
// or there is one, but last template is lower (more recently added) than last table in the stack of open elements,
if (last_template.element && (!last_table.element || last_template.index > last_table.index)) {
// then: let adjusted insertion location be inside last template's template contents, after its last child (if any), and abort these steps.
// then: let adjusted insertion location be inside last template's template contents, after its last child
// (if any), and abort these steps.
// NOTE: This returns the template content, so no need to check the parent is a template.
return { as<HTMLTemplateElement>(*last_template.element).content().ptr(), nullptr };
}
// 4. If there is no last table, then let adjusted insertion location be inside the first element in the stack of open elements (the html element),
// after its last child (if any), and abort these steps. (fragment case)
// 4. If there is no last table, then let adjusted insertion location be inside the first element in the stack
// of open elements (the html element), after its last child (if any), and abort these steps. (fragment case)
if (!last_table.element) {
VERIFY(m_parsing_fragment);
// Guaranteed not to be a template element (it will be the html element),
// so no need to check the parent is a template.
return { *m_stack_of_open_elements.elements().first(), nullptr };
}
// 5. If last table has a parent node, then let adjusted insertion location be inside last table's parent node, immediately before last table, and abort these steps.
if (last_table.element->parent_node()) {
adjusted_insertion_location = { last_table.element->parent_node(), last_table.element.ptr() };
} else {
// 6. Let previous element be the element immediately above last table in the stack of open elements.
auto previous_element = m_stack_of_open_elements.element_immediately_above(*last_table.element);
// 5. If last table has a parent node, then let adjusted insertion location be inside last table's parent node,
// immediately before last table, and abort these steps.
if (last_table.element->parent_node())
return { last_table.element->parent_node(), last_table.element.ptr() };
// 7. Let adjusted insertion location be inside previous element, after its last child (if any).
adjusted_insertion_location = { previous_element.ptr(), nullptr };
}
// 6. Let previous element be the element immediately above last table in the stack of open elements.
auto previous_element = m_stack_of_open_elements.element_immediately_above(*last_table.element);
// 7. Let adjusted insertion location be inside previous element, after its last child (if any).
adjusted_insertion_location = { previous_element.ptr(), nullptr };
} else {
// `-> Otherwise
// Let adjusted insertion location be inside target, after its last child (if any).