mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	LibWeb: Map embedded content element attributes to dimension properties
This commit is contained in:
		
							parent
							
								
									baca0e5e55
								
							
						
					
					
						commit
						728236f4d2
					
				
				
				Notes:
				
					github-actions[bot]
				
				2024-10-02 09:28:22 +00:00 
				
			
			Author: https://github.com/tcl3
Commit: 728236f4d2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1591
			
					 8 changed files with 189 additions and 1 deletions
				
			
		|  | @ -6,7 +6,10 @@ | |||
| 
 | ||||
| #include <LibWeb/Bindings/HTMLEmbedElementPrototype.h> | ||||
| #include <LibWeb/Bindings/Intrinsics.h> | ||||
| #include <LibWeb/CSS/StyleProperties.h> | ||||
| #include <LibWeb/CSS/StyleValues/CSSKeywordValue.h> | ||||
| #include <LibWeb/HTML/HTMLEmbedElement.h> | ||||
| #include <LibWeb/HTML/Parser/HTMLParser.h> | ||||
| 
 | ||||
| namespace Web::HTML { | ||||
| 
 | ||||
|  | @ -25,4 +28,35 @@ void HTMLEmbedElement::initialize(JS::Realm& realm) | |||
|     WEB_SET_PROTOTYPE_FOR_INTERFACE(HTMLEmbedElement); | ||||
| } | ||||
| 
 | ||||
| void HTMLEmbedElement::apply_presentational_hints(CSS::StyleProperties& style) const | ||||
| { | ||||
|     for_each_attribute([&](auto& name, auto& value) { | ||||
|         if (name == HTML::AttributeNames::align) { | ||||
|             if (value.equals_ignoring_ascii_case("center"sv)) | ||||
|                 style.set_property(CSS::PropertyID::TextAlign, CSS::CSSKeywordValue::create(CSS::Keyword::Center)); | ||||
|             else if (value.equals_ignoring_ascii_case("middle"sv)) | ||||
|                 style.set_property(CSS::PropertyID::TextAlign, CSS::CSSKeywordValue::create(CSS::Keyword::Middle)); | ||||
|         } else if (name == HTML::AttributeNames::height) { | ||||
|             if (auto parsed_value = parse_dimension_value(value)) | ||||
|                 style.set_property(CSS::PropertyID::Height, *parsed_value); | ||||
|         } | ||||
|         // https://html.spec.whatwg.org/multipage/rendering.html#attributes-for-embedded-content-and-images:maps-to-the-dimension-property
 | ||||
|         else if (name == HTML::AttributeNames::hspace) { | ||||
|             if (auto parsed_value = parse_dimension_value(value)) { | ||||
|                 style.set_property(CSS::PropertyID::MarginLeft, *parsed_value); | ||||
|                 style.set_property(CSS::PropertyID::MarginRight, *parsed_value); | ||||
|             } | ||||
|         } else if (name == HTML::AttributeNames::vspace) { | ||||
|             if (auto parsed_value = parse_dimension_value(value)) { | ||||
|                 style.set_property(CSS::PropertyID::MarginTop, *parsed_value); | ||||
|                 style.set_property(CSS::PropertyID::MarginBottom, *parsed_value); | ||||
|             } | ||||
|         } else if (name == HTML::AttributeNames::width) { | ||||
|             if (auto parsed_value = parse_dimension_value(value)) { | ||||
|                 style.set_property(CSS::PropertyID::Width, *parsed_value); | ||||
|             } | ||||
|         } | ||||
|     }); | ||||
| } | ||||
| 
 | ||||
| } | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Tim Ledbetter
						Tim Ledbetter