Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 15:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/IDB: Allow null errors during abort

Browse source
This commit is contained in:
stelar7 2025-08-11 22:32:14 +02:00 • committed by Sam Atkins
parent 474b748275
commit 75054aeecd
Notes: github-actions[bot] 2025-08-14 08:33:27 +00:00
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View file

@ -537,22 +537,25 @@ void abort_a_transaction(GC::Ref<IDBTransaction> transaction, GC::Ptr<WebIDL::DO
transaction->set_aborted(true);
dbgln_if(IDB_DEBUG, "abort_a_transaction: transaction {} is aborting", transaction->uuid());
// FIXME: 1. All the changes made to the database by the transaction are reverted.
// 1. If transaction is finished, abort these steps.
if (transaction->is_finished())
return;
// FIXME: 2. All the changes made to the database by the transaction are reverted.
// For upgrade transactions this includes changes to the set of object stores and indexes, as well as the change to the version.
// Any object stores and indexes which were created during the transaction are now considered deleted for the purposes of other algorithms.
// FIXME: 2. If transaction is an upgrade transaction, run the steps to abort an upgrade transaction with transaction.
// FIXME: 3. If transaction is an upgrade transaction, run the steps to abort an upgrade transaction with transaction.
// if (transaction.is_upgrade_transaction())
// abort_an_upgrade_transaction(transaction);
// 3. Set transaction’s state to finished.
// 4. Set transaction’s state to finished.
transaction->set_state(IDBTransaction::TransactionState::Finished);
// 4. If error is not null, set transaction’s error to error.
if (error)
transaction->set_error(error);
// 5. Set transaction’s error to error.
transaction->set_error(error);
// 5. For each request of transaction’s request list,
// 6. For each request of transaction’s request list,
for (auto const& request : transaction->request_list()) {
// FIXME: abort the steps to asynchronously execute a request for request,
@ -575,7 +578,7 @@ void abort_a_transaction(GC::Ref<IDBTransaction> transaction, GC::Ptr<WebIDL::DO
}));
}
// 6. Queue a database task to run these steps:
// 7. Queue a database task to run these steps:
queue_a_database_task(GC::create_function(transaction->realm().vm().heap(), [transaction]() {
// 1. If transaction is an upgrade transaction, then set transaction’s connection's associated database's upgrade transaction to null.
if (transaction->is_upgrade_transaction())