Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2026-04-19 02:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Use Bindings::InterfaceName for serializing types

Browse source 
While this does cost us an extra byte to serialize as it
contains _all_ interface names instead of the set of serializable
types, doing this will allow us to remove to use the same
enum for checking whether that interface is exposed in a future
commit.
This commit is contained in:
Shannon Booth 2025-07-18 15:00:12 +12:00 • committed by Shannon Booth
parent 7a6301f58a
commit 76cf230bd6
Notes: github-actions[bot] 2026-02-14 19:36:26 +00:00
18 changed files with 52 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

70
Libraries/LibWeb/HTML/StructuredSerialize.cpp
View file

@ -856,7 +856,7 @@ public:
VERIFY(tag == ValueTag::SerializableObject);
// 1. Let interfaceName be serialized.[[Type]].
auto interface_name = m_serialized.decode<SerializeType>();
auto interface_name = m_serialized.decode<Bindings::InterfaceName>();
// 2. If the interface identified by interfaceName is not exposed in targetRealm, then throw a "DataCloneError" DOMException.
if (!is_serializable_interface_exposed_on_target_realm(interface_name, realm))
@ -942,41 +942,41 @@ public:
}
private:
static bool is_serializable_interface_exposed_on_target_realm(SerializeType name, JS::Realm& realm)
static bool is_serializable_interface_exposed_on_target_realm(Bindings::InterfaceName name, JS::Realm& realm)
{
auto const& intrinsics = Bindings::host_defined_intrinsics(realm);
switch (name) {
case SerializeType::Blob:
case Bindings::InterfaceName::Blob:
return intrinsics.is_interface_exposed<Bindings::BlobPrototype>(realm);
case SerializeType::File:
case Bindings::InterfaceName::File:
return intrinsics.is_interface_exposed<Bindings::FilePrototype>(realm);
case SerializeType::FileList:
case Bindings::InterfaceName::FileList:
return intrinsics.is_interface_exposed<Bindings::FileListPrototype>(realm);
case SerializeType::DOMException:
case Bindings::InterfaceName::DOMException:
return intrinsics.is_interface_exposed<Bindings::DOMExceptionPrototype>(realm);
case SerializeType::DOMMatrixReadOnly:
case Bindings::InterfaceName::DOMMatrixReadOnly:
return intrinsics.is_interface_exposed<Bindings::DOMMatrixReadOnlyPrototype>(realm);
case SerializeType::DOMMatrix:
case Bindings::InterfaceName::DOMMatrix:
return intrinsics.is_interface_exposed<Bindings::DOMMatrixPrototype>(realm);
case SerializeType::DOMPointReadOnly:
case Bindings::InterfaceName::DOMPointReadOnly:
return intrinsics.is_interface_exposed<Bindings::DOMPointReadOnlyPrototype>(realm);
case SerializeType::DOMPoint:
case Bindings::InterfaceName::DOMPoint:
return intrinsics.is_interface_exposed<Bindings::DOMPointPrototype>(realm);
case SerializeType::DOMRectReadOnly:
case Bindings::InterfaceName::DOMRectReadOnly:
return intrinsics.is_interface_exposed<Bindings::DOMRectReadOnlyPrototype>(realm);
case SerializeType::DOMRect:
case Bindings::InterfaceName::DOMRect:
return intrinsics.is_interface_exposed<Bindings::DOMRectPrototype>(realm);
case SerializeType::CryptoKey:
case Bindings::InterfaceName::CryptoKey:
return intrinsics.is_interface_exposed<Bindings::CryptoKeyPrototype>(realm);
case SerializeType::DOMQuad:
case Bindings::InterfaceName::DOMQuad:
return intrinsics.is_interface_exposed<Bindings::DOMQuadPrototype>(realm);
case SerializeType::ImageData:
case Bindings::InterfaceName::ImageData:
return intrinsics.is_interface_exposed<Bindings::ImageDataPrototype>(realm);
case SerializeType::ImageBitmap:
case Bindings::InterfaceName::ImageBitmap:
return intrinsics.is_interface_exposed<Bindings::ImageBitmapPrototype>(realm);
case SerializeType::QuotaExceededError:
case Bindings::InterfaceName::QuotaExceededError:
return intrinsics.is_interface_exposed<Bindings::QuotaExceededErrorPrototype>(realm);
case SerializeType::Unknown:
case Bindings::InterfaceName::Unknown:
dbgln("Unknown interface type for serialization: {}", to_underlying(name));
break;
default:
@ -985,40 +985,40 @@ private:
return false;
}
static GC::Ref<Bindings::PlatformObject> create_serialized_type(SerializeType serialize_type, JS::Realm& realm)
static GC::Ref<Bindings::PlatformObject> create_serialized_type(Bindings::InterfaceName serialize_type, JS::Realm& realm)
{
switch (serialize_type) {
case SerializeType::Blob:
case Bindings::InterfaceName::Blob:
return FileAPI::Blob::create(realm);
case SerializeType::File:
case Bindings::InterfaceName::File:
return FileAPI::File::create(realm);
case SerializeType::FileList:
case Bindings::InterfaceName::FileList:
return FileAPI::FileList::create(realm);
case SerializeType::DOMException:
case Bindings::InterfaceName::DOMException:
return WebIDL::DOMException::create(realm);
case SerializeType::DOMMatrixReadOnly:
case Bindings::InterfaceName::DOMMatrixReadOnly:
return Geometry::DOMMatrixReadOnly::create(realm);
case SerializeType::DOMMatrix:
case Bindings::InterfaceName::DOMMatrix:
return Geometry::DOMMatrix::create(realm);
case SerializeType::DOMPointReadOnly:
case Bindings::InterfaceName::DOMPointReadOnly:
return Geometry::DOMPointReadOnly::create(realm);
case SerializeType::DOMPoint:
case Bindings::InterfaceName::DOMPoint:
return Geometry::DOMPoint::create(realm);
case SerializeType::DOMRectReadOnly:
case Bindings::InterfaceName::DOMRectReadOnly:
return Geometry::DOMRectReadOnly::create(realm);
case SerializeType::DOMRect:
case Bindings::InterfaceName::DOMRect:
return Geometry::DOMRect::create(realm);
case SerializeType::CryptoKey:
case Bindings::InterfaceName::CryptoKey:
return Crypto::CryptoKey::create(realm);
case SerializeType::DOMQuad:
case Bindings::InterfaceName::DOMQuad:
return Geometry::DOMQuad::create(realm);
case SerializeType::ImageData:
case Bindings::InterfaceName::ImageData:
return ImageData::create(realm);
case SerializeType::ImageBitmap:
case Bindings::InterfaceName::ImageBitmap:
return ImageBitmap::create(realm);
case SerializeType::QuotaExceededError:
case Bindings::InterfaceName::QuotaExceededError:
return WebIDL::QuotaExceededError::create(realm);
case SerializeType::Unknown:
case Bindings::InterfaceName::Unknown:
default:
VERIFY_NOT_REACHED();
}