Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Implement CanvasRenderingContext2D direction property

Browse source 
When direction is 'rtl':
  - textAlign='start' now aligns text to the right
  - textAlign='end' now aligns text to the left

Fixes the FIXME at CanvasRenderingContext2D.cpp:283
This commit is contained in:
Adrian Kiezik 2025-10-05 14:27:08 +02:00 • committed by Jelle Raaijmakers
parent ffcd3a4bb2
commit 823deacc27
Notes: github-actions[bot] 2025-10-28 05:04:41 +00:00
5 changed files with 35 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp
View file

@ -286,15 +286,39 @@ Gfx::Path CanvasRenderingContext2D::text_path(Utf16String const& text, float x,
}
// Apply text align
// FIXME: CanvasTextAlign::Start and CanvasTextAlign::End currently do not nothing for right-to-left languages:
// https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-textalign-start
// Default alignment of draw_text is left so do nothing by CanvasTextAlign::Start and CanvasTextAlign::Left
// https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-textalign
// The direction property affects how "start" and "end" are interpreted:
// - "ltr" or "inherit" (default): start=left, end=right
// - "rtl": start=right, end=left
// Determine if we're in RTL mode
bool is_rtl = drawing_state.direction == Bindings::CanvasDirection::Rtl;
// Center alignment is the same regardless of direction
if (drawing_state.text_align == Bindings::CanvasTextAlign::Center) {
transform = Gfx::AffineTransform {}.set_translation({ -text_width / 2, 0 }).multiply(transform);
}
if (drawing_state.text_align == Bindings::CanvasTextAlign::End || drawing_state.text_align == Bindings::CanvasTextAlign::Right) {
// Handle "start" alignment
else if (drawing_state.text_align == Bindings::CanvasTextAlign::Start) {
// In RTL, "start" means right-aligned (translate by full width)
if (is_rtl) {
transform = Gfx::AffineTransform {}.set_translation({ -text_width, 0 }).multiply(transform);
}
// In LTR, "start" means left-aligned (no translation needed - default)
}
// Handle "end" alignment
else if (drawing_state.text_align == Bindings::CanvasTextAlign::End) {
// In RTL, "end" means left-aligned (no translation needed)
if (!is_rtl) {
// In LTR, "end" means right-aligned (translate by full width)
transform = Gfx::AffineTransform {}.set_translation({ -text_width, 0 }).multiply(transform);
}
}
// Explicit "left" and "right" alignments ignore direction
else if (drawing_state.text_align == Bindings::CanvasTextAlign::Right) {
transform = Gfx::AffineTransform {}.set_translation({ -text_width, 0 }).multiply(transform);
}
// Left is the default - no translation needed
// Apply text baseline
// FIXME: Implement CanvasTextBaseline::Hanging, Bindings::CanvasTextAlign::Alphabetic and Bindings::CanvasTextAlign::Ideographic for real