Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWebView+WebContent+UI: Remember the current system visibility state

Browse source 
We will want to re-inform WebContent of the system visibility state when
we create a new process after a crash. This changes the IPC to just send
the enum value directly, instead of a boolean, so that we can just store
that enum value directly on the ViewImplementation class.
This commit is contained in:
Timothy Flynn 2024-11-13 11:24:16 -05:00 • committed by Andreas Kling
parent c04b14d0cb
commit 83b1db785a
Notes: github-actions[bot] 2024-11-13 19:37:50 +00:00
11 changed files with 28 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

4
UI/AppKit/Interface/LadybirdWebView.mm
View file

@ -212,7 +212,9 @@ struct HideCursor {
- (void)handleVisibility:(BOOL)is_visible
{
m_web_view_bridge->set_system_visibility_state(is_visible);
m_web_view_bridge->set_system_visibility_state(is_visible
? Web::HTML::VisibilityState::Visible
: Web::HTML::VisibilityState::Hidden);
}
- (void)findInPage:(NSString*)query

5
UI/AppKit/Interface/LadybirdWebViewBridge.cpp
View file

@ -44,11 +44,6 @@ void WebViewBridge::set_device_pixel_ratio(float device_pixel_ratio)
client().async_set_device_pixels_per_css_pixel(m_client_state.page_index, m_device_pixel_ratio * m_zoom_level);
}
void WebViewBridge::set_system_visibility_state(bool is_visible)
{
client().async_set_system_visibility_state(m_client_state.page_index, is_visible);
}
void WebViewBridge::set_viewport_rect(Gfx::IntRect viewport_rect)
{
viewport_rect.set_size(scale_for_device(viewport_rect.size(), m_device_pixel_ratio));

1
UI/AppKit/Interface/LadybirdWebViewBridge.h
View file

@ -31,7 +31,6 @@ public:
void set_device_pixel_ratio(float device_pixel_ratio);
float inverse_device_pixel_ratio() const { return 1.0f / m_device_pixel_ratio; }
void set_system_visibility_state(bool is_visible);
void set_viewport_rect(Gfx::IntRect);
void update_palette();

7
UI/Headless/HeadlessWebView.cpp
View file

@ -54,11 +54,11 @@ HeadlessWebView::HeadlessWebView(Core::AnonymousBuffer theme, Web::DevicePixelSi
};
on_restore_window = [this]() {
client().async_set_system_visibility_state(m_client_state.page_index, true);
set_system_visibility_state(Web::HTML::VisibilityState::Visible);
};
on_minimize_window = [this]() {
client().async_set_system_visibility_state(m_client_state.page_index, false);
set_system_visibility_state(Web::HTML::VisibilityState::Hidden);
};
on_maximize_window = [this]() {
@ -173,11 +173,12 @@ void HeadlessWebView::initialize_client(CreateNewClient create_new_client)
client().async_set_window_handle(m_client_state.page_index, m_client_state.client_handle);
client().async_update_system_theme(m_client_state.page_index, m_theme);
client().async_set_system_visibility_state(m_client_state.page_index, true);
client().async_set_viewport_size(m_client_state.page_index, viewport_size());
client().async_set_window_size(m_client_state.page_index, viewport_size());
client().async_update_screen_rects(m_client_state.page_index, { screen_rect }, 0);
set_system_visibility_state(Web::HTML::VisibilityState::Visible);
if (Application::chrome_options().allow_popups == WebView::AllowPopups::Yes)
client().async_debug_request(m_client_state.page_index, "block-pop-ups"sv, "off"sv);

4
UI/Qt/WebContentView.cpp
View file

@ -557,13 +557,13 @@ void WebContentView::update_zoom()
void WebContentView::showEvent(QShowEvent* event)
{
QWidget::showEvent(event);
client().async_set_system_visibility_state(m_client_state.page_index, true);
set_system_visibility_state(Web::HTML::VisibilityState::Visible);
}
void WebContentView::hideEvent(QHideEvent* event)
{
QWidget::hideEvent(event);
client().async_set_system_visibility_state(m_client_state.page_index, false);
set_system_visibility_state(Web::HTML::VisibilityState::Hidden);
}
static Core::AnonymousBuffer make_system_theme_from_qt_palette(QWidget& widget, WebContentView::PaletteMode mode)