Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Add SVGList<T> and use it for SVGTransformList

Browse source 
The spec defines a generic list interfaces that we can reuse. Currently
we only have SVGTransformList, but we will need this to add
SVGNumberList as well.
This commit is contained in:
Jelle Raaijmakers 2025-11-05 15:20:53 +01:00 • committed by Jelle Raaijmakers
parent 7e869c7816
commit 9991205403
Notes: github-actions[bot] 2025-11-09 00:24:22 +00:00
8 changed files with 307 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

52
Libraries/LibWeb/SVG/SVGTransformList.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2024, MacDue <macdue@dueutil.tech>
* Copyright (c) 2025, Jelle Raaijmakers <jelle@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -13,48 +14,26 @@ namespace Web::SVG {
GC_DEFINE_ALLOCATOR(SVGTransformList);
GC::Ref<SVGTransformList> SVGTransformList::create(JS::Realm& realm)
GC::Ref<SVGTransformList> SVGTransformList::create(JS::Realm& realm, Vector<GC::Ref<SVGTransform>> items, ReadOnlyList read_only)
{
return realm.create<SVGTransformList>(realm);
return realm.create<SVGTransformList>(realm, move(items), read_only);
}
SVGTransformList::~SVGTransformList() = default;
GC::Ref<SVGTransformList> SVGTransformList::create(JS::Realm& realm, ReadOnlyList read_only)
{
return realm.create<SVGTransformList>(realm, read_only);
}
SVGTransformList::SVGTransformList(JS::Realm& realm)
: PlatformObject(realm)
SVGTransformList::SVGTransformList(JS::Realm& realm, Vector<GC::Ref<SVGTransform>> items, ReadOnlyList read_only)
: Bindings::PlatformObject(realm)
, SVGList(realm, move(items), read_only)
{
}
// https://svgwg.org/svg2-draft/single-page.html#types-__svg__SVGNameList__length
WebIDL::UnsignedLong SVGTransformList::length()
SVGTransformList::SVGTransformList(JS::Realm& realm, ReadOnlyList read_only)
: Bindings::PlatformObject(realm)
, SVGList(realm, read_only)
{
// The length and numberOfItems IDL attributes represents the length of the list, and on getting simply return the length of the list.
return m_transforms.size();
}
// https://svgwg.org/svg2-draft/single-page.html#types-__svg__SVGNameList__numberOfItems
WebIDL::UnsignedLong SVGTransformList::number_of_items()
{
// The length and numberOfItems IDL attributes represents the length of the list, and on getting simply return the length of the list.
return m_transforms.size();
}
// https://svgwg.org/svg2-draft/single-page.html#types-__svg__SVGNameList__getItem
WebIDL::ExceptionOr<GC::Ref<SVGTransform>> SVGTransformList::get_item(WebIDL::UnsignedLong index)
{
// 1. If index is greater than or equal to the length of the list, then throw an IndexSizeError.
if (index >= m_transforms.size())
return WebIDL::IndexSizeError::create(realm(), "SVGTransformList index out of bounds"_utf16);
// 2. Return the element in the list at position index.
return m_transforms.at(index);
}
// https://svgwg.org/svg2-draft/single-page.html#types-__svg__SVGNameList__appendItem
GC::Ref<SVGTransform> SVGTransformList::append_item(GC::Ref<SVGTransform> new_item)
{
// FIXME: This does not implement the steps from the specification.
m_transforms.append(new_item);
return new_item;
}
void SVGTransformList::initialize(JS::Realm& realm)
@ -63,11 +42,10 @@ void SVGTransformList::initialize(JS::Realm& realm)
Base::initialize(realm);
}
void SVGTransformList::visit_edges(Cell::Visitor& visitor)
void SVGTransformList::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
for (auto transform : m_transforms)
transform->visit_edges(visitor);
SVGList::visit_edges(visitor);
}
}