Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Remove unnecessary parse_list_of_time_values function

Browse source 
We can achieve the same thing by using
`parse_simple_comma_separated_value_list`
This commit is contained in:
Callum Law 2025-11-14 01:39:36 +13:00 • committed by Sam Atkins
parent b0ab94c00c
commit 9afb523be3
Notes: github-actions[bot] 2025-11-28 16:17:12 +00:00
2 changed files with 2 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/Parser/Parser.h
View file

@ -539,8 +539,6 @@ private:
RefPtr<StyleValue const> parse_white_space_trim_value(TokenStream<ComponentValue>&);
RefPtr<StyleValue const> parse_will_change_value(TokenStream<ComponentValue>&);
RefPtr<StyleValue const> parse_list_of_time_values(PropertyID, TokenStream<ComponentValue>&);
RefPtr<CalculationNode const> convert_to_calculation_node(CalcParsing::Node const&, CalculationContext const&);
RefPtr<CalculationNode const> parse_a_calculation(Vector<ComponentValue> const&, CalculationContext const&);

26
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -743,11 +743,10 @@ Parser::ParseErrorOr<NonnullRefPtr<StyleValue const>> Parser::parse_css_value(Pr
return parse_all_as(tokens, [this](auto& tokens) { return parse_transform_origin_value(tokens); });
case PropertyID::Transition:
return parse_all_as(tokens, [this](auto& tokens) { return parse_transition_value(tokens); });
case PropertyID::TransitionDelay:
case PropertyID::TransitionDuration:
return parse_all_as(tokens, [this, property_id](auto& tokens) { return parse_list_of_time_values(property_id, tokens); });
case PropertyID::TransitionProperty:
return parse_all_as(tokens, [this](auto& tokens) { return parse_transition_property_value(tokens); });
case PropertyID::TransitionDelay:
case PropertyID::TransitionDuration:
case PropertyID::TransitionTimingFunction:
case PropertyID::TransitionBehavior:
return parse_all_as(tokens, [this, property_id](auto& tokens) { return parse_simple_comma_separated_value_list(property_id, tokens); });
@ -5073,27 +5072,6 @@ RefPtr<StyleValue const> Parser::parse_transition_value(TokenStream<ComponentVal
return parsed_value;
}
RefPtr<StyleValue const> Parser::parse_list_of_time_values(PropertyID property_id, TokenStream<ComponentValue>& tokens)
{
auto transaction = tokens.begin_transaction();
auto time_values = parse_a_comma_separated_list_of_component_values(tokens);
StyleValueVector time_value_list;
for (auto const& value : time_values) {
TokenStream time_value_tokens { value };
auto time_style_value = parse_time_value(time_value_tokens);
if (!time_style_value)
return nullptr;
if (time_value_tokens.has_next_token())
return nullptr;
if (!time_style_value->is_calculated() && !property_accepts_time(property_id, time_style_value->as_time().time()))
return nullptr;
time_value_list.append(*time_style_value);
}
transaction.commit();
return StyleValueList::create(move(time_value_list), StyleValueList::Separator::Comma);
}
RefPtr<StyleValue const> Parser::parse_transition_property_value(TokenStream<ComponentValue>& tokens)
{
// https://drafts.csswg.org/css-transitions/#transition-property-property