Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Make eventInitDict GamepadEvent constructor parameter optional

Browse source 
This differs from the specification but matches the behavior of
existing implementations.
This commit is contained in:
Tim Ledbetter 2025-09-02 02:36:19 +01:00 • committed by Tim Ledbetter
parent 5df91dc761
commit 9c204f36ec
Notes: github-actions[bot] 2025-09-23 15:06:29 +00:00
5 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Gamepad/GamepadEvent.cpp
View file

@ -20,7 +20,7 @@ WebIDL::ExceptionOr<GC::Ref<GamepadEvent>> GamepadEvent::construct_impl(JS::Real
GamepadEvent::GamepadEvent(JS::Realm& realm, FlyString const& event_name, GamepadEventInit const& event_init)
: DOM::Event(realm, event_name, event_init)
, m_gamepad(*event_init.gamepad)
, m_gamepad(event_init.gamepad.has_value() ? event_init.gamepad->ptr() : nullptr)
{
}

8
Libraries/LibWeb/Gamepad/GamepadEvent.h
View file

@ -11,7 +11,7 @@
namespace Web::Gamepad {
struct GamepadEventInit : public DOM::EventInit {
GC::Root<Gamepad> gamepad;
Optional<GC::Root<Gamepad>> gamepad;
};
class GamepadEvent final : public DOM::Event {
@ -19,18 +19,18 @@ class GamepadEvent final : public DOM::Event {
GC_DECLARE_ALLOCATOR(GamepadEvent);
public:
[[nodiscard]] static WebIDL::ExceptionOr<GC::Ref<GamepadEvent>> construct_impl(JS::Realm&, FlyString const& event_name, GamepadEventInit const&);
[[nodiscard]] static WebIDL::ExceptionOr<GC::Ref<GamepadEvent>> construct_impl(JS::Realm&, FlyString const& event_name, GamepadEventInit const& = {});
virtual ~GamepadEvent() override;
GC::Ref<Gamepad> gamepad() const { return m_gamepad; }
GC::Ptr<Gamepad> gamepad() const { return m_gamepad; }
private:
GamepadEvent(JS::Realm&, FlyString const& event_name, GamepadEventInit const& event_init);
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
GC::Ref<Gamepad> m_gamepad;
GC::Ptr<Gamepad> m_gamepad;
};
}

10
Libraries/LibWeb/Gamepad/GamepadEvent.idl
View file

@ -4,11 +4,15 @@
// https://w3c.github.io/gamepad/#dom-gamepadevent
[Exposed=Window]
interface GamepadEvent : Event {
constructor(DOMString type, GamepadEventInit eventInitDict);
[SameObject] readonly attribute Gamepad gamepad;
// eventInitDict is not marked as optional in the specification, but existing implementations treat it as optional.
// See: https://github.com/w3c/gamepad/pull/217
constructor(DOMString type, optional GamepadEventInit eventInitDict = {});
[SameObject] readonly attribute Gamepad? gamepad;
};
// https://w3c.github.io/gamepad/#dom-gamepadeventinit
dictionary GamepadEventInit : EventInit {
required Gamepad gamepad;
// This is marked as required in the specification, but existing implementations treat it as optional.
// See: https://github.com/w3c/gamepad/pull/217
Gamepad? gamepad = null;
};