Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWebView: Check the actual Ladybird process exit code on Windows

Browse source 
Even if the process has died, OpenProcess returns a non-null handle
(unless some error occurred). We need to check the exit code.
This commit is contained in:
Timothy Flynn 2025-11-03 14:44:53 -05:00 • committed by Tim Flynn
parent 6f0d7f1caf
commit 9ff75f442b
Notes: github-actions[bot] 2025-11-04 00:30:35 +00:00
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWebView/Process.cpp
View file

@ -81,15 +81,26 @@ ErrorOr<Optional<pid_t>> Process::get_process_pid(StringView process_name, Strin
TRY(Core::System::unlink(pid_path));
return OptionalNone {};
}
bool const process_not_found = [&pid]() {
#if defined(AK_OS_WINDOWS)
HANDLE process_handle = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, FALSE, *pid);
if (process_handle == nullptr)
return true;
// FIXME: We should create an RAII wrapper around HANDLE objects.
ScopeGuard handle_guard = [&process_handle] { CloseHandle(process_handle); };
return process_handle == nullptr;
DWORD exit_code = 0;
if (GetExitCodeProcess(process_handle, &exit_code) == 0)
return true;
return exit_code != STILL_ACTIVE;
#else
return kill(*pid, 0) < 0;
#endif
}();
if (process_not_found) {
warnln("{} PID file '{}' exists with PID {}, but process cannot be found", process_name, pid_path, *pid);
TRY(Core::System::unlink(pid_path));