Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/CSS: Handle whitespace properly for border-radius properties

Browse source
This commit is contained in:
Sam Atkins 2025-10-28 15:52:22 +00:00
parent d44c3a0b34
commit a2cd5d5ec8
Notes: github-actions[bot] 2025-11-03 11:29:12 +00:00
2 changed files with 14 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -1835,25 +1835,19 @@ RefPtr<StyleValue const> Parser::parse_border_image_slice_value(TokenStream<Comp
RefPtr<StyleValue const> Parser::parse_border_radius_value(TokenStream<ComponentValue>& tokens)
{
if (tokens.remaining_token_count() == 2) {
auto transaction = tokens.begin_transaction();
auto horizontal = parse_length_percentage_value(tokens);
auto vertical = parse_length_percentage_value(tokens);
if (horizontal && vertical) {
transaction.commit();
return BorderRadiusStyleValue::create(horizontal.release_nonnull(), vertical.release_nonnull());
}
auto transaction = tokens.begin_transaction();
tokens.discard_whitespace();
auto horizontal = parse_length_percentage_value(tokens);
tokens.discard_whitespace();
auto vertical = parse_length_percentage_value(tokens);
if (horizontal && vertical) {
transaction.commit();
return BorderRadiusStyleValue::create(horizontal.release_nonnull(), vertical.release_nonnull());
}
if (tokens.remaining_token_count() == 1) {
auto transaction = tokens.begin_transaction();
auto radius = parse_length_percentage_value(tokens);
if (radius) {
transaction.commit();
return BorderRadiusStyleValue::create(*radius, *radius);
}
if (horizontal) {
transaction.commit();
return BorderRadiusStyleValue::create(*horizontal, *horizontal);
}
return nullptr;
}
@ -1902,6 +1896,7 @@ RefPtr<StyleValue const> Parser::parse_border_radius_shorthand_value(TokenStream
StyleValueVector vertical_radii;
bool reading_vertical = false;
auto transaction = tokens.begin_transaction();
tokens.discard_whitespace();
while (tokens.has_next_token()) {
if (tokens.next_token().is_delim('/')) {
@ -1910,6 +1905,7 @@ RefPtr<StyleValue const> Parser::parse_border_radius_shorthand_value(TokenStream
reading_vertical = true;
tokens.discard_a_token(); // `/`
tokens.discard_whitespace();
continue;
}
@ -1925,6 +1921,7 @@ RefPtr<StyleValue const> Parser::parse_border_radius_shorthand_value(TokenStream
} else {
horizontal_radii.append(maybe_dimension.release_nonnull());
}
tokens.discard_whitespace();
}
if (horizontal_radii.size() > 4 || vertical_radii.size() > 4