Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

RequestServer: Compute response ages without truncating sub-fractions

Browse source 
We can use Duration as-is without coercing values to seconds. This
probably doesn't make much difference in real-world scenarios, but when
we hammer the cache during tests, this truncation will cause flakey
behavior.
This commit is contained in:
Timothy Flynn 2025-11-14 16:57:02 -05:00 • committed by Jelle Raaijmakers
parent 44326c4d7f
commit a580392109
Notes: github-actions[bot] 2025-11-20 08:36:09 +00:00
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Services/RequestServer/Cache/Utilities.cpp
View file

@ -310,17 +310,17 @@ AK::Duration calculate_age(HTTP::HeaderMap const& headers, UnixDateTime request_
// without it.
auto date_value = parse_http_date(headers.get("Date"sv)).value_or(now);
auto apparent_age = max(0LL, (response_time - date_value).to_seconds());
auto apparent_age = max(AK::Duration::zero(), (response_time - date_value));
auto response_delay = response_time - request_time;
auto corrected_age_value = age_value + response_delay;
auto corrected_initial_age = max(apparent_age, corrected_age_value.to_seconds());
auto corrected_initial_age = max(apparent_age, corrected_age_value);
auto resident_time = (now - response_time).to_seconds();
auto resident_time = now - response_time;
auto current_age = corrected_initial_age + resident_time;
return AK::Duration::from_seconds(current_age);
return current_age;
}
CacheLifetimeStatus cache_lifetime_status(HTTP::HeaderMap const& headers, AK::Duration freshness_lifetime, AK::Duration current_age)