Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Introduce NativeJavaScriptBackedFunction

Browse source 
This hosts the ability to compile and run JavaScript to implement
native functions. This is particularly useful for any native function
that is not a normal function, for example async functions such as
Array.fromAsync, which require yielding.

These functions are not allowed to observe anything from outside their
environment. Any global identifiers will instead be assumed to be a
reference to an abstract operation or a constant. The generator will
inject the appropriate bytecode if the name of the global identifier
matches a known name. Anything else will cause a code generation error.
This commit is contained in:
Luke Wilde 2025-11-06 19:00:36 +00:00 • committed by Andreas Kling
parent 899c6ebffc
commit a63b0cfaba
Notes: github-actions[bot] 2025-11-30 10:56:11 +00:00
21 changed files with 412 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -474,8 +474,10 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> Identifier::generate_by
return local;
}
if (is_global() && m_string == "undefined"sv) {
return generator.add_constant(js_undefined());
if (is_global()) {
auto maybe_constant = TRY(generator.maybe_generate_builtin_constant(*this));
if (maybe_constant.has_value())
return maybe_constant.release_value();
}
auto dst = choose_dst(generator, preferred_dst);
@ -1718,6 +1720,7 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> CallExpression::generat
Optional<ScopedOperand> original_callee;
auto original_this_value = generator.add_constant(js_undefined());
auto dst = choose_dst(generator, preferred_dst);
Bytecode::Op::CallType call_type = Bytecode::Op::CallType::Call;
if (is<NewExpression>(this)) {
@ -1741,6 +1744,11 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> CallExpression::generat
// NOTE: If the identifier refers to a known "local" or "global", we know it can't be
// a `with` binding, so we can skip this.
auto& identifier = static_cast<Identifier const&>(*m_callee);
if (generator.builtin_abstract_operations_enabled() && identifier.is_global()) {
TRY(generator.generate_builtin_abstract_operation(identifier, arguments(), dst));
return dst;
}
if (identifier.string() == "eval"sv) {
call_type = Bytecode::Op::CallType::DirectEval;
}
@ -1776,7 +1784,6 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> CallExpression::generat
expression_string_index = generator.intern_string(expression_string.release_value());
bool has_spread = any_of(arguments(), [](auto& argument) { return argument.is_spread; });
auto dst = choose_dst(generator, preferred_dst);
if (has_spread) {
auto arguments = TRY(arguments_to_array_for_call(generator, this->arguments())).value();