Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb+WebContent: Rename the http-cache flag to http-memory-cache

Browse source 
Rather than having http-cache and http-disk-cache, let's rename the
former to http-memory-cache to be extra clear what we are talking about.
This commit is contained in:
Timothy Flynn 2025-12-01 15:11:27 -05:00 • committed by Andreas Kling
parent b376ab4e81
commit adcf5462af
Notes: github-actions[bot] 2025-12-02 11:21:10 +00:00
10 changed files with 31 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View file

@ -70,7 +70,7 @@
namespace Web::Fetch::Fetching {
bool g_http_cache_enabled = false;
bool g_http_memory_cache_enabled = false;
#define TRY_OR_IGNORE(expression) \
({ \
@ -1424,14 +1424,14 @@ public:
// - the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match, and
auto it = m_cache.find(url);
if (it == m_cache.end()) {
dbgln_if(HTTP_CACHE_DEBUG, "\033[31;1mHTTP CACHE MISS!\033[0m {}", url);
dbgln_if(HTTP_MEMORY_CACHE_DEBUG, "\033[31;1mHTTP CACHE MISS!\033[0m {}", url);
return {};
}
auto const& cached_response = it->value;
// - the request method associated with the stored response allows it to be used for the presented request, and
if (method != cached_response->method()) {
dbgln_if(HTTP_CACHE_DEBUG, "\033[31;1mHTTP CACHE MISS!\033[0m (Bad method) {}", url);
dbgln_if(HTTP_MEMORY_CACHE_DEBUG, "\033[31;1mHTTP CACHE MISS!\033[0m (Bad method) {}", url);
return {};
}
@ -1445,7 +1445,7 @@ public:
// + allowed to be served stale (see Section 4.2.4), or
// + successfully validated (see Section 4.3).
dbgln_if(HTTP_CACHE_DEBUG, "\033[32;1mHTTP CACHE HIT!\033[0m {}", url);
dbgln_if(HTTP_MEMORY_CACHE_DEBUG, "\033[32;1mHTTP CACHE HIT!\033[0m {}", url);
return cached_response->clone(realm);
}
@ -1498,7 +1498,7 @@ private:
// https://fetch.spec.whatwg.org/#determine-the-http-cache-partition
static RefPtr<CachePartition> determine_the_http_cache_partition(Infrastructure::Request const& request)
{
if (!g_http_cache_enabled)
if (!g_http_memory_cache_enabled)
return nullptr;
// 1. Let key be the result of determining the network partition key given request.
@ -1905,7 +1905,7 @@ GC::Ref<PendingResponse> http_network_or_cache_fetch(JS::Realm& realm, Infrastru
// 4. If the revalidatingFlag is set and forwardResponse’s status is 304, then:
if (revalidating_flag->value() && forward_response->status() == 304) {
dbgln_if(HTTP_CACHE_DEBUG, "\033[34;1mHTTP CACHE REVALIDATE (304)\033[0m {}", http_request->current_url());
dbgln_if(HTTP_MEMORY_CACHE_DEBUG, "\033[34;1mHTTP CACHE REVALIDATE (304)\033[0m {}", http_request->current_url());
// 1. Update storedResponse’s header list using forwardResponse’s header list, as per the "Freshening
// Stored Responses upon Validation" chapter of HTTP Caching.
@ -2524,17 +2524,17 @@ void append_fetch_metadata_headers_for_request(Infrastructure::Request& request)
set_sec_fetch_user_header(request);
}
void set_http_cache_enabled(bool const enabled)
void set_http_memory_cache_enabled(bool const enabled)
{
g_http_cache_enabled = enabled;
g_http_memory_cache_enabled = enabled;
}
bool http_cache_enabled()
bool http_memory_cache_enabled()
{
return g_http_cache_enabled;
return g_http_memory_cache_enabled;
}
void clear_http_cache()
void clear_http_memory_cache()
{
HTTPCache::the().clear_cache();
}

6
Libraries/LibWeb/Fetch/Fetching/Fetching.h
View file

@ -55,8 +55,8 @@ void set_sec_fetch_site_header(Infrastructure::Request&);
void set_sec_fetch_user_header(Infrastructure::Request&);
void append_fetch_metadata_headers_for_request(Infrastructure::Request&);
WEB_API void set_http_cache_enabled(bool enabled);
WEB_API bool http_cache_enabled();
WEB_API void clear_http_cache();
WEB_API void set_http_memory_cache_enabled(bool enabled);
WEB_API bool http_memory_cache_enabled();
WEB_API void clear_http_memory_cache();
}

4
Libraries/LibWeb/Internals/Internals.cpp
View file

@ -301,8 +301,8 @@ void Internals::expire_cookies_with_time_offset(WebIDL::LongLong seconds)
bool Internals::set_http_memory_cache_enabled(bool enabled)
{
auto was_enabled = Web::Fetch::Fetching::http_cache_enabled();
Web::Fetch::Fetching::set_http_cache_enabled(enabled);
auto was_enabled = Web::Fetch::Fetching::http_memory_cache_enabled();
Web::Fetch::Fetching::set_http_memory_cache_enabled(enabled);
return was_enabled;
}