Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWebView+UI: Don't declare a magic ctor for Application subclasses

Browse source 
You would have to just know that you need to define the constructor with
this declaration. Let's allow subclasses to define constructors as they
see fit.
This commit is contained in:
Timothy Flynn 2025-06-10 19:13:03 -04:00 • committed by Tim Flynn
parent 3a4f2faf2e
commit b425ce93b1
Notes: github-actions[bot] 2025-06-11 11:27:40 +00:00
7 changed files with 24 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
UI/AppKit/Application/Application.h
View file

@ -16,6 +16,8 @@ class Application final : public WebView::Application {
WEB_VIEW_APPLICATION(Application)
private:
explicit Application();
virtual Optional<ByteString> ask_user_for_download_folder() const override;
virtual NonnullOwnPtr<Core::EventLoop> create_platform_event_loop() override;
};

4
UI/AppKit/Application/Application.mm
View file

@ -17,9 +17,7 @@
namespace Ladybird {
Application::Application(Badge<WebView::Application>)
{
}
Application::Application() = default;
Optional<ByteString> Application::ask_user_for_download_folder() const
{

5
UI/Qt/Application.cpp
View file

@ -48,10 +48,7 @@ public:
}
};
Application::Application(Badge<WebView::Application>)
{
}
Application::Application() = default;
Application::~Application() = default;
void Application::create_platform_options(WebView::BrowserOptions&, WebView::WebContentOptions& web_content_options)

2
UI/Qt/Application.h
View file

@ -29,6 +29,8 @@ public:
void set_active_window(BrowserWindow& w) { m_active_window = &w; }
private:
explicit Application();
virtual void create_platform_options(WebView::BrowserOptions&, WebView::WebContentOptions&) override;
virtual NonnullOwnPtr<Core::EventLoop> create_platform_event_loop() override;