Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibCore+LibWeb: Remove the dummy EventReceiver from deferred_invoke()

Browse source 
The DeferredInvocationContext only existed to satisfy the requirement
in ThreadEventQueue that each event has an EventReceiver. However,
deferred_invoke() was not even using the EventReceiver to call its
callback. Therefore, we don't need to allocate one for every deferred
invocation.

This also prevents WeakPtr::strong_ref() from racing and leaking the
context object when invoking a function across threads.
This commit is contained in:
Zaggy1024 2025-12-02 01:31:00 -06:00 • committed by Gregory Bertilson
parent 970100e789
commit b572ae95a9
Notes: github-actions[bot] 2025-12-03 03:21:58 +00:00
14 changed files with 24 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWebView/EventLoop/EventLoopImplementationMacOS.h
View file

@ -41,7 +41,7 @@ public:
virtual void quit(int) override;
virtual void wake() override;
virtual bool was_exit_requested() const override;
virtual void post_event(Core::EventReceiver& receiver, NonnullOwnPtr<Core::Event>&&) override;
virtual void post_event(Core::EventReceiver*, NonnullOwnPtr<Core::Event>&&) override;
virtual ~EventLoopImplementationMacOS() override;