Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/CSS: Use AbstractElement animation helpers

Browse source
This commit is contained in:
Sam Atkins 2025-12-02 11:05:29 +00:00 • committed by Andreas Kling
parent dacc64cb8b
commit b61c857c64
Notes: github-actions[bot] 2025-12-03 12:31:15 +00:00
2 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/CSS/CSSTransition.cpp
View file

@ -102,9 +102,7 @@ CSSTransition::CSSTransition(JS::Realm& realm, DOM::AbstractElement abstract_ele
// that have been disassociated from their owning element but are still idle do not have a defined composite order.
// Construct a KeyframesEffect for our animation
m_keyframe_effect->set_target(&abstract_element.element());
if (abstract_element.pseudo_element().has_value())
m_keyframe_effect->set_pseudo_element(Selector::PseudoElementSelector { abstract_element.pseudo_element().value() });
m_keyframe_effect->set_target(abstract_element);
m_keyframe_effect->set_start_delay(delay);
m_keyframe_effect->set_iteration_duration(end_time - start_time);
m_keyframe_effect->set_timing_function(abstract_element.element().property_transition_attributes(abstract_element.pseudo_element(), property_id)->timing_function);

14
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1151,12 +1151,9 @@ void StyleComputer::process_animation_definitions(ComputedProperties const& comp
{
auto const& animation_definitions = computed_properties.animations();
// FIXME: Add some animation helpers to AbstractElement once pseudo-elements are animatable.
auto& element = abstract_element.element();
auto const& pseudo_element = abstract_element.pseudo_element();
auto& document = abstract_element.document();
auto* element_animations = element.css_defined_animations(pseudo_element);
auto* element_animations = abstract_element.css_defined_animations();
// If we have a nullptr for element_animations it means that the pseudo element was invalid and thus we shouldn't apply animations
if (!element_animations)
@ -1179,23 +1176,20 @@ void StyleComputer::process_animation_definitions(ComputedProperties const& comp
auto animation = CSSAnimation::create(document.realm());
animation->set_animation_name(animation_properties.name);
animation->set_timeline(document.timeline());
animation->set_owning_element(element);
animation->set_owning_element(abstract_element.element());
auto effect = Animations::KeyframeEffect::create(document.realm());
animation->set_effect(effect);
apply_animation_properties(document, animation_properties, animation);
if (pseudo_element.has_value())
effect->set_pseudo_element(Selector::PseudoElementSelector { pseudo_element.value() });
if (auto const* rule_cache = rule_cache_for_cascade_origin(CascadeOrigin::Author, {}, {})) {
if (auto keyframe_set = rule_cache->rules_by_animation_keyframes.get(animation_properties.name); keyframe_set.has_value())
effect->set_key_frame_set(keyframe_set.value());
}
effect->set_target(&element);
element.set_has_css_defined_animations();
effect->set_target(abstract_element);
abstract_element.set_has_css_defined_animations();
element_animations->set(animation_properties.name, animation);
}