Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2026-04-19 02:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Fire textarea input events immediately instead of debouncing

Browse source 
The 100ms debounce timer on textarea input events causes character
loss when JavaScript restores a previously captured value via
requestAnimationFrame. The text node mutation happens immediately
during input processing, but the input DOM event is delayed,
creating a window where stale rAF callbacks overwrite new input.

Remove the debounce timer and fire the input event immediately
via queue_an_element_task, matching HTMLInputElement behavior.
The spec notes this delay is optional ("User agents may wait").

Fixes #7793.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Dylan Hart 2026-03-27 03:34:39 -05:00 • committed by Tim Flynn
parent 36c549eba7
commit c710ff5afa
Notes: github-actions[bot] 2026-03-30 17:18:58 +00:00
2 changed files with 17 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

41
Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -33,9 +33,6 @@ GC_DEFINE_ALLOCATOR(HTMLTextAreaElement);
HTMLTextAreaElement::HTMLTextAreaElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: HTMLElement(document, move(qualified_name))
, m_input_event_timer(Core::Timer::create_single_shot(0, GC::weak_callback(*this, [](auto& self) {
self.queue_firing_input_event();
})))
{
}
@ -130,7 +127,13 @@ void HTMLTextAreaElement::clear_algorithm()
// Unlike their associated reset algorithms, changes made to form controls as part of these algorithms do count as
// changes caused by the user (and thus, e.g. do cause input events to fire).
queue_firing_input_event();
queue_an_element_task(HTML::Task::Source::UserInteraction, [this]() {
UIEvents::InputEventInit input_event_init;
input_event_init.bubbles = true;
input_event_init.composed = true;
auto input_event = UIEvents::InputEvent::create_from_platform_event(realm(), HTML::EventNames::input, input_event_init);
dispatch_event(input_event);
});
}
// https://html.spec.whatwg.org/multipage/forms.html#the-textarea-element:concept-node-clone-ext
@ -425,12 +428,16 @@ void HTMLTextAreaElement::did_edit_text_node(FlyString const& input_type, Option
// Any time the user causes the element's raw value to change, the user agent must queue an element task on the user
// interaction task source given the textarea element to fire an event named input at the textarea element, with the
// bubbles and composed attributes initialized to true. User agents may wait for a suitable break in the user's
// interaction before queuing the task; for example, a user agent could wait for the user to have not hit a key for
// 100ms, so as to only fire the event when the user pauses, instead of continuously for each keystroke.
m_pending_input_event_type = input_type;
m_pending_input_event_data = data;
m_input_event_timer->restart(100);
// bubbles and composed attributes initialized to true.
queue_an_element_task(HTML::Task::Source::UserInteraction, [this, input_type, data]() {
UIEvents::InputEventInit input_event_init;
input_event_init.bubbles = true;
input_event_init.composed = true;
input_event_init.input_type = input_type;
input_event_init.data = data;
auto input_event = UIEvents::InputEvent::create_from_platform_event(realm(), HTML::EventNames::input, input_event_init);
dispatch_event(input_event);
});
// A textarea element's dirty value flag must be set to true whenever the user interacts with the control in a way that changes the raw value.
m_dirty_value = true;
@ -444,20 +451,6 @@ EventResult HTMLTextAreaElement::handle_return_key(FlyString const& input_type)
return EventResult::Handled;
}
void HTMLTextAreaElement::queue_firing_input_event()
{
queue_an_element_task(HTML::Task::Source::UserInteraction, [this]() {
// https://w3c.github.io/uievents/#event-type-input
UIEvents::InputEventInit input_event_init;
input_event_init.bubbles = true;
input_event_init.composed = true;
input_event_init.input_type = m_pending_input_event_type;
input_event_init.data = m_pending_input_event_data;
auto input_event = UIEvents::InputEvent::create_from_platform_event(realm(), HTML::EventNames::input, input_event_init);
dispatch_event(input_event);
});
}
bool HTMLTextAreaElement::is_focusable() const
{
return enabled();