From ce2c4a3417ebde1f34eae956912864093a516078 Mon Sep 17 00:00:00 2001 From: InvalidUsernameException Date: Sat, 29 Nov 2025 10:16:38 +0100 Subject: [PATCH] LibGfx+LibWeb: Fix compile errors in clang-cl from recent header cleanup The recent commits 28ba610f325aaed5d20daebdd3cf732a04e62eaf and 70c4ed261fb446fe25396164400d09e0c0df8bc6 adjusted some include directives to avoid excessive recompilation when changing some header files. This has broken compilation with clang-cl on Windows without getting noticed before the PRs were merged. --- Libraries/LibGfx/Painter.cpp | 1 + Libraries/LibWeb/CSS/CSSImportRule.cpp | 2 ++ Libraries/LibWeb/CSS/CSSImportRule.h | 3 ++- Libraries/LibWeb/HTML/ImageBitmap.cpp | 2 ++ Libraries/LibWeb/HTML/ImageBitmap.h | 2 +- 5 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Libraries/LibGfx/Painter.cpp b/Libraries/LibGfx/Painter.cpp index c8a06a3f794..71ded32a29c 100644 --- a/Libraries/LibGfx/Painter.cpp +++ b/Libraries/LibGfx/Painter.cpp @@ -4,6 +4,7 @@ * SPDX-License-Identifier: BSD-2-Clause */ +#include #include #include #include diff --git a/Libraries/LibWeb/CSS/CSSImportRule.cpp b/Libraries/LibWeb/CSS/CSSImportRule.cpp index ffed330ec07..cfe65f5f46e 100644 --- a/Libraries/LibWeb/CSS/CSSImportRule.cpp +++ b/Libraries/LibWeb/CSS/CSSImportRule.cpp @@ -40,6 +40,8 @@ CSSImportRule::CSSImportRule(JS::Realm& realm, URL url, GC::Ptr d { } +CSSImportRule::~CSSImportRule() = default; + void CSSImportRule::initialize(JS::Realm& realm) { WEB_SET_PROTOTYPE_FOR_INTERFACE(CSSImportRule); diff --git a/Libraries/LibWeb/CSS/CSSImportRule.h b/Libraries/LibWeb/CSS/CSSImportRule.h index ba3c5a8b986..4575209bd38 100644 --- a/Libraries/LibWeb/CSS/CSSImportRule.h +++ b/Libraries/LibWeb/CSS/CSSImportRule.h @@ -13,6 +13,7 @@ #include #include #include +#include namespace Web::CSS { @@ -24,7 +25,7 @@ class WEB_API CSSImportRule final public: [[nodiscard]] static GC::Ref create(JS::Realm&, URL, GC::Ptr, RefPtr, Vector>); - virtual ~CSSImportRule() = default; + virtual ~CSSImportRule(); URL const& url() const { return m_url; } String href() const { return m_url.url(); } diff --git a/Libraries/LibWeb/HTML/ImageBitmap.cpp b/Libraries/LibWeb/HTML/ImageBitmap.cpp index 527ac814460..a8e3538c457 100644 --- a/Libraries/LibWeb/HTML/ImageBitmap.cpp +++ b/Libraries/LibWeb/HTML/ImageBitmap.cpp @@ -58,6 +58,8 @@ ImageBitmap::ImageBitmap(JS::Realm& realm) { } +ImageBitmap::~ImageBitmap() = default; + void ImageBitmap::initialize(JS::Realm& realm) { WEB_SET_PROTOTYPE_FOR_INTERFACE(ImageBitmap); diff --git a/Libraries/LibWeb/HTML/ImageBitmap.h b/Libraries/LibWeb/HTML/ImageBitmap.h index 1abd911f13a..591695bd636 100644 --- a/Libraries/LibWeb/HTML/ImageBitmap.h +++ b/Libraries/LibWeb/HTML/ImageBitmap.h @@ -35,7 +35,7 @@ class ImageBitmap final : public Bindings::PlatformObject public: static GC::Ref create(JS::Realm&); - virtual ~ImageBitmap() override = default; + virtual ~ImageBitmap() override; // ^Web::Bindings::Serializable virtual HTML::SerializeType serialize_type() const override { return HTML::SerializeType::ImageBitmap; }