Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibCore: Remove ability to post heap-allocated Core::Event objects

Browse source 
We no longer need this API since all clients have been converted to
simply posting the Core::Event::Type (or a callback function).
This commit is contained in:
Andreas Kling 2025-12-03 12:00:22 +01:00 • committed by Andreas Kling
parent 2a1c5dc108
commit cebc4d00dd
Notes: github-actions[bot] 2025-12-03 12:27:38 +00:00
14 changed files with 1 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibCore/ThreadEventQueue.cpp
View file

@ -21,13 +21,6 @@ struct ThreadEventQueue::Private {
AK_MAKE_DEFAULT_MOVABLE(QueuedEvent);
public:
QueuedEvent(RefPtr<EventReceiver> const& receiver, NonnullOwnPtr<Event> event)
: receiver(receiver)
, event(move(event))
, event_type(this->event->type())
{
}
QueuedEvent(RefPtr<EventReceiver> const& receiver, Event::Type event_type)
: receiver(receiver)
, event_type(event_type)
@ -43,7 +36,6 @@ struct ThreadEventQueue::Private {
~QueuedEvent() = default;
WeakPtr<EventReceiver> receiver;
OwnPtr<Event> event;
Function<void()> m_invokee;
u8 event_type { Event::Type::Invalid };
};
@ -81,15 +73,6 @@ ThreadEventQueue::ThreadEventQueue()
ThreadEventQueue::~ThreadEventQueue() = default;
void ThreadEventQueue::post_event(Core::EventReceiver* receiver, NonnullOwnPtr<Core::Event> event)
{
{
Threading::MutexLocker lock(m_private->mutex);
m_private->queued_events.empend(receiver, move(event));
}
Core::EventLoopManager::the().did_post_event();
}
void ThreadEventQueue::post_event(Core::EventReceiver* receiver, Core::Event::Type event_type)
{
{
@ -147,8 +130,7 @@ size_t ThreadEventQueue::process()
break;
}
default:
receiver->dispatch_event(*queued_event.event);
break;
VERIFY_NOT_REACHED();
}
} else {
if (queued_event.event_type == Event::Type::DeferredInvoke) {