Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Avoid whole DOM traversal in document_tree_child_navigables()

Browse source 
Instead, iterate through all registered navigables and pick the ones
that belong to document's tree, preserving tree order.
This commit is contained in:
Aliaksandr Kalenik 2025-11-24 21:47:40 +01:00 • committed by Jelle Raaijmakers
parent 4c22c372a4
commit d1f34efa64
Notes: github-actions[bot] 2025-11-25 08:17:27 +00:00
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/DOM/Document.cpp
View file

@ -4026,14 +4026,17 @@ Vector<GC::Root<HTML::Navigable>> Document::document_tree_child_navigables()
// 3. Let navigableContainers be a list of all descendants of document that are navigable containers, in tree order.
// 4. For each navigableContainer of navigableContainers:
for_each_in_subtree_of_type<HTML::NavigableContainer>([&](HTML::NavigableContainer& navigable_container) {
// 1. If navigableContainer's content navigable is null, then continue.
if (!navigable_container.content_navigable())
return TraversalDecision::Continue;
// 2. Append navigableContainer's content navigable to navigables.
navigables.append(*navigable_container.content_navigable());
return TraversalDecision::Continue;
});
// 1. If navigableContainer's content navigable is null, then continue.
// 2. Append navigableContainer's content navigable to navigables.
// OPTIMIZATION: Iterate all registered navigables to avoid a full tree traversal.
for (auto const& navigable : HTML::all_navigables()) {
auto container = navigable->container();
if (!container || !is_ancestor_of(*container))
continue;
navigables.insert_before_matching(*navigable, [&](auto const& existing_navigable) {
return container->is_before(*existing_navigable->container());
});
}
// 5. Return navigables.
return navigables;