Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Remove PaintableBox const_casts from ViewportPaintable

Browse source 
They're not necessary here - no functional changes.
This commit is contained in:
Jelle Raaijmakers 2025-11-17 10:02:40 +01:00 • committed by Jelle Raaijmakers
parent 9547889a6b
commit d7ebc4eef4
Notes: github-actions[bot] 2025-11-18 14:12:23 +00:00
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/Painting/ViewportPaintable.cpp
View file

@ -41,9 +41,9 @@ void ViewportPaintable::build_stacking_context_tree()
set_stacking_context(make<StackingContext>(*this, nullptr, 0));
size_t index_in_tree_order = 1;
for_each_in_subtree_of_type<PaintableBox>([&](auto const& paintable_box) {
const_cast<PaintableBox&>(paintable_box).invalidate_stacking_context();
auto* parent_context = const_cast<PaintableBox&>(paintable_box).enclosing_stacking_context();
for_each_in_subtree_of_type<PaintableBox>([&](auto& paintable_box) {
paintable_box.invalidate_stacking_context();
auto* parent_context = paintable_box.enclosing_stacking_context();
auto establishes_stacking_context = paintable_box.layout_node().establishes_stacking_context();
if ((paintable_box.is_positioned() || establishes_stacking_context) && paintable_box.computed_values().z_index().value_or(0) == 0)
parent_context->m_positioned_descendants_and_stacking_contexts_with_stack_level_0.append(paintable_box);
@ -54,7 +54,7 @@ void ViewportPaintable::build_stacking_context_tree()
return TraversalDecision::Continue;
}
VERIFY(parent_context);
const_cast<PaintableBox&>(paintable_box).set_stacking_context(make<Painting::StackingContext>(const_cast<PaintableBox&>(paintable_box), parent_context, index_in_tree_order++));
paintable_box.set_stacking_context(make<StackingContext>(paintable_box, parent_context, index_in_tree_order++));
return TraversalDecision::Continue;
});