Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-31 21:30:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

AK+LibCore: Avoid double-negation of syscall error values

Browse source 
This is a remnant from SerenityOS. Let's avoid confusion as to why we
negate errno when we call Error::from_syscall just to negate it again
when we store the error code.
This commit is contained in:
Timothy Flynn 2025-05-10 16:24:35 -04:00 • committed by Tim Flynn
parent 24ac5e2eee
commit dceed08058
Notes: github-actions[bot] 2025-05-11 01:21:05 +00:00
7 changed files with 100 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibCore/Process.cpp
View file

@ -182,7 +182,7 @@ ErrorOr<String> Process::get_name()
char buffer[BUFSIZ];
int rc = get_process_name(buffer, BUFSIZ);
if (rc != 0)
return Error::from_syscall("get_process_name"sv, -rc);
return Error::from_syscall("get_process_name"sv, rc);
return String::from_utf8(StringView { buffer, strlen(buffer) });
#elif defined(AK_LIBC_GLIBC) || (defined(AK_OS_LINUX) && !defined(AK_OS_ANDROID))
return String::from_utf8(StringView { program_invocation_name, strlen(program_invocation_name) });
@ -200,13 +200,13 @@ ErrorOr<void> Process::set_name([[maybe_unused]] StringView name, [[maybe_unused
#if defined(AK_OS_SERENITY)
int rc = set_process_name(name.characters_without_null_termination(), name.length());
if (rc != 0)
return Error::from_syscall("set_process_name"sv, -rc);
return Error::from_syscall("set_process_name"sv, rc);
if (set_thread_name == SetThreadName::No)
return {};
rc = prctl(PR_SET_THREAD_NAME, gettid(), name.characters_without_null_termination(), name.length());
if (rc != 0)
return Error::from_syscall("set_thread_name"sv, -rc);
return Error::from_syscall("set_thread_name"sv, rc);
return {};
#else
// FIXME: Implement Process::set_name() for other platforms.
@ -232,7 +232,7 @@ ErrorOr<bool> Process::is_being_debugged()
#elif defined(AK_OS_GNU_HURD)
process_t proc = getproc();
if (!MACH_PORT_VALID(proc))
return Error::from_syscall("getproc"sv, -errno);
return Error::from_syscall("getproc"sv, errno);
int flags = PI_FETCH_TASKINFO;
// We're going to ask the proc server for the info about our process,
@ -253,7 +253,7 @@ ErrorOr<bool> Process::is_being_debugged()
mach_port_deallocate(mach_task_self(), proc);
if (err) {
__hurd_fail(static_cast<error_t>(err));
return Error::from_syscall("proc_getprocinfo"sv, -errno);
return Error::from_syscall("proc_getprocinfo"sv, errno);
}
// Now cast the returned buffer pointer back to struct procinfo, and
@ -284,7 +284,7 @@ ErrorOr<bool> Process::is_being_debugged()
mib[3] = getpid();
if (sysctl(mib, sizeof(mib) / sizeof(*mib), &info, &size, NULL, 0) < 0)
return Error::from_syscall("sysctl"sv, -errno);
return Error::from_syscall("sysctl"sv, errno);
// We're being debugged if the P_TRACED flag is set.
# if defined(AK_OS_MACOS)
@ -346,7 +346,7 @@ ErrorOr<int> Process::wait_for_termination()
int exit_code = -1;
int status;
if (waitpid(m_pid, &status, 0) == -1)
return Error::from_syscall("waitpid"sv, -errno);
return Error::from_syscall("waitpid"sv, errno);
if (WIFEXITED(status)) {
exit_code = WEXITSTATUS(status);