mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	LibJS: Make Completion.[[Value]] non-optional
Instead, just use js_undefined() whenever the [[Value]] field is unused. This avoids a whole bunch of presence checks.
This commit is contained in:
		
							parent
							
								
									c0600c4353
								
							
						
					
					
						commit
						de424d6879
					
				
				
				Notes:
				
					github-actions[bot]
				
				2025-04-05 09:21:48 +00:00 
				
			
			Author: https://github.com/awesomekling
Commit: de424d6879
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4232
			
					 65 changed files with 225 additions and 250 deletions
				
			
		|  | @ -41,7 +41,7 @@ WebIDL::ExceptionOr<GC::Ref<TextEncoderStream>> TextEncoderStream::construct_imp | |||
| 
 | ||||
|         if (auto result = stream->encode_and_enqueue_chunk(chunk); result.is_error()) { | ||||
|             auto throw_completion = Bindings::exception_to_throw_completion(vm, result.exception()); | ||||
|             return WebIDL::create_rejected_promise(realm, *throw_completion.release_value()); | ||||
|             return WebIDL::create_rejected_promise(realm, throw_completion.release_value()); | ||||
|         } | ||||
| 
 | ||||
|         return WebIDL::create_resolved_promise(realm, JS::js_undefined()); | ||||
|  | @ -54,7 +54,7 @@ WebIDL::ExceptionOr<GC::Ref<TextEncoderStream>> TextEncoderStream::construct_imp | |||
| 
 | ||||
|         if (auto result = stream->encode_and_flush(); result.is_error()) { | ||||
|             auto throw_completion = Bindings::exception_to_throw_completion(vm, result.exception()); | ||||
|             return WebIDL::create_rejected_promise(realm, *throw_completion.release_value()); | ||||
|             return WebIDL::create_rejected_promise(realm, throw_completion.release_value()); | ||||
|         } | ||||
| 
 | ||||
|         return WebIDL::create_resolved_promise(realm, JS::js_undefined()); | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Andreas Kling
						Andreas Kling